Re: references to "destroying" a machine

2016-06-21 Thread James Beedy
Thanks, John. I'm trying to better familiarize myself with the juju-core code base. Is this an area that could use refactoring, or do you think a refactor for terminology consistency would lead to confusion in the sense that machines are actually being "destroyed" even though the command the user

Re: references to "destroying" a machine

2016-06-21 Thread John Meinel
This is a case where we had 'destroy-machine' as an operation in 1.x but changed the name for 2.0 to help with consistency, but that change didn't propagate throughout the code base. John =:-> On Jun 22, 2016 2:40 AM, "James Beedy" wrote: > Hey whats up guys? - Will there be a 'destroy-machine'

references to "destroying" a machine

2016-06-21 Thread James Beedy
Hey whats up guys? - Will there be a 'destroy-machine' command in the future? On that, do you think it would it be wise, or confusing to refactor references to 'DestroyMachine' or 'DestroyedMachines' or whatever variation of 'destroy machine' to a similar variation of 'remove machine'? I'm think

Re: about to land a breaking change

2016-06-21 Thread Horacio Duran
This just landed fyi. On Tue, Jun 21, 2016 at 8:36 AM, Horacio Duran wrote: > I am about to land a change in the way we persist user permissions in juju > core master, this will not change API but existing models/controllers will > stop working so please be aware of this before pulling the lates

Re: fslock is dead, long live mutex

2016-06-21 Thread Nate Finch
Thanks for this, Tim! Really happy to see that old fslock code go away, and using much more reliable OS-level functionality. On Tue, Jun 21, 2016 at 11:53 AM Alexis Bruemmer < alexis.bruem...@canonical.com> wrote: > Tim this is really awesome and will address a few long standing and > painful fi

Re: fslock is dead, long live mutex

2016-06-21 Thread Alexis Bruemmer
Tim this is really awesome and will address a few long standing and painful field bugs. Thank you for taking the extra effort to do this work! Also thank you to Nate Finch and David Cheney for their contributions on this effort. On Tue, Jun 21, 2016 at 2:24 AM, Tim Penhey wrote: > Hi folks, >

about to land a breaking change

2016-06-21 Thread Horacio Duran
I am about to land a change in the way we persist user permissions, this will not change API but existing models/controllers will stop working so please be aware of this before pulling the latest version of the code. -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe

fslock is dead, long live mutex

2016-06-21 Thread Tim Penhey
Hi folks, We have finally managed to exorcise the fslock from the codebase. Both 1.25 and master no longer refer to it at all. We need to remove it from the juju/utils package to make sure that people don't accidentally try and use it again. There is a new replacement, the juju/mutex package