Re: "unfairness" of juju/mutex

2016-11-17 Thread Andrew Wilkins
On Thu, Nov 17, 2016 at 10:07 PM roger peppe wrote: > On 17 November 2016 at 12:12, Stuart Bishop > wrote: > > On 17 November 2016 at 02:34, roger peppe > wrote: > >> > >> +1 to using blocking flock. Polling is a bad idea with a heavily > contended > >> lock. > >> > >> FWIW I still think that m

Re: "unfairness" of juju/mutex

2016-11-17 Thread roger peppe
On 17 November 2016 at 12:12, Stuart Bishop wrote: > On 17 November 2016 at 02:34, roger peppe wrote: >> >> +1 to using blocking flock. Polling is a bad idea with a heavily contended >> lock. >> >> FWIW I still think that mutexing all unit hooks is a bad idea >> that's really only there to paper

Re: "unfairness" of juju/mutex

2016-11-17 Thread Stuart Bishop
On 17 November 2016 at 02:34, roger peppe wrote: > +1 to using blocking flock. Polling is a bad idea with a heavily contended > lock. > > FWIW I still think that mutexing all unit hooks is a bad idea > that's really only there to paper over the problem that apt-get > doesn't work well concurrentl

Re: "unfairness" of juju/mutex

2016-11-17 Thread Adam Collard
FWIW this is being tracked in https://bugs.launchpad.net/juju/+bug/1642541 On Thu, 17 Nov 2016 at 04:17 Nate Finch wrote: > Just for historical reference. The original implementation of the new OS > mutex used flock until Dave mentioned that it presented problems with file > management (files

Re: "unfairness" of juju/mutex

2016-11-16 Thread Nate Finch
Just for historical reference. The original implementation of the new OS mutex used flock until Dave mentioned that it presented problems with file management (files getting renamed, deleted, etc). In general, I'm definitely on the side of using flock, though I don't think that necessarily solves

Re: "unfairness" of juju/mutex

2016-11-16 Thread Andrew Wilkins
On Wed, Nov 16, 2016 at 11:26 PM John Meinel wrote: > So we just ran into an issue when you are running multiple units on the > same machine and one of them is particularly busy. > > The specific case is when deploying Openstack and colocating things like > "monitoring" charms with the "keystone"

Re: "unfairness" of juju/mutex

2016-11-16 Thread roger peppe
+1 to using blocking flock. Polling is a bad idea with a heavily contended lock. FWIW I still think that mutexing all unit hooks is a bad idea that's really only there to paper over the problem that apt-get doesn't work well concurrently. cheers, rog. On 16 November 2016 at 15:26, John Me

"unfairness" of juju/mutex

2016-11-16 Thread John Meinel
So we just ran into an issue when you are running multiple units on the same machine and one of them is particularly busy. The specific case is when deploying Openstack and colocating things like "monitoring" charms with the "keystone" charm. Keystone itself has *lots* of things that relate to it,