Re: CI regressions will block merges

2014-07-30 Thread Curtis Hovey-Canonical
mgz advised me to revise the syntax to avoid confusing the Juju bot > Adding $$fixes-$$ as a comment to the PR will signal it > is allowed to test. The token can be in any comment and in any part When a merge testing into stable or devel is blocked by a critical regression, you can signal your br

Re: CI regressions will block merges

2014-07-29 Thread John Meinel
Thanks for updating the bot, Curtis. I think this is definitely an important thing to do. John =:-> On Tue, Jul 29, 2014 at 10:15 PM, Nate Finch wrote: > I'll fix 1342725 . > Sorry that one hasn't gotten in earlier. > > > On Tue, Jul 29, 201

Re: CI regressions will block merges

2014-07-29 Thread Nate Finch
I'll fix 1342725 . Sorry that one hasn't gotten in earlier. On Tue, Jul 29, 2014 at 2:09 PM, Horacio Duran wrote: > Since $$fixes-1342937$$ is already committed I changed the state by hand > in the bug report sorry I did not do that before, I

Re: CI regressions will block merges

2014-07-29 Thread Horacio Duran
Since $$fixes-1342937$$ is already committed I changed the state by hand in the bug report sorry I did not do that before, I forgot it was no longer automatic. On Tue, Jul 29, 2014 at 3:05 PM, Curtis Hovey-Canonical < cur...@canonical.com> wrote: > Magicians. > > I have updated the rules that t

CI regressions will block merges

2014-07-29 Thread Curtis Hovey-Canonical
Magicians. I have updated the rules that test merges to abort when there are ci regressions and the PR doesn't claim to fix one of them Three bugs currently block merges into master. CI is looking for one of these three token: $$fixes-1347715$$ $$fixes-1342725$$ $$fixes-1342937$$ Add