Re: Can we get rid of the hash(password) dance?

2014-07-17 Thread Ian Booth
FYI, Tanzanite is working on removing a lot (all) of the old legacy mongo connection stuff. We did a significant chunk at the induction sprint last week and are continuing the work this week and next. So taken together with the work described below (there may even be some overlap), our code base in

Re: Can we get rid of the hash(password) dance?

2014-07-17 Thread William Reade
Just to add to what already seems to be consensus: yes, the mongodb password dance is redundant and should be dropped. The API password dance remains important, but is not implicated here. Cheers Willliam On Thu, Jul 17, 2014 at 11:01 AM, John Meinel wrote: > ... > > >> From what I can tell po

Re: Can we get rid of the hash(password) dance?

2014-07-17 Thread John Meinel
... > From what I can tell poking around the code base, the only place that >> still uses the hash(password) is actually in the Dummy provider. >> >> > Right, and when I remove that code all the tests pass with some session > copying in place! > > https://github.com/voidspace/juju/compare/master.

Re: Can we get rid of the hash(password) dance?

2014-07-17 Thread Michael Foord
On 17/07/14 05:49, John Meinel wrote: Michael is working on changing how we handle sessions with Mongo, and noticed that his first attempt started running into Auth failures. It turned out that this was because of the hash(password) dance. (For those who don't know, in certain circumstances we

Re: Can we get rid of the hash(password) dance?

2014-07-17 Thread roger peppe
Ah yes, of course, you are totally right. It must go! On 17 Jul 2014 10:17, "John Meinel" wrote: > ... > > >> > From what I can tell poking around the code base, the only place that >> still >> > uses the hash(password) is actually in the Dummy provider. >> >> That's strictly true, but I don't t

Re: Can we get rid of the hash(password) dance?

2014-07-17 Thread John Meinel
... > > From what I can tell poking around the code base, the only place that > still > > uses the hash(password) is actually in the Dummy provider. > > That's strictly true, but I don't think it helps. We only use ssh to > provision > machines at bootstrap time. The usual provisioning case still

Fwd: Can we get rid of the hash(password) dance?

2014-07-16 Thread roger peppe
On 17 July 2014 05:49, John Meinel wrote: > Michael is working on changing how we handle sessions with Mongo, and > noticed that his first attempt started running into Auth failures. > It turned out that this was because of the hash(password) dance. (For those > who don't know, in certain circumst

Re: Can we get rid of the hash(password) dance?

2014-07-16 Thread roger peppe
On 17 July 2014 05:49, John Meinel wrote: > Michael is working on changing how we handle sessions with Mongo, and > noticed that his first attempt started running into Auth failures. > It turned out that this was because of the hash(password) dance. (For those > who don't know, in certain circumst

Re: Can we get rid of the hash(password) dance?

2014-07-16 Thread David Cheney
Yes, please! On Thu, Jul 17, 2014 at 2:49 PM, John Meinel wrote: > Michael is working on changing how we handle sessions with Mongo, and > noticed that his first attempt started running into Auth failures. > It turned out that this was because of the hash(password) dance. (For those > who don't k

Can we get rid of the hash(password) dance?

2014-07-16 Thread John Meinel
Michael is working on changing how we handle sessions with Mongo, and noticed that his first attempt started running into Auth failures. It turned out that this was because of the hash(password) dance. (For those who don't know, in certain circumstances we used to seed the password for the database