Re: Comprehensive reviews & when to do them?

2015-12-14 Thread Rick Harding
I think this is a bit of a difference in code review and feature QA. Doing something big at the end misses all the knowledge share, keeps things in silos for longer lengths of time without understanding the history, etc. Hey, maybe someone sees an obvious way to suggest doing those

Comprehensive reviews & when to do them?

2015-12-14 Thread Katherine Cox-Buday
Hey All, I think we have a mis-alignment in how we currently do reviews and feature branches. We've switched over to feature-branches which is great and has allowed Moonstone to land "good enough" code into our feature branch to support a bi-weekly demo and solicit feedback. At the same

Re: Comprehensive reviews & when to do them?

2015-12-14 Thread roger peppe
On 14 December 2015 at 15:39, Katherine Cox-Buday wrote: > Hey All, > > I think we have a mis-alignment in how we currently do reviews and feature > branches. > > We've switched over to feature-branches which is great and has allowed > Moonstone to land "good

Re: Comprehensive reviews & when to do them?

2015-12-14 Thread Nate Finch
I think that as long as we make it clear what kind of review we're asking for, and make sure that we really do follow up on review comments, that we can have the best of both worlds. I do think that reviewing once all the code is done is kind of fruitless... there's a lot more impetus to just