Re: Please don't use bash when there are syscalls available

2014-09-10 Thread Nate Finch
Thanks for the clarification, I misunderstood what the code was doing. I'm glad to hear this code won't be needed for much longer, but I think we should backport your explicit check so that non-english users can use Juju. On Tue, Sep 9, 2014 at 6:56 PM, Andrew Wilkins

Re: Please don't use bash when there are syscalls available

2014-09-10 Thread Andrew Wilkins
On Wed, Sep 10, 2014 at 6:57 PM, Nate Finch nate.fi...@canonical.com wrote: Thanks for the clarification, I misunderstood what the code was doing. I'm glad to hear this code won't be needed for much longer, but I think we should backport your explicit check so that non-english users can use

Please don't use bash when there are syscalls available

2014-09-09 Thread Nate Finch
A user just complained that he can't bootstrap because Juju is parsing stderr text from flock, and his server isn't in English, so the error message isn't matching. https://github.com/juju/juju/blob/master/environs/sshstorage/storage.go#L254 Now, I think we all know that parsing error text is a

Re: Please don't use bash when there are syscalls available

2014-09-09 Thread Gustavo Niemeyer
Worth keeping in mind the usual gotcha: the API of syscall is different for different OSes. On Tue, Sep 9, 2014 at 5:45 PM, Nate Finch nate.fi...@canonical.com wrote: A user just complained that he can't bootstrap because Juju is parsing stderr text from flock, and his server isn't in English,

Re: Please don't use bash when there are syscalls available

2014-09-09 Thread Andrew Wilkins
On Wed, Sep 10, 2014 at 4:45 AM, Nate Finch nate.fi...@canonical.com wrote: A user just complained that he can't bootstrap because Juju is parsing stderr text from flock, and his server isn't in English, so the error message isn't matching.

Re: Please don't use bash when there are syscalls available

2014-09-09 Thread John Meinel
If we do need to parse the error message, we could use the LANG=C trick. But yes, I'd rather avoid it if possible. John =:- On Wed, Sep 10, 2014 at 2:56 AM, Andrew Wilkins andrew.wilk...@canonical.com wrote: On Wed, Sep 10, 2014 at 4:45 AM, Nate Finch nate.fi...@canonical.com wrote: A user