On 24/04/2015, roger peppe wrote:
>
> Are you sure? It seems to return a non-zero exit status for me.
I guess you're not using ubuntu packaged go, but something trunkier?
> I guess it (and the other point) might be a consequence of running
> a different version of govet.
$ dpkg -s golang-go.too
On 24 April 2015 at 14:21, Martin Packman wrote:
> On 24/04/2015, David Cheney wrote:
>> Why doesn't the bot run this hook ?
>
> It does - but there are two problems:
>
> 1) For the gating job to reject the change, the script just has not
> return non-zero. Seems `go tool vet` returns 0 even if i
On 24/04/2015, David Cheney wrote:
> Why doesn't the bot run this hook ?
It does - but there are two problems:
1) For the gating job to reject the change, the script just has not
return non-zero. Seems `go tool vet` returns 0 even if it reports
issues. So, scripts/verify.bash needs updating if y
Sorry. I was not clear.
Why isn't the bot running the pre-commit hook as part of the CI test ?
What we have now is a warning, gleefully ignored.
What we need is an error, which rejects the PR if it doesn't pass the
pre-commit hook.
On Fri, Apr 24, 2015 at 10:28 PM, John Meinel wrote:
> The bot
The bot cannot make changes to the tree and commit it back to trunk,
because it doesn't have direct push rights to github. Instead it has API
rights to "accept this merge". So even if it did run the changes, it
wouldn't end up in trunk, and we could only reject the merge if it changed
things. (As I
Why doesn't the bot run this hook ?
On Fri, Apr 24, 2015 at 9:54 PM, Matthew Williams
wrote:
> There's a very useful pre-push hook available for juju that does useful
> things like run gofmt, go vet, checks we can build etc.
>
> If you don't have it setup there's some lovely instructions in
> Con
There's a very useful pre-push hook available for juju that does useful
things like run gofmt, go vet, checks we can build etc.
If you don't have it setup there's some lovely instructions in
Contributing.md:
https://github.com/juju/juju/blob/master/CONTRIBUTING.md#local-clone
Thanks for listenin
