Re: reviewboard update

2014-11-17 Thread John Meinel
FWIW, I'd rather we used HTTPS and just fixed whatever issues we had with Ship It, etc. But I'm certainly happiest just to see it working. John =:-> On Mon, Nov 17, 2014 at 6:55 PM, Eric Snow wrote: > On Mon, Nov 17, 2014 at 5:10 AM, Dimiter Naydenov > wrote: > > I can confirm RB diffs for ba

Re: reviewboard update

2014-11-17 Thread Eric Snow
On Mon, Nov 17, 2014 at 5:10 AM, Dimiter Naydenov wrote: > I can confirm RB diffs for backports to 1.21 get generated correctly > now, and the PR description is updated to include a link to the RB diff. Thanks for reporting on this. > > There's one issue however -- the link in the PR is > "https

Re: reviewboard update

2014-11-17 Thread Dimiter Naydenov
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 15.11.2014 07:07, Eric Snow wrote: > FYI, I was able to solve 3 reviewboard-github integration issues > today: > > 1. pull requests for branches other than master now work (e.g. 1.21 > backports) 2. no more hitting rate limits (5000 requests/hour l

Re: reviewboard update

2014-11-15 Thread Nate Finch
Awesome, nice work! On Nov 15, 2014 12:07 AM, "Eric Snow" wrote: > FYI, I was able to solve 3 reviewboard-github integration issues today: > > 1. pull requests for branches other than master now work (e.g. 1.21 > backports) > 2. no more hitting rate limits (5000 requests/hour limit instead of 60)

reviewboard update

2014-11-14 Thread Eric Snow
FYI, I was able to solve 3 reviewboard-github integration issues today: 1. pull requests for branches other than master now work (e.g. 1.21 backports) 2. no more hitting rate limits (5000 requests/hour limit instead of 60) 3. pull request bodies now get updated with a link to the new review reques