Re: [JPP-Devel] A couple of changes for the PlugInManager class.

2010-01-15 Thread Sunburned Surveyor
Finally getting back to this. I'm not sure how we can show the user a message in this case. I would normally use the Workbench to do this, but it isn't shown yet because we are still trying to load plug-ins when the error is generated. I'm not sure if we could show a dialog bog with an error messag

Re: [JPP-Devel] A couple of changes for the PlugInManager class.

2009-10-19 Thread Stefan Steiniger
ok! but yes.. a message should appear if loading of plugin(s) failed - and which. stefan Sunburned Surveyor wrote: > Stefan wrote: "I was thinking it just brings up an error message > (clickable box) - > similar to the case if I use a workbench-properties file in eclipse." > > In any case, I

Re: [JPP-Devel] A couple of changes for the PlugInManager class.

2009-10-19 Thread Sunburned Surveyor
Stefan wrote: "I was thinking it just brings up an error message (clickable box) - similar to the case if I use a workbench-properties file in eclipse." In any case, I believe my change will avoid interupting the user altogether by ignoring classes that aren't of the correct type. But perhaps thi

Re: [JPP-Devel] A couple of changes for the PlugInManager class.

2009-10-19 Thread Larry Becker
Hi Stefan, > it should go as new utility method, but do not remove it from the >manager - because we would loose compatibility. Do, make it only >deprecated. Good point,but toURLS is a Private method, so compatibility really isn't a factor. regards, Larry On Mon, Oct 19, 2009 at 11:32 AM, Stefa

Re: [JPP-Devel] A couple of changes for the PlugInManager class.

2009-10-19 Thread Stefan Steiniger
> > - Check for valid implementations of the PlugIn class in the > loadPlugInClasses method. This will prevent program load problems if > someone inadvertently lists a non-plug-in class in the workbench > properties file. It doesn't appear from my inspection that this check >

Re: [JPP-Devel] A couple of changes for the PlugInManager class.

2009-10-16 Thread Sunburned Surveyor
Larry, Thanks for running that test. I should have done that myself. I will whip up a patch for the fix and will get Stefan to give the OK before I commit it. Landon On Fri, Oct 16, 2009 at 11:31 AM, Larry Becker wrote: > Hi SS, > >   OK, I tried your scenario by listing the following in defaul

Re: [JPP-Devel] A couple of changes for the PlugInManager class.

2009-10-16 Thread Larry Becker
Hi SS, OK, I tried your scenario by listing the following in default-plugins.xml: org.openjump.core.ui.plugin.edittoolbox.cursortools.CutPolygonTool I got an "Instantiation error" exception and OJ hung up. I agree that this is not good behavior. If you have a fix for it, I think OJ should us

[JPP-Devel] A couple of changes for the PlugInManager class.

2009-10-12 Thread Sunburned Surveyor
I'd like to suggest a couple of minor changes to the PlugInManager class: - Check for valid implementations of the PlugIn class in the loadPlugInClasses method. This will prevent program load problems if someone inadvertently lists a non-plug-in class in the workbench properties file. It doesn't a