Re: [JPP-Devel] Mouse wheel zoom and WMS

2010-02-26 Thread Larry Becker
OK, I found a dataset that easily reproduces what I think is Benjamin's mouse wheel zoom redraw anomaly. What seems to be happening is that in areas where vector redraw takes a few seconds or more, multiple mouse wheel zooms, separated by more that .7 seconds, do not allow the screen to repaint en

Re: [JPP-Devel] Mouse wheel zoom and WMS

2010-02-25 Thread Larry Becker
I have restored "zoom to cursor" on mouse wheel zoom. Larry On Thu, Feb 25, 2010 at 8:49 AM, Larry Becker wrote: > Darn. I was noticing the anomaly occurred for me when I accidentally > pressed the mouse wheel button (which initiates a regular zoom in the middle > of a mouse wheel zoom. Part o

Re: [JPP-Devel] Mouse wheel zoom and WMS

2010-02-25 Thread Larry Becker
Darn. I was noticing the anomaly occurred for me when I accidentally pressed the mouse wheel button (which initiates a regular zoom in the middle of a mouse wheel zoom. Part of the difficulty of mouse wheel zoom is that, unlike the zoom realtime tool, it is not modal and other events can interrup

Re: [JPP-Devel] Mouse wheel zoom and WMS

2010-02-24 Thread Benjamin Gudehus
It reproduces with hand tool. Tested with nightly builds from 23th and 25th february. 2010/2/25 Larry Becker > Hi Benjamin, > > Could you try to reproduce the anomaly when mouse wheel zooming with the > "hand" tool please? If it doesn't reproduce, I may know what is happening. > > thanks, > L

Re: [JPP-Devel] Mouse wheel zoom and WMS

2010-02-24 Thread Larry Becker
Hi Benjamin, Could you try to reproduce the anomaly when mouse wheel zooming with the "hand" tool please? If it doesn't reproduce, I may know what is happening. thanks, Larry On Wed, Feb 24, 2010 at 12:06 PM, Benjamin Gudehus wrote: > @white space when zooming out: > > Maybe you can use the

Re: [JPP-Devel] Mouse wheel zoom and WMS

2010-02-24 Thread Benjamin Gudehus
@white space when zooming out: Maybe you can use the drawing algorithm that draw the geometries like a pencil sketch when zooming with the slidebar (and then rerender the geometries at a given time interval). Screenshot: http://www.imagebanana.com/img/91inbax/pencil_sketch.jpg --Benjamin 2010/2

Re: [JPP-Devel] Mouse wheel zoom and WMS

2010-02-24 Thread Benjamin Gudehus
Hi Larry, there should really be an option the choose between the old and new zooming algorithm (if possible). Zooming out feels slowly, when I first have to wait for the rendering of missing geometries in the white space around the image of the previous zoom level. (B) This anomaly happens cons

Re: [JPP-Devel] Mouse wheel zoom and WMS

2010-02-23 Thread Larry Becker
Hi Benjamin, (A) I like the old zoom to mouse position behavior too. I just haven't gotten the zoom to cursor math right yet. (B) You might be right. I've noticed an occasional anomaly too, but can't reproduce it consistently. I don't know what is causing it. regards, Larry On Tue, Feb 2

Re: [JPP-Devel] Mouse wheel zoom and WMS

2010-02-23 Thread Benjamin Gudehus
Hi! I tested the new mouse wheel zoom with the nightly build from 23-Feb-2010 02:12. (A) In previous versions the zoom function zoomed-in to the current position of the mouse cursor. The new behavour is, that it just zooms to the position in middle of the layerviewpanel. I'd like to have the old

Re: [JPP-Devel] Mouse wheel zoom and WMS

2010-02-11 Thread Larry Becker
I accidentally reversed the Mouse wheel zoom direction in the last update. It should now zoom in when the wheel is rolled away from your hand as other mapping programs do. regards, Larry On Thu, Feb 4, 2010 at 11:04 AM, Stefan Steiniger wrote: > mhm... my plan was working on a release towards A

Re: [JPP-Devel] Mouse wheel zoom and WMS

2010-02-04 Thread Stefan Steiniger
mhm... my plan was working on a release towards April. Need to think about it ;) the EZ buttons are now added as default (but even hardcoded in OpenJUMPConfiguration and not the xml file). Rahkonen Jukka wrote: > Hi, > > Excellent job. Mouse wheel zooming gives a good feeling because screen

Re: [JPP-Devel] Mouse wheel zoom and WMS

2010-02-03 Thread Rahkonen Jukka
Hi, Excellent job. Mouse wheel zooming gives a good feeling because screen is updating fast and from the server side I can see also that no unnecessary WMS calls are sent. That gives more speed for OJ user especially with slow connection to WMS but the feature itself is nice even without WMS la

Re: [JPP-Devel] Mouse wheel zoom and WMS

2010-02-03 Thread Sunburned Surveyor
Thanks Larry. I will try these changes out tomorrow. If they work, I'll get them ported over to BizzJUMP. SS On Wed, Feb 3, 2010 at 7:19 AM, Larry Becker wrote: > More Mouse Wheel Zooming updates.  I fixed some problems with mouse wheel > zoom in and zoom out in the same half second causing radi

Re: [JPP-Devel] Mouse wheel zoom and WMS

2010-02-03 Thread Larry Becker
More Mouse Wheel Zooming updates. I fixed some problems with mouse wheel zoom in and zoom out in the same half second causing radical changes. The Timer period now resets while the wheel is still moving, and I changed the Timer period to .7 seconds to better reflect actual use. Larry On Tue, Feb

Re: [JPP-Devel] Mouse wheel zoom and WMS

2010-02-02 Thread Larry Becker
OK, I have committed an experimental version of AbstractZoomTool that incorporates a deferred mouse wheel zoom for half a second. It does an image stretch from the center of the panel until the half second expires. Please test after tomorrow's nightly build. Comments? regards, Larry On Mon, F

Re: [JPP-Devel] Mouse wheel zoom and WMS

2010-02-01 Thread Sunburned Surveyor
Jukka, Can you file a feature request on SourceForge so we don't forget this? The Sunburned Surveyor On Mon, Feb 1, 2010 at 7:12 AM, Larry Becker wrote: > Hi Jukka, > >   The behavior you described is what I programmed for the mouse wheel > zooming.  I like the idea of doing raster scaling unti

Re: [JPP-Devel] Mouse wheel zoom and WMS

2010-02-01 Thread Larry Becker
Hi Jukka, The behavior you described is what I programmed for the mouse wheel zooming. I like the idea of doing raster scaling until you stop using the wheel. It is just a matter of finding time to do it. As you can imagine, this is fairly difficult code to write, but I believe it to be an i

[JPP-Devel] Mouse wheel zoom and WMS

2010-02-01 Thread Rahkonen Jukka
Hi, I have not used disk wheel zoom a lot and I discovered just now that when zooming with mouse wheel, OpenJUMP is sending a new WMS call for each wheel "click". As a WMS server manager I do not like this behaviour at all. WMS server is really sending an image for each click but OpenJUMP does

Re: [JPP-Devel] Mouse wheel zoom

2007-08-21 Thread Stefan Steiniger
ok.. i just tested a bit.. and i think it is ok using the mouse center as zoom center.. it goes slow, so that one does not recognize it realy. cool work.. and also the new zoom tool stefan Stefan Steiniger schrieb: > I know.. very late (over the weekend i have been on an openair) > > but if i

Re: [JPP-Devel] Mouse wheel zoom

2007-08-21 Thread Stefan Steiniger
I know.. very late (over the weekend i have been on an openair) but if i could choose, i would prefer a "mouse-center-zoom" with an activated key (such as ctrl). From my point of view "Google" is not a reference, although they have some pretty nice usability stuff. But we should not miss that

Re: [JPP-Devel] Mouse wheel zoom

2007-08-20 Thread Sunburned Surveyor
Thanks for the clarification Larry and Paul. I'm very grateful that I have the opportunity to learn from programmers of your skill level. To me, this is one of the greatest benefits of open source development. The Sunburned Surveyor On 8/20/07, Larry Becker <[EMAIL PROTECTED]> wrote: > Hi SS, > >

Re: [JPP-Devel] Mouse wheel zoom

2007-08-20 Thread Larry Becker
Hi SS, Nothing profound, just that in general, it isn't really a good idea to grab and hold onto object references that might be changed elsewhere. It doesn't really apply to the specific case that Paul was talking about. As you know from fixing OJ bugs, the biggest thread safety issue is Colle

Re: [JPP-Devel] Mouse wheel zoom

2007-08-20 Thread Paul Austin
Consider the following code (won't compile just for example) that does some complex operation on a layer and then loops through the features in the layer after it is processed. This is actually a counter argument to what Larry was suggesting. public void execute(PluginContext context) { doSom

Re: [JPP-Devel] Mouse wheel zoom

2007-08-20 Thread Sunburned Surveyor
Larry, I have to ask a really dumb rookie progammer question now. You wrote: "As you might have noticed, JUMP code tends not to create many variables. With threading, there is actually some justification for this." What affect does variable creation have on threaded programs? The Sunburned Surve

Re: [JPP-Devel] Mouse wheel zoom

2007-08-17 Thread Larry Becker
Those duplicate method calls are mostly cut and pasted from PanTool code. As you might have noticed, JUMP code tends not to create many variables. With threading, there is actually some justification for this. I've gotten used to it over the years and don't really notice it much anymore. I've qu

Re: [JPP-Devel] Mouse wheel zoom

2007-08-17 Thread Paul Austin
Larry, Before you commit, can you replace duplicate method calls such as getPanel().getViewport() with a local variable and make the method call once. There are two reasons for this. 1. There is less code to read on each line which makes working out what is going on easier. 2. When debuging if yo

Re: [JPP-Devel] Mouse wheel zoom

2007-08-17 Thread Larry Becker
Well, I guess I'll commit the change on the strength or Paul and Sunburn's recommendation. We can always back out the change if we don't like it. Larry On 8/17/07, Larry Becker <[EMAIL PROTECTED]> wrote: > Hi Paul, > > Some of the functionality you are talking about is already present > in my

Re: [JPP-Devel] Mouse wheel zoom

2007-08-17 Thread Larry Becker
Hi Paul, Some of the functionality you are talking about is already present in my new ZoomRealTime tool, which pans and zooms continuously in real time. Perhaps I should port it over (it just needs internationalization) before doing any more tweaks to Mouse Wheel Zoom, which I thought was prett

Re: [JPP-Devel] Mouse wheel zoom

2007-08-17 Thread Paul Austin
Hi Larry, Normally I hate people messing with my mouse pointer but in this case I would find it useful. Here are the three options for mouse wheel zooming that I see. 1. Zoom in and out of the current viewport center (not that useful in my view). 2. Zoom in and out at the current mou

Re: [JPP-Devel] Mouse wheel zoom

2007-08-17 Thread Larry Becker
Hmm, that seems a bit confusing to the user, especially if accidentally invoked. I've never been fond of interfaces that take control of my cursor, like jumping it to be over the default button. It might have a bad interaction with other modes for accessibility such as mouse keys. However if you

Re: [JPP-Devel] Mouse wheel zoom

2007-08-17 Thread Paul Austin
Hi Larry, What I wanted to do is move the cursor and the point to the center of the viewport. Paul Larry Becker wrote: > OK the code to perform the mouse wheel zoom at cursor is: > > public void mouseWheelMoved(MouseWheelEvent e) { > int nclicks = e.getWheelRotation(); //neg

Re: [JPP-Devel] Mouse wheel zoom

2007-08-17 Thread Larry Becker
OK the code to perform the mouse wheel zoom at cursor is: public void mouseWheelMoved(MouseWheelEvent e) { int nclicks = e.getWheelRotation(); //negative is up/away try { double zoomFactor = (nclicks > 0) ? (1 / (Math.abs(nclicks)*WHEEL_

Re: [JPP-Devel] Mouse wheel zoom

2007-08-17 Thread Larry Becker
Now that I think of it, I guess I didn't really give the mode a chance. The ZoomAt method will zoom to any point, but then that point becomes the center of the window. In order for it to work correctly, you would have to make a ZoomTo? function that would keep the zoom point under the cursor. La

Re: [JPP-Devel] Mouse wheel zoom

2007-08-17 Thread Paul Austin
Does anyone know the easiest way to move the mouse pointer to the center of the map viewport. What I want to do is when you zoom using my suggested center at current mouse location on Shirt + mouse wheel that it moves the mouse to the center of the viewport. This way if you want to zoom in several

Re: [JPP-Devel] Mouse wheel zoom

2007-08-17 Thread Sunburned Surveyor
Paul, I have always found the function of mouse wheel zoom that you described very useful. It reduces the need for panninf when you zoom in on an object. The Sunburned Surveyor On 8/16/07, Larry Becker <[EMAIL PROTECTED]> wrote: > Hi Paul, > > I tried that method and didn't find it useful, but

Re: [JPP-Devel] Mouse wheel zoom

2007-08-16 Thread Larry Becker
Hi Paul, I tried that method and didn't find it useful, but the code is still there commented out if you want to test it yourself. //zoomAt(e.getPoint(), zoomFactor); //zoom to cursor regards, Larry On 8/16/07, Paul Austin <[EMAIL PROTECTED]> wrote: > I just thought of an interesting enhance

[JPP-Devel] Mouse wheel zoom

2007-08-16 Thread Paul Austin
I just thought of an interesting enhancement to the mouse wheel zoom functionality At the moment when you zoom it zooms in and out based on the existing window center. What would be useful is if you could use the mouse location as the center when zooming in (and maybe out). This may confuse some

Re: [JPP-Devel] Mouse Wheel Zoom

2007-08-15 Thread Larry Becker
I have updated the changeLog with entries for Mouse Wheel Zoom and Image Layer fix. Larry On 8/15/07, Stefan Steiniger <[EMAIL PROTECTED]> wrote: > Hei Larry, > > thanx for adding the mousewheel support :) > > can you also update the changeLog file with your changes? > > thank you > stefan > > La

Re: [JPP-Devel] Mouse Wheel Zoom

2007-08-15 Thread Stefan Steiniger
Hei Larry, thanx for adding the mousewheel support :) can you also update the changeLog file with your changes? thank you stefan Larry Becker schrieb: > Yep, along with some support in ZoomTool. > > Larry > > On 8/14/07, Sunburned Surveyor <[EMAIL PROTECTED]> wrote: >> This is great news Larr

Re: [JPP-Devel] Mouse Wheel Zoom

2007-08-14 Thread Larry Becker
Yep, along with some support in ZoomTool. Larry On 8/14/07, Sunburned Surveyor <[EMAIL PROTECTED]> wrote: > This is great news Larry. > > I'm just curious, how did you go about adding support for mouse wheel > zoom. Did you add a mouse listener to the LayerViewPanel. > > SS > > On 8/14/07, Larry

Re: [JPP-Devel] Mouse Wheel Zoom

2007-08-14 Thread Michaël Michaud
Yes, good new Larry ! I just updated the sources, compiled, and I can tell it works perfecly fine :-) Michaël Larry Becker a écrit : >I have ported over the Mouse Wheel Zoom support from SkyJUMP. I >should appear in OJ's nightly build (assuming I didn't break it). > >regards, >Larry Becker >

Re: [JPP-Devel] Mouse Wheel Zoom

2007-08-14 Thread Sunburned Surveyor
This is great news Larry. I'm just curious, how did you go about adding support for mouse wheel zoom. Did you add a mouse listener to the LayerViewPanel. SS On 8/14/07, Larry Becker <[EMAIL PROTECTED]> wrote: > I have ported over the Mouse Wheel Zoom support from SkyJUMP. I > should appear in O

[JPP-Devel] Mouse Wheel Zoom

2007-08-14 Thread Larry Becker
I have ported over the Mouse Wheel Zoom support from SkyJUMP. I should appear in OJ's nightly build (assuming I didn't break it). regards, Larry Becker -- http://amusingprogrammer.blogspot.com/ - This SF.net email is sponso