[jira] [Commented] (KAFKA-349) Create individual "Response" types for each kind of request and wrap them with "BoundedByteBufferSend", remove "xxResponseSend" types for all requests except "FetchReque

2012-05-31 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286737#comment-13286737 ] Jun Rao commented on KAFKA-349: --- Thanks for patch v6. Some new comments: 61. FetchResponse,

Re: setters and getters

2012-05-31 Thread Joel Koshy
Agreed - if there are no objections, I can add this to our coding conventions page. Joel On Wed, May 30, 2012 at 11:24 PM, Jay Kreps wrote: > Cool, so let's standardize on that approach then? > > -Jay > > On Wed, May 30, 2012 at 4:09 PM, Joel Koshy wrote: > > > Update - there must have been so

[jira] Subscription: outstanding kafka patches

2012-05-31 Thread jira
Issue Subscription Filter: outstanding kafka patches (33 issues) The list of outstanding kafka patches Subscriber: kafka-mailing-list Key Summary KAFKA-349 Create individual "Response" types for each kind of request and wrap them with "BoundedByteBufferSend", remove "xxResponseS

Re: setters and getters

2012-05-31 Thread Jay Kreps
That would be great. -Jay On Thu, May 31, 2012 at 11:22 AM, Joel Koshy wrote: > Agreed - if there are no objections, I can add this to our coding > conventions page. > > Joel > > On Wed, May 30, 2012 at 11:24 PM, Jay Kreps wrote: > > > Cool, so let's standardize on that approach then? > > > >

[jira] [Commented] (KAFKA-350) Improve the high water mark maintenance to store high watermarks for all partitions in a single file on disk

2012-05-31 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287007#comment-13287007 ] Neha Narkhede commented on KAFKA-350: - Handle the logic of deleting segments that have

[jira] [Created] (KAFKA-354) Refactor getter and setter API to conform to the new convention

2012-05-31 Thread Neha Narkhede (JIRA)
Neha Narkhede created KAFKA-354: --- Summary: Refactor getter and setter API to conform to the new convention Key: KAFKA-354 URL: https://issues.apache.org/jira/browse/KAFKA-354 Project: Kafka Is

[jira] [Created] (KAFKA-355) Move high watermark maintenance logic out of Log

2012-05-31 Thread Neha Narkhede (JIRA)
Neha Narkhede created KAFKA-355: --- Summary: Move high watermark maintenance logic out of Log Key: KAFKA-355 URL: https://issues.apache.org/jira/browse/KAFKA-355 Project: Kafka Issue Type: Sub-ta

[jira] [Created] (KAFKA-356) Create a generic Kafka thread class that includes basic boiler plate code of instantiating and shutting down threads cleanly

2012-05-31 Thread Neha Narkhede (JIRA)
Neha Narkhede created KAFKA-356: --- Summary: Create a generic Kafka thread class that includes basic boiler plate code of instantiating and shutting down threads cleanly Key: KAFKA-356 URL: https://issues.apache.org/j

[jira] [Updated] (KAFKA-46) Commit thread, ReplicaFetcherThread for intra-cluster replication

2012-05-31 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-46: --- Attachment: kafka-46-v4.patch Attaching an updated patch that includes the rebase changes from KAFKA-34

[jira] [Created] (KAFKA-357) Refactor zookeeper code in KafkaZookeeper into reusable components

2012-05-31 Thread Neha Narkhede (JIRA)
Neha Narkhede created KAFKA-357: --- Summary: Refactor zookeeper code in KafkaZookeeper into reusable components Key: KAFKA-357 URL: https://issues.apache.org/jira/browse/KAFKA-357 Project: Kafka

[jira] [Updated] (KAFKA-46) Commit thread, ReplicaFetcherThread for intra-cluster replication

2012-05-31 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-46: --- Attachment: (was: kafka-46-v4.patch) > Commit thread, ReplicaFetcherThread for intra-cluster re

[jira] [Updated] (KAFKA-46) Commit thread, ReplicaFetcherThread for intra-cluster replication

2012-05-31 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-46: --- Attachment: kafka-46-v4.patch > Commit thread, ReplicaFetcherThread for intra-cluster replication >

[jira] [Commented] (KAFKA-46) Commit thread, ReplicaFetcherThread for intra-cluster replication

2012-05-31 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287087#comment-13287087 ] Jun Rao commented on KAFKA-46: -- +1 for patch v4. > Commit thread, ReplicaFetch

[jira] [Updated] (KAFKA-46) Commit thread, ReplicaFetcherThread for intra-cluster replication

2012-05-31 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-46: --- Attachment: kafka-46-v4.patch > Commit thread, ReplicaFetcherThread for intra-cluster replication >

[jira] [Updated] (KAFKA-46) Commit thread, ReplicaFetcherThread for intra-cluster replication

2012-05-31 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-46: --- Attachment: (was: kafka-46-v4.patch) > Commit thread, ReplicaFetcherThread for intra-cluster re

[jira] [Updated] (KAFKA-46) Commit thread, ReplicaFetcherThread for intra-cluster replication

2012-05-31 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-46: --- Attachment: (was: kafka-46-v4.patch) > Commit thread, ReplicaFetcherThread for intra-cluster re

[jira] [Updated] (KAFKA-46) Commit thread, ReplicaFetcherThread for intra-cluster replication

2012-05-31 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-46: --- Attachment: kafka-46-v4.patch > Commit thread, ReplicaFetcherThread for intra-cluster replication >

[jira] [Updated] (KAFKA-349) Create individual "Response" types for each kind of request and wrap them with "BoundedByteBufferSend", remove "xxResponseSend" types for all requests except "FetchRequest

2012-05-31 Thread Yang Ye (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Ye updated KAFKA-349: -- Attachment: kafka_responseSend.patch.7 I'm sorry but it's really hard to decouple the RPC patch from the "cleanu

[jira] [Created] (KAFKA-358) python producer causes "Unreasonable length = -69523947"

2012-05-31 Thread Jim Lim (JIRA)
Jim Lim created KAFKA-358: - Summary: python producer causes "Unreasonable length = -69523947" Key: KAFKA-358 URL: https://issues.apache.org/jira/browse/KAFKA-358 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-358) python producer causes "Unreasonable length = -69523947"

2012-05-31 Thread Jim Lim (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Lim updated KAFKA-358: -- Environment: Ubuntu 10.10 w. Python 2.6.6 (was: Ubuntu 10.10) > python producer causes "Unreasonable length

[jira] [Commented] (KAFKA-358) python producer causes "Unreasonable length = -69523947"

2012-05-31 Thread Jim Lim (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287119#comment-13287119 ] Jim Lim commented on KAFKA-358: --- Also happens with Ruby client. > python pro

Re: what is your workflow when developing?

2012-05-31 Thread Jun Rao
You can debug both client and server code in an IDE. Other times, enabling debug/trace level logging can be useful. Thanks, Jun On Thu, May 31, 2012 at 7:27 PM, S Ahmed wrote: > Curious on how you guys develop and debug locally with the kafka source? > > Do you run all the various services loc