[jira] [Commented] (KAFKA-335) Implement an embedded controller

2012-06-12 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293702#comment-13293702 ] Jun Rao commented on KAFKA-335: --- Thanks for patch v2. Some more comments: 21. ControllerChan

[jira] [Commented] (KAFKA-335) Implement an embedded controller

2012-06-12 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293728#comment-13293728 ] Jun Rao commented on KAFKA-335: --- For 4.3, could you create a separate jira to track this?

[jira] [Commented] (KAFKA-341) Create a new single host system test to validate all replicas on 0.8 branch

2012-06-12 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293745#comment-13293745 ] Jun Rao commented on KAFKA-341: --- Thanks for patch v2. I kept getting the following exception.

[jira] [Commented] (KAFKA-306) broker failure system test broken on replication branch

2012-06-12 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293752#comment-13293752 ] Jun Rao commented on KAFKA-306: --- Sorry, just got to review this. Trunk has moved, could you r

[jira] [Commented] (KAFKA-329) Remove the watches/broker for new topics and partitions and change create topic admin API to send start replica state change to all brokers

2012-06-12 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293764#comment-13293764 ] Jun Rao commented on KAFKA-329: --- Thanks for draft v2. Some quick comments: 21. KafkaZookeepe

Re: Consumer re-design proposal

2012-06-12 Thread Jay Kreps
This is a great summary Neha. It would be good to get people's feedback on this since we don't want to keep breaking api and protocol compatibility here, so the hope is to really get it right this time now that we have really seen all the use cases and live with the output for a while. I think the

[jira] [Updated] (KAFKA-341) Create a new single host system test to validate all replicas on 0.8 branch

2012-06-12 Thread John Fung (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Fung updated KAFKA-341: Attachment: kafka-341-v3.patch Uploaded kafka-341-v3.patch in which more comments are added to common/util.s

[jira] [Updated] (KAFKA-341) Create a new single host system test to validate all replicas on 0.8 branch

2012-06-12 Thread John Fung (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Fung updated KAFKA-341: Attachment: kafka-341-v4.patch Uploaded kafka-341-v4.patch to fix the followings: 1. reduced sleep time 2. f

[jira] [Commented] (KAFKA-341) Create a new single host system test to validate all replicas on 0.8 branch

2012-06-12 Thread John Fung (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293871#comment-13293871 ] John Fung commented on KAFKA-341: - Hi Jun, I just uploaded a patch "kafka-341-v4.patch" wh

[jira] [Commented] (KAFKA-341) Create a new single host system test to validate all replicas on 0.8 branch

2012-06-12 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293958#comment-13293958 ] Jun Rao commented on KAFKA-341: --- For sleep time, could we make it more adaptive? Basically, w

[jira] [Updated] (KAFKA-335) Implement an embedded controller

2012-06-12 Thread Yang Ye (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Ye updated KAFKA-335: -- Attachment: kafka_controller_v3.patch 21. ControllerChannelManager: 21.1 remove unused imports Done 21.2 allBr

[jira] [Updated] (KAFKA-329) Remove the watches/broker for new topics and partitions and change create topic admin API to send start replica state change to all brokers

2012-06-12 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon updated KAFKA-329: -- Attachment: KAFKA-329-v1.patch Hi Jun, New patch with your changes incorporated. I think it's

[jira] [Comment Edited] (KAFKA-329) Remove the watches/broker for new topics and partitions and change create topic admin API to send start replica state change to all brokers

2012-06-12 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294046#comment-13294046 ] Prashanth Menon edited comment on KAFKA-329 at 6/13/12 1:21 AM: -

hierarchical topics

2012-06-12 Thread Jay Kreps
One idea that has occasionally been thrown around is allowing topics to be hierarchical. The primary goal was just to allow logical grouping as well as to make it easier to subscribe via a wildcard (it may be easier to give /search/* rather than (search_click|search_result|...)). Another problem w

[jira] [Commented] (KAFKA-329) Remove the watches/broker for new topics and partitions and change create topic admin API to send start replica state change to all brokers

2012-06-12 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294103#comment-13294103 ] Jay Kreps commented on KAFKA-329: - I recommend we just use the json library scala includes.