[
https://issues.apache.org/jira/browse/KAFKA-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418065#comment-13418065
]
Jay Kreps commented on KAFKA-350:
-
This is a pretty hard to review due to the large number
[
https://issues.apache.org/jira/browse/KAFKA-398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418057#comment-13418057
]
Guozhang Wang commented on KAFKA-398:
-
Oh I see. Yeah, I totally agree with you.
[
https://issues.apache.org/jira/browse/KAFKA-398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418049#comment-13418049
]
Jay Kreps commented on KAFKA-398:
-
I meant this:
+// Here we have to hack the socket s
[
https://issues.apache.org/jira/browse/KAFKA-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418050#comment-13418050
]
Jay Kreps commented on KAFKA-352:
-
+1
> Throw exception to client if it ma
[
https://issues.apache.org/jira/browse/KAFKA-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-352:
Attachment: kafka-352-v2.patch
Thanks for the review, Jay ! Uploading another patch with the review
[
https://issues.apache.org/jira/browse/KAFKA-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417934#comment-13417934
]
Joe Stein commented on KAFKA-377:
-
nope, i found a few mirrors still bad will re-open the t
[
https://issues.apache.org/jira/browse/KAFKA-398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417924#comment-13417924
]
Guozhang Wang commented on KAFKA-398:
-
Hi Jay, thanks for the comments. One thing I do
[
https://issues.apache.org/jira/browse/KAFKA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417913#comment-13417913
]
Jay Kreps commented on KAFKA-405:
-
Some of these comments are not directly related to this
[
https://issues.apache.org/jira/browse/KAFKA-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417886#comment-13417886
]
Jay Kreps commented on KAFKA-352:
-
+1
A few minor things:
1. Remove the println in KafkaAp
[
https://issues.apache.org/jira/browse/KAFKA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417864#comment-13417864
]
Jay Kreps commented on KAFKA-376:
-
Hey Prashanth, how goes it? Let me know if you don't hav
[
https://issues.apache.org/jira/browse/KAFKA-398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417832#comment-13417832
]
Jay Kreps commented on KAFKA-398:
-
Hey Guozhang, I think we can't take these socket server
I can confirm, it has bitten me few days ago, had it been documented I
wouldn't need to spend an hour looking into the scala code which serializes
the gzipped message only to find out theres another message inside when
writing a php client.
I also think it does actually complicate the matter becau
Cool, then I guess we can go case by case on double-checkins to trunk and
0.8.
-Jay
On Wed, Jul 18, 2012 at 1:13 PM, Neha Narkhede wrote:
> I think it might be useful for the community to have a couple more releases
> for 0.7.*, at least until 0.8 is fully stable.
>
> Thanks,
> Neha
>
> On Wed,
[
https://issues.apache.org/jira/browse/KAFKA-371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-371:
Attachment: KAFKA-371-0.8-v2.patch
Neha can you sanity check this? Here are the changes:
- Remove some unne
[
https://issues.apache.org/jira/browse/KAFKA-371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps reopened KAFKA-371:
-
Assignee: Jay Kreps
Reopening for cleanups of LogManager
> Creating topic of empty stri
[
https://issues.apache.org/jira/browse/KAFKA-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417656#comment-13417656
]
Neha Narkhede commented on KAFKA-371:
-
Yes, that will work too. I guess the API was add
[
https://issues.apache.org/jira/browse/KAFKA-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417647#comment-13417647
]
Jay Kreps commented on KAFKA-371:
-
Hmm, good point. This is a little odd, though, no? Why w
[
https://issues.apache.org/jira/browse/KAFKA-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417643#comment-13417643
]
Chris Burroughs commented on KAFKA-203:
---
I also have metrics all over the place in pr
[
https://issues.apache.org/jira/browse/KAFKA-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-352:
Attachment: kafka-352-v1.patch
1. Improved error handling for produce, fetch, get offsets request to
[
https://issues.apache.org/jira/browse/KAFKA-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-352:
Status: Patch Available (was: In Progress)
> Throw exception to client if it makes a produce/co
I think it might be useful for the community to have a couple more releases
for 0.7.*, at least until 0.8 is fully stable.
Thanks,
Neha
On Wed, Jul 18, 2012 at 1:03 PM, Chris Burroughs
wrote:
> I added a 0.7.2 release in JIRA for you (Joe, do you have the bits
> flipped to be able to do this?)
>
I added a 0.7.2 release in JIRA for you (Joe, do you have the bits
flipped to be able to do this?)
On 07/18/2012 02:05 PM, Joe Stein wrote:
> I was thinking we would have a 0.7.2 release if there are patches in trunk
> that folks want to use, why not release them and make it available for
> them?
[
https://issues.apache.org/jira/browse/KAFKA-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417625#comment-13417625
]
Chris Burroughs commented on KAFKA-377:
---
INFRA-4975 is closed now, we good here?
[
https://issues.apache.org/jira/browse/KAFKA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417407#comment-13417407
]
Jonathan Creasy edited comment on KAFKA-188 at 7/18/12 7:48 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417407#comment-13417407
]
Jonathan Creasy commented on KAFKA-188:
---
I started the implementation and my code loo
[
https://issues.apache.org/jira/browse/KAFKA-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417383#comment-13417383
]
Jonathan Creasy commented on KAFKA-371:
---
Well, I didn't see any way for the bug to ha
Lorenzo Alberton created KAFKA-407:
--
Summary: Uncaught InputStream.close() exception in
CompressionUtils.compress()
Key: KAFKA-407
URL: https://issues.apache.org/jira/browse/KAFKA-407
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417374#comment-13417374
]
derek commented on KAFKA-139:
-
Can you remove your project/plugins/ dir and see if that does it
[
https://issues.apache.org/jira/browse/KAFKA-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede reassigned KAFKA-352:
---
Assignee: Neha Narkhede
> Throw exception to client if it makes a produce/consume request
[
https://issues.apache.org/jira/browse/KAFKA-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on KAFKA-352 started by Neha Narkhede.
> Throw exception to client if it makes a produce/consume request to a Kafka
> broker for a topic that hasn't been created
> -
[
https://issues.apache.org/jira/browse/KAFKA-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417367#comment-13417367
]
Lorenzo Alberton commented on KAFKA-406:
I see. It needs to be documented somewhere
[
https://issues.apache.org/jira/browse/KAFKA-354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Stein updated KAFKA-354:
Description:
We just agreed on a new convention for getter/setter APIs. It will be good to
refactor code to
[
https://issues.apache.org/jira/browse/KAFKA-354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Stein reassigned KAFKA-354:
---
Assignee: Joe Stein
> Refactor getter and setter API to conform to the new convention
> --
[
https://issues.apache.org/jira/browse/KAFKA-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417326#comment-13417326
]
Joe Stein commented on KAFKA-181:
-
+1
> Log errors for unrecognized config
I was thinking we would have a 0.7.2 release if there are patches in trunk
that folks want to use, why not release them and make it available for
them? I don't mind doing releases ... double commits make this manageable
0.7.X off trunk, yup
On Wed, Jul 18, 2012 at 1:27 PM, Joel Koshy wrote:
>
[
https://issues.apache.org/jira/browse/KAFKA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417322#comment-13417322
]
Jay Kreps commented on KAFKA-188:
-
Here are a few additional thoughts on this:
1. This is a
cool
I use metrics in production for a lot of our software it is great and think
it would be great to have in Kafka, yup
i am +1 on 203 using metrics
Joel, since you are using metrics in KAFKA-385 once that patch is available
we can use KAFKA-203 and go through the rest of the code for having it
[
https://issues.apache.org/jira/browse/KAFKA-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417304#comment-13417304
]
Neha Narkhede commented on KAFKA-406:
-
Yes, this was intentional. The idea was to repre
[
https://issues.apache.org/jira/browse/KAFKA-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417299#comment-13417299
]
Neha Narkhede commented on KAFKA-311:
-
Thanks for the patch ! Would it make sense to de
[
https://issues.apache.org/jira/browse/KAFKA-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417296#comment-13417296
]
Neha Narkhede commented on KAFKA-181:
-
+1, these are good ideas
> Log
[
https://issues.apache.org/jira/browse/KAFKA-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lorenzo Alberton updated KAFKA-406:
---
Summary: Gzipped payload is a fully wrapped Message (with headers), not
just payload (was: Gz
Lorenzo Alberton created KAFKA-406:
--
Summary: Gzipped payload is a full wrapped Message (with headers),
not just payload
Key: KAFKA-406
URL: https://issues.apache.org/jira/browse/KAFKA-406
Project: K
In 0.8, we support producing to a random partition if the key for produce
request is null. In this case, the producer picks a random partition to
send the messages to.
I agree that this functionality should not be in the log manager (it isn't
in 0.8 AFAICT). What do you want to delete from log man
[
https://issues.apache.org/jira/browse/KAFKA-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417295#comment-13417295
]
Jay Kreps commented on KAFKA-181:
-
Here are a few other facilities it would be nice to have
[
https://issues.apache.org/jira/browse/KAFKA-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417288#comment-13417288
]
Neha Narkhede commented on KAFKA-371:
-
I think in the 0.8 patch, the changes to createL
[
https://issues.apache.org/jira/browse/KAFKA-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417281#comment-13417281
]
Jay Kreps commented on KAFKA-184:
-
Thanks! I am going to hold off on this. As you mention,
0.7.1 patch == patch to apply on branch 0.7.1 or trunk? I thought we would
be doing double-commits on trunk and 0.8 and not worry about release
branches for now. Also, 0.7.2 would be cut off trunk. (Both 0.7.1 and 0.7
were cut off trunk.)
Joel
On Wed, Jul 18, 2012 at 10:19 AM, Jay Kreps wrote:
[
https://issues.apache.org/jira/browse/KAFKA-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417270#comment-13417270
]
Neha Narkhede commented on KAFKA-139:
-
I checked out 0.8 code, applied v3 patch, downlo
[
https://issues.apache.org/jira/browse/KAFKA-371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-371:
Resolution: Fixed
Fix Version/s: (was: 0.7)
0.8
Status: Resolved (w
People tend to produce patches against the 0.7.1. Currently I think we are
urging double commits on trunk and 0.8 because the large code difference
makes auto merges too dangerous. However I don't think we are likely to do
a 0.7.2 release (0.8 is not too far out at this point). So I think we
should
Hey guys,
We seem to have dropped the functionality to produce to a random partition
by setting partition to -1 in 0.8. Presumably this is because we can no
longer just choose a partition randomly, but need to pick a partition for
which the given broker is a leader.
Questions/Comments
1. Not sure
Not directly related to KAFKA-203, but I started trying out metrics for
KAFKA-385. Looks promising - we can see how it plays out.
Joel
On Tue, Jul 17, 2012 at 7:49 PM, Jonathan Creasy wrote:
> What's the current status of this?
>
> KAFKA-203 (https://issues.apache.org/jira/browse/KAFKA-203)
>
>
[
https://issues.apache.org/jira/browse/KAFKA-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417268#comment-13417268
]
Jay Kreps commented on KAFKA-371:
-
Committed the 0.8 patch. Thanks.
At the moment I don't
53 matches
Mail list logo