[jira] [Commented] (KAFKA-3) Consumer needs a pluggable decoder

[ https://issues.apache.org/jira/browse/KAFKA-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115608#comment-13115608 ] Jun Rao commented on KAFKA-3: - I vote for the second approach. The API is simpler and is consiste

[jira] [Commented] (KAFKA-3) Consumer needs a pluggable decoder

[ https://issues.apache.org/jira/browse/KAFKA-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115989#comment-13115989 ] Jun Rao commented on KAFKA-3: - Overall, the patch looks good. Some minor comments: 1. Does Zooke

[jira] [Commented] (KAFKA-140) Expose total metrics through MBeans as well

[ https://issues.apache.org/jira/browse/KAFKA-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117377#comment-13117377 ] Jun Rao commented on KAFKA-140: --- Pierre-Yves, thanks for creating the jira and submitting the

[jira] [Commented] (KAFKA-130) Provide a default producer for receiving messages from STDIN

[ https://issues.apache.org/jira/browse/KAFKA-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119028#comment-13119028 ] Jun Rao commented on KAFKA-130: --- Ok, that makes sense. Just document the format in the descri

[jira] [Commented] (KAFKA-136) A JMX bean that reports #message/sec in consumer

[ https://issues.apache.org/jira/browse/KAFKA-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119077#comment-13119077 ] Jun Rao commented on KAFKA-136: --- SimpleConsumer is a bit different. We only know that the use

[jira] [Commented] (KAFKA-141) Check and make sure that the files that have been donated have been updated to reflect the new ASF copyright

[ https://issues.apache.org/jira/browse/KAFKA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119079#comment-13119079 ] Jun Rao commented on KAFKA-141: --- For ASF copyright, I guess we only care about java/scala sou

[jira] [Commented] (KAFKA-125) tooBigRequestIsRejected fails with unexpected Exceptoin

[ https://issues.apache.org/jira/browse/KAFKA-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119137#comment-13119137 ] Jun Rao commented on KAFKA-125: --- +1 for the patch. > tooBigRequestIsRejected

[jira] [Commented] (KAFKA-130) Provide a default producer for receiving messages from STDIN

[ https://issues.apache.org/jira/browse/KAFKA-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119139#comment-13119139 ] Jun Rao commented on KAFKA-130: --- +1 > Provide a default producer for receivi

[jira] [Commented] (KAFKA-92) upgrade to latest stable 0.7.x sbt

[ https://issues.apache.org/jira/browse/KAFKA-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119405#comment-13119405 ] Jun Rao commented on KAFKA-92: -- Chris, do you want to get this committed for 0.7 release? If so

[jira] [Commented] (KAFKA-78) add optional mx4j support to expose jmx over http

[ https://issues.apache.org/jira/browse/KAFKA-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119408#comment-13119408 ] Jun Rao commented on KAFKA-78: -- It doesn't looks like that we have a patch that addresses all t

[jira] [Commented] (KAFKA-79) Introduce the compression feature in Kafka

[ https://issues.apache.org/jira/browse/KAFKA-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119898#comment-13119898 ] Jun Rao commented on KAFKA-79: -- Chris, which ids are you referring to? > Intro

[jira] [Commented] (KAFKA-129) ZK-based producer can throw an unexpceted exception when sending a message

[ https://issues.apache.org/jira/browse/KAFKA-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120307#comment-13120307 ] Jun Rao commented on KAFKA-129: --- 1. import collection.SortedSet is not used in Producer. 2.

[jira] [Commented] (KAFKA-78) add optional mx4j support to expose jmx over http

[ https://issues.apache.org/jira/browse/KAFKA-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120318#comment-13120318 ] Jun Rao commented on KAFKA-78: -- Chris, thanks for the patch. Do you think that we can change mx

[jira] [Commented] (KAFKA-129) ZK-based producer can throw an unexpceted exception when sending a message

[ https://issues.apache.org/jira/browse/KAFKA-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120371#comment-13120371 ] Jun Rao commented on KAFKA-129: --- OK, for item 3, could you change the comment accordingly?

[jira] [Commented] (KAFKA-129) ZK-based producer can throw an unexpceted exception when sending a message

[ https://issues.apache.org/jira/browse/KAFKA-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120513#comment-13120513 ] Jun Rao commented on KAFKA-129: --- +1. Thanks for the patch. > ZK-based produc

[jira] [Commented] (KAFKA-78) add optional mx4j support to expose jmx over http

[ https://issues.apache.org/jira/browse/KAFKA-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120625#comment-13120625 ] Jun Rao commented on KAFKA-78: -- +1. Thanks for the patch, Chris. > add optiona

[jira] [Commented] (KAFKA-146) testUnreachableServer sporadically fails

[ https://issues.apache.org/jira/browse/KAFKA-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120632#comment-13120632 ] Jun Rao commented on KAFKA-146: --- It seems that the problem is caused by this assertion: Asse

[jira] [Commented] (KAFKA-146) testUnreachableServer sporadically fails

[ https://issues.apache.org/jira/browse/KAFKA-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120646#comment-13120646 ] Jun Rao commented on KAFKA-146: --- +1 > testUnreachableServer sporadically fai

[jira] [Commented] (KAFKA-15) SBT release-zip target doesn't include bin and config directories anymore

[ https://issues.apache.org/jira/browse/KAFKA-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121176#comment-13121176 ] Jun Rao commented on KAFKA-15: -- We have someone in our team who can help address this issue as

[jira] [Commented] (KAFKA-145) Kafka server mirror shutdown bug

[ https://issues.apache.org/jira/browse/KAFKA-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121537#comment-13121537 ] Jun Rao commented on KAFKA-145: --- In MirroringThread.run, it's probably better to do the count

[jira] [Commented] (KAFKA-145) Kafka server mirror shutdown bug

[ https://issues.apache.org/jira/browse/KAFKA-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121558#comment-13121558 ] Jun Rao commented on KAFKA-145: --- +1 on the new patch. > Kafka server mirror

[jira] [Commented] (KAFKA-147) kafka integration tests fail on a fresh checkout

[ https://issues.apache.org/jira/browse/KAFKA-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121665#comment-13121665 ] Jun Rao commented on KAFKA-147: --- +1. We can upgrade to sbt 10.0 later. > kaf

[jira] [Commented] (KAFKA-149) Current perf directory has buggy perf tests

[ https://issues.apache.org/jira/browse/KAFKA-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122166#comment-13122166 ] Jun Rao commented on KAFKA-149: --- +1 > Current perf directory has buggy perf

[jira] [Commented] (KAFKA-141) Check and make sure that the files that have been donated have been updated to reflect the new ASF copyright

[ https://issues.apache.org/jira/browse/KAFKA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122168#comment-13122168 ] Jun Rao commented on KAFKA-141: --- +1 on the patch that fixes the tests. > Che

[jira] [Commented] (KAFKA-142) Check and make sure that for all code included with the distribution that is not under the Apache license, we have the right to combine with Apache-licensed code and red

[ https://issues.apache.org/jira/browse/KAFKA-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122494#comment-13122494 ] Jun Rao commented on KAFKA-142: --- Alan, Is this ticket for all the external jars that we used

[jira] [Commented] (KAFKA-143) Check and make sure that all source code distributed by the project is covered by one or more approved licenses

[ https://issues.apache.org/jira/browse/KAFKA-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13123856#comment-13123856 ] Jun Rao commented on KAFKA-143: --- +1 on the patch. > Check and make sure that

[jira] [Commented] (KAFKA-154) ZK consumer may lose a chunk worth of message during rebalance in some rare cases

[ https://issues.apache.org/jira/browse/KAFKA-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125220#comment-13125220 ] Jun Rao commented on KAFKA-154: --- This problem is caused by a very subtle bug. When a fetcher

[jira] [Commented] (KAFKA-141) Check and make sure that the files that have been donated have been updated to reflect the new ASF copyright

[ https://issues.apache.org/jira/browse/KAFKA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125514#comment-13125514 ] Jun Rao commented on KAFKA-141: --- +1 on KAFKA-141-cpp.patch > Check and make

[jira] [Commented] (KAFKA-143) Check and make sure that all source code distributed by the project is covered by one or more approved licenses

[ https://issues.apache.org/jira/browse/KAFKA-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126824#comment-13126824 ] Jun Rao commented on KAFKA-143: --- +1 with the new patch. > Check and make sur

[jira] [Commented] (KAFKA-151) Standard .rat-excludes file

[ https://issues.apache.org/jira/browse/KAFKA-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126861#comment-13126861 ] Jun Rao commented on KAFKA-151: --- +1 > Standard .rat-excludes file >

[jira] [Commented] (KAFKA-156) Messages should not be dropped when brokers are unavailable

[ https://issues.apache.org/jira/browse/KAFKA-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129031#comment-13129031 ] Jun Rao commented on KAFKA-156: --- If we spool, when the broker comes back, should we deliver t

[jira] [Commented] (KAFKA-50) kafka intra-cluster replication support

[ https://issues.apache.org/jira/browse/KAFKA-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129803#comment-13129803 ] Jun Rao commented on KAFKA-50: -- Sharad, Good question. HDFS is a great system and is the very

[jira] [Commented] (KAFKA-50) kafka intra-cluster replication support

[ https://issues.apache.org/jira/browse/KAFKA-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129839#comment-13129839 ] Jun Rao commented on KAFKA-50: -- We do plan to offer both async replication and sync replication

[jira] [Commented] (KAFKA-160) ZK consumer gets into infinite loop if a message is larger than fetch size

[ https://issues.apache.org/jira/browse/KAFKA-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130051#comment-13130051 ] Jun Rao commented on KAFKA-160: --- I think this was introduced when compression was added. I re

[jira] [Commented] (KAFKA-163) Ruby client needs to support new compression byte

[ https://issues.apache.org/jira/browse/KAFKA-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130723#comment-13130723 ] Jun Rao commented on KAFKA-163: --- This seems to be a patch for 158, not 163.

[jira] [Commented] (KAFKA-158) go consumer & producer to support compression

[ https://issues.apache.org/jira/browse/KAFKA-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131728#comment-13131728 ] Jun Rao commented on KAFKA-158: --- It seems that you are sending a message marked as compressed

[jira] [Commented] (KAFKA-165) Add helper script for zkCli.sh

[ https://issues.apache.org/jira/browse/KAFKA-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131737#comment-13131737 ] Jun Rao commented on KAFKA-165: --- +1 > Add helper script for zkCli.sh > -

[jira] [Commented] (KAFKA-164) Config should default to a higher-throughput configuration for log.flush.interval

[ https://issues.apache.org/jira/browse/KAFKA-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131743#comment-13131743 ] Jun Rao commented on KAFKA-164: --- Maybe shrink flush time to 500ms? > Config

[jira] [Commented] (KAFKA-158) go consumer & producer to support compression

[ https://issues.apache.org/jira/browse/KAFKA-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131881#comment-13131881 ] Jun Rao commented on KAFKA-158: --- The go producer and the scala producer should send the same

[jira] [Commented] (KAFKA-161) Producer using broker list does not load balance requests across multiple partitions on a broker

[ https://issues.apache.org/jira/browse/KAFKA-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131900#comment-13131900 ] Jun Rao commented on KAFKA-161: --- 1. We should guard logger.debug with the isDebugEnabled chec

[jira] [Commented] (KAFKA-158) go consumer & producer to support compression

[ https://issues.apache.org/jira/browse/KAFKA-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131909#comment-13131909 ] Jun Rao commented on KAFKA-158: --- In the broker, we need to unzip compressed messages to verif

[jira] [Commented] (KAFKA-161) Producer using broker list does not load balance requests across multiple partitions on a broker

[ https://issues.apache.org/jira/browse/KAFKA-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132219#comment-13132219 ] Jun Rao commented on KAFKA-161: --- +1 on the new patch. > Producer using broke

[jira] [Commented] (KAFKA-158) go consumer & producer to support compression

[ https://issues.apache.org/jira/browse/KAFKA-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132754#comment-13132754 ] Jun Rao commented on KAFKA-158: --- That's right. We take one or more uncompressed messages and

[jira] [Commented] (KAFKA-158) go consumer & producer to support compression

[ https://issues.apache.org/jira/browse/KAFKA-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132778#comment-13132778 ] Jun Rao commented on KAFKA-158: --- There is a compression flag on ByteBufferMessageSet, with th

[jira] [Commented] (KAFKA-150) Confusing NodeExistsException failing kafka broker startup

[ https://issues.apache.org/jira/browse/KAFKA-150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133824#comment-13133824 ] Jun Rao commented on KAFKA-150: --- In KafkaZooKeeper.registerBrokerInZk, in the case statement,

[jira] [Commented] (KAFKA-164) Config should default to a higher-throughput configuration for log.flush.interval

[ https://issues.apache.org/jira/browse/KAFKA-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133826#comment-13133826 ] Jun Rao commented on KAFKA-164: --- +1 on changes in server.properties > Config

[jira] [Commented] (KAFKA-166) Create a tool to jump JMX data to a csv file to help build out performance tests

[ https://issues.apache.org/jira/browse/KAFKA-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133828#comment-13133828 ] Jun Rao commented on KAFKA-166: --- 1. If object-name is not specified, should we include all jm

[jira] [Commented] (KAFKA-150) Confusing NodeExistsException failing kafka broker startup

[ https://issues.apache.org/jira/browse/KAFKA-150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133833#comment-13133833 ] Jun Rao commented on KAFKA-150: --- +1 on the patch. I thought the try/catch thing in scala is

[jira] [Commented] (KAFKA-170) Support for non-blocking polling on multiple streams

[ https://issues.apache.org/jira/browse/KAFKA-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136013#comment-13136013 ] Jun Rao commented on KAFKA-170: --- 1. KafkaMessageStream currently does have a timeout controll

[jira] [Commented] (KAFKA-172) The existing perf tools are buggy

[ https://issues.apache.org/jira/browse/KAFKA-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136187#comment-13136187 ] Jun Rao commented on KAFKA-172: --- What bugs are you seeing? > The existing pe

[jira] [Commented] (KAFKA-176) Fix existing perf tools

[ https://issues.apache.org/jira/browse/KAFKA-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136761#comment-13136761 ] Jun Rao commented on KAFKA-176: --- ProducerPerformance: 1. The following code seems to be used

[jira] [Commented] (KAFKA-168) Support locality in consumer partition assignment algorithm

[ https://issues.apache.org/jira/browse/KAFKA-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138574#comment-13138574 ] Jun Rao commented on KAFKA-168: --- It's possible to specify the consumer id in ConsumerConfig.

[jira] [Commented] (KAFKA-176) Fix existing perf tools

[ https://issues.apache.org/jira/browse/KAFKA-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139844#comment-13139844 ] Jun Rao commented on KAFKA-176: --- 1. It can be in the code. Maybe we just need a command line

[jira] [Commented] (KAFKA-170) Support for non-blocking polling on multiple streams

[ https://issues.apache.org/jira/browse/KAFKA-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140331#comment-13140331 ] Jun Rao commented on KAFKA-170: --- Taylor, I see. Yes, if you use the low-level API, you can

[jira] [Commented] (KAFKA-175) Add helper scripts to wrap the current perf tools

[ https://issues.apache.org/jira/browse/KAFKA-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140368#comment-13140368 ] Jun Rao commented on KAFKA-175: --- A few comments: 1. Testing on batch size is a bit confusing

[jira] [Commented] (KAFKA-180) Clean up shell scripts

[ https://issues.apache.org/jira/browse/KAFKA-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141257#comment-13141257 ] Jun Rao commented on KAFKA-180: --- SimpleConsumeShell is still useful for debugging purpose. I'

[jira] [Commented] (KAFKA-171) Kafka producer should do a single write to send message sets

[ https://issues.apache.org/jira/browse/KAFKA-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141272#comment-13141272 ] Jun Rao commented on KAFKA-171: --- MessageSet has a couple of unused imports. Other than that,

[jira] [Commented] (KAFKA-186) no clean way to getCompressionCodec from Java-the-language

[ https://issues.apache.org/jira/browse/KAFKA-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144196#comment-13144196 ] Jun Rao commented on KAFKA-186: --- We could just use kafka.message.NoCompression(). It's a stat

[jira] [Commented] (KAFKA-186) no clean way to getCompressionCodec from Java-the-language

[ https://issues.apache.org/jira/browse/KAFKA-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144200#comment-13144200 ] Jun Rao commented on KAFKA-186: --- Actually, we should use kafka.message.NoCompressionCodec.cod

[jira] [Commented] (KAFKA-186) no clean way to getCompressionCodec from Java-the-language

[ https://issues.apache.org/jira/browse/KAFKA-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144521#comment-13144521 ] Jun Rao commented on KAFKA-186: --- You only need do deal with the codec directly if you use Syn

[jira] [Commented] (KAFKA-191) Investigate removing the synchronization in Log.flush

[ https://issues.apache.org/jira/browse/KAFKA-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145234#comment-13145234 ] Jun Rao commented on KAFKA-191: --- So, I guess If append and fsync can't run in parallel, the p

[jira] [Commented] (KAFKA-196) Topic creation fails on large values

[ https://issues.apache.org/jira/browse/KAFKA-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145583#comment-13145583 ] Jun Rao commented on KAFKA-196: --- Thanks for the patch. Where is the limit 200 coming from? Is

[jira] [Commented] (KAFKA-196) Topic creation fails on large values

[ https://issues.apache.org/jira/browse/KAFKA-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145593#comment-13145593 ] Jun Rao commented on KAFKA-196: --- Do you think we can make it configurable and default it to 2

[jira] [Commented] (KAFKA-196) Topic creation fails on large values

[ https://issues.apache.org/jira/browse/KAFKA-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145605#comment-13145605 ] Jun Rao commented on KAFKA-196: --- Yes, a new server property should work. > T

[jira] [Commented] (KAFKA-196) Topic creation fails on large values

[ https://issues.apache.org/jira/browse/KAFKA-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145611#comment-13145611 ] Jun Rao commented on KAFKA-196: --- Yes, we can use verifyTopicName to capture all constraints o

[jira] [Commented] (KAFKA-196) Topic creation fails on large values

[ https://issues.apache.org/jira/browse/KAFKA-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145626#comment-13145626 ] Jun Rao commented on KAFKA-196: --- Not sure why the server would hang when it couldn't create a

[jira] [Commented] (KAFKA-187) Add Snappy Compression as a Codec and refactor CompressionUtil and option on startup to select what the default codec

[ https://issues.apache.org/jira/browse/KAFKA-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145659#comment-13145659 ] Jun Rao commented on KAFKA-187: --- It would be good if the snappy jar is only a compile time de

[jira] [Commented] (KAFKA-195) change ProducerShell to use high level producer

[ https://issues.apache.org/jira/browse/KAFKA-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145949#comment-13145949 ] Jun Rao commented on KAFKA-195: --- The main reason is that we don't have an example producer pr

[jira] [Commented] (KAFKA-187) Add Snappy Compression as a Codec and refactor CompressionUtil and option on startup to select what the default codec

[ https://issues.apache.org/jira/browse/KAFKA-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145987#comment-13145987 ] Jun Rao commented on KAFKA-187: --- Thanks, Joe. That's what I was looking for.

[jira] [Commented] (KAFKA-198) Avoid duplicated message during consumer rebalance

[ https://issues.apache.org/jira/browse/KAFKA-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147848#comment-13147848 ] Jun Rao commented on KAFKA-198: --- This is a bit tricky to get right. The following is one poss

[jira] [Commented] (KAFKA-187) Add Snappy Compression as a Codec and refactor CompressionUtil and option on startup to select what the default codec

[ https://issues.apache.org/jira/browse/KAFKA-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147866#comment-13147866 ] Jun Rao commented on KAFKA-187: --- This is not a problem for java/scala clients. But it could b

[jira] [Commented] (KAFKA-199) Add a how-to-mirror document

[ https://issues.apache.org/jira/browse/KAFKA-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148238#comment-13148238 ] Jun Rao commented on KAFKA-199: --- Thanks, Joel. A couple of quick comments: 1. I feel that it

[jira] [Commented] (KAFKA-175) Add helper scripts to wrap the current perf tools

[ https://issues.apache.org/jira/browse/KAFKA-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148646#comment-13148646 ] Jun Rao commented on KAFKA-175: --- Previous comments 1 and 3 are not addressed. 4. consumer-th

[jira] [Commented] (KAFKA-48) Implement optional "long poll" support in fetch request

[ https://issues.apache.org/jira/browse/KAFKA-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148835#comment-13148835 ] Jun Rao commented on KAFKA-48: -- Just had a chance to look at the patch. Agree in principle this

[jira] [Commented] (KAFKA-47) Create topic support and new ZK data structures for intra-cluster replication

[ https://issues.apache.org/jira/browse/KAFKA-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149399#comment-13149399 ] Jun Rao commented on KAFKA-47: -- Some thoughts on the create/delete topic support. 1. What if t

[jira] [Commented] (KAFKA-50) kafka intra-cluster replication support

[ https://issues.apache.org/jira/browse/KAFKA-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149400#comment-13149400 ] Jun Rao commented on KAFKA-50: -- The dependencies of the sub-jiras look like the following: 48

[jira] [Commented] (KAFKA-101) Avoid creating a new topic by the consumer

[ https://issues.apache.org/jira/browse/KAFKA-101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149414#comment-13149414 ] Jun Rao commented on KAFKA-101: --- Thanks for the patch. The test failures seem to be transien

[jira] [Commented] (KAFKA-201) Support for mirroring from multiple sources

[ https://issues.apache.org/jira/browse/KAFKA-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149423#comment-13149423 ] Jun Rao commented on KAFKA-201: --- This should be relatively easy. can just extend KafkaServer

[jira] [Commented] (KAFKA-101) Avoid creating a new topic by the consumer

[ https://issues.apache.org/jira/browse/KAFKA-101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149426#comment-13149426 ] Jun Rao commented on KAFKA-101: --- Yes, since a test in SimpleConsumer will further test the wi

[jira] [Commented] (KAFKA-101) Avoid creating a new topic by the consumer

[ https://issues.apache.org/jira/browse/KAFKA-101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149442#comment-13149442 ] Jun Rao commented on KAFKA-101: --- We can add it in PrimitiveApiTest. > Avoid

[jira] [Commented] (KAFKA-47) Create topic support and new ZK data structures for intra-cluster replication

[ https://issues.apache.org/jira/browse/KAFKA-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149775#comment-13149775 ] Jun Rao commented on KAFKA-47: -- 1,2. It seems to me it's simpler to have all brokers read from

[jira] [Commented] (KAFKA-187) Add Snappy Compression as a Codec and refactor CompressionUtil and option on startup to select what the default codec

[ https://issues.apache.org/jira/browse/KAFKA-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150105#comment-13150105 ] Jun Rao commented on KAFKA-187: --- The following are the changes that I made. Index: core/src

[jira] [Commented] (KAFKA-101) Avoid creating a new topic by the consumer

[ https://issues.apache.org/jira/browse/KAFKA-101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150246#comment-13150246 ] Jun Rao commented on KAFKA-101: --- Actually another thing. If a topic doesn't already exist, th

[jira] [Commented] (KAFKA-204) BoundedByteBufferReceive hides OutOfMemoryError

[ https://issues.apache.org/jira/browse/KAFKA-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151297#comment-13151297 ] Jun Rao commented on KAFKA-204: --- The main reason this was added is to show the requested size

[jira] [Commented] (KAFKA-204) BoundedByteBufferReceive hides OutOfMemoryError

[ https://issues.apache.org/jira/browse/KAFKA-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151300#comment-13151300 ] Jun Rao commented on KAFKA-204: --- Another possibility is to rethrow a new RuntimeException wit

[jira] [Commented] (KAFKA-206) no DISCLAIMER, NOTICE needs cleanup

[ https://issues.apache.org/jira/browse/KAFKA-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152493#comment-13152493 ] Jun Rao commented on KAFKA-206: --- +1 > no DISCLAIMER, NOTICE needs cleanup >

[jira] [Commented] (KAFKA-101) Avoid creating a new topic by the consumer

[ https://issues.apache.org/jira/browse/KAFKA-101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153917#comment-13153917 ] Jun Rao commented on KAFKA-101: --- Taylor, could you review patch v2? Thanks,

[jira] [Commented] (KAFKA-209) Remove empty directory when no log segments remain

[ https://issues.apache.org/jira/browse/KAFKA-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153918#comment-13153918 ] Jun Rao commented on KAFKA-209: --- Actually, when all log segments are deleted, we automaticall

[jira] [Commented] (KAFKA-204) BoundedByteBufferReceive hides OutOfMemoryError

[ https://issues.apache.org/jira/browse/KAFKA-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153919#comment-13153919 ] Jun Rao commented on KAFKA-204: --- Hmm, it doesn't look like OutOfMemoryError allow one to spec

[jira] [Commented] (KAFKA-209) Remove empty directory when no log segments remain

[ https://issues.apache.org/jira/browse/KAFKA-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153987#comment-13153987 ] Jun Rao commented on KAFKA-209: --- It should behave that way in both 0.6 and 0.7. If not, it's

[jira] [Commented] (KAFKA-211) Fix LICENSE file to include MIT and SCALA license

[ https://issues.apache.org/jira/browse/KAFKA-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154690#comment-13154690 ] Jun Rao commented on KAFKA-211: --- +1 > Fix LICENSE file to include MIT and SC

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155240#comment-13155240 ] Jun Rao commented on KAFKA-49: -- Prshanth, thanks for getting started on this. I agree with your

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155307#comment-13155307 ] Jun Rao commented on KAFKA-49: -- Both 2 and 3 make sense. If we do this in a bug fix release i

[jira] [Commented] (KAFKA-193) use by name parameter helper for logging and trait to include lazy logging and refactor code to use the new LogHelper

[ https://issues.apache.org/jira/browse/KAFKA-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155691#comment-13155691 ] Jun Rao commented on KAFKA-193: --- +1 on the latest patch. > use by name param

[jira] [Commented] (KAFKA-210) javaapi ZookeeperConsumerConnectorTest duplicates many tests in the scala version

[ https://issues.apache.org/jira/browse/KAFKA-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155956#comment-13155956 ] Jun Rao commented on KAFKA-210: --- Yes, I am saying that there is no need to stress test the ja

[jira] [Commented] (KAFKA-204) BoundedByteBufferReceive hides OutOfMemoryError

[ https://issues.apache.org/jira/browse/KAFKA-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156061#comment-13156061 ] Jun Rao commented on KAFKA-204: --- Ok, I am fine with the patch then. Any objection to commit i

[jira] [Commented] (KAFKA-101) Avoid creating a new topic by the consumer

[ https://issues.apache.org/jira/browse/KAFKA-101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156377#comment-13156377 ] Jun Rao commented on KAFKA-101: --- Taylor, this would suggest a synchronization issue during ap

[jira] [Commented] (KAFKA-212) IllegalThreadStateException in topic watcher for Kafka mirroring

[ https://issues.apache.org/jira/browse/KAFKA-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160491#comment-13160491 ] Jun Rao commented on KAFKA-212: --- We shouldn't be leaking threads. If we can get to the code t

[jira] [Commented] (KAFKA-197) Embedded consumer doesn't shut down if the server can't start

[ https://issues.apache.org/jira/browse/KAFKA-197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162922#comment-13162922 ] Jun Rao commented on KAFKA-197: --- The main reason that we moved away from writing to local log

[jira] [Commented] (KAFKA-222) Mavenize contrib

[ https://issues.apache.org/jira/browse/KAFKA-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163235#comment-13163235 ] Jun Rao commented on KAFKA-222: --- +1 > Mavenize contrib > >

  1   2   3   >