[jira] [Commented] (KAFKA-187) Add Snappy Compression as a Codec and refactor CompressionUtil and option on startup to select what the default codec

2011-11-14 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150115#comment-13150115 ] Neha Narkhede commented on KAFKA-187: - +1 on the latest patch. I like the changes.

[jira] [Commented] (KAFKA-187) Add Snappy Compression as a Codec and refactor CompressionUtil and option on startup to select what the default codec

2011-11-14 Thread Jun Rao (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150105#comment-13150105 ] Jun Rao commented on KAFKA-187: --- The following are the changes that I made. Index: core/src

[jira] [Commented] (KAFKA-187) Add Snappy Compression as a Codec and refactor CompressionUtil and option on startup to select what the default codec

2011-11-14 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149908#comment-13149908 ] Neha Narkhede commented on KAFKA-187: - What is the difference between Joe's v2 patch an

[jira] [Commented] (KAFKA-187) Add Snappy Compression as a Codec and refactor CompressionUtil and option on startup to select what the default codec

2011-11-10 Thread Jeffrey Damick (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148278#comment-13148278 ] Jeffrey Damick commented on KAFKA-187: -- Right I agree it overlaps that thread, but is

[jira] [Commented] (KAFKA-187) Add Snappy Compression as a Codec and refactor CompressionUtil and option on startup to select what the default codec

2011-11-10 Thread Jun Rao (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147866#comment-13147866 ] Jun Rao commented on KAFKA-187: --- This is not a problem for java/scala clients. But it could b

[jira] [Commented] (KAFKA-187) Add Snappy Compression as a Codec and refactor CompressionUtil and option on startup to select what the default codec

2011-11-10 Thread Jeffrey Damick (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147729#comment-13147729 ] Jeffrey Damick commented on KAFKA-187: -- So, this raises a bigger question, how do clie

[jira] [Commented] (KAFKA-187) Add Snappy Compression as a Codec and refactor CompressionUtil and option on startup to select what the default codec

2011-11-07 Thread Jun Rao (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145987#comment-13145987 ] Jun Rao commented on KAFKA-187: --- Thanks, Joe. That's what I was looking for.

[jira] [Commented] (KAFKA-187) Add Snappy Compression as a Codec and refactor CompressionUtil and option on startup to select what the default codec

2011-11-07 Thread Joe Stein (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145770#comment-13145770 ] Joe Stein commented on KAFKA-187: - Yes, this patch allows for that. Here is how to verify.

[jira] [Commented] (KAFKA-187) Add Snappy Compression as a Codec and refactor CompressionUtil and option on startup to select what the default codec

2011-11-07 Thread Jun Rao (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145659#comment-13145659 ] Jun Rao commented on KAFKA-187: --- It would be good if the snappy jar is only a compile time de

[jira] [Commented] (KAFKA-187) Add Snappy Compression as a Codec and refactor CompressionUtil and option on startup to select what the default codec

2011-11-06 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145083#comment-13145083 ] Neha Narkhede commented on KAFKA-187: - >> provide a way on startup to select what the d