[jira] [Commented] (KAFKA-277) Add a shallow iterator to the ByteBufferMessageSet, which is only used in SynchProducer.verifyMessageSize() function

2012-02-20 Thread Jun Rao (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212133#comment-13212133 ] Jun Rao commented on KAFKA-277: --- Some comments: 1. The variable event just binds to every ite

[jira] [Commented] (KAFKA-277) Add a shallow iterator to the ByteBufferMessageSet, which is only used in SynchProducer.verifyMessageSize() function

2012-02-21 Thread Jun Rao (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212738#comment-13212738 ] Jun Rao commented on KAFKA-277: --- Also, please add a unit test for this. Use a max_message siz