[
https://issues.apache.org/jira/browse/KAFKA-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470610#comment-13470610
]
Jay Kreps commented on KAFKA-544:
-
After looking at the code I think there is a fair amount
[
https://issues.apache.org/jira/browse/KAFKA-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472511#comment-13472511
]
Jun Rao commented on KAFKA-544:
---
This plan sounds good to me.
> Retain key i
[
https://issues.apache.org/jira/browse/KAFKA-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497205#comment-13497205
]
Jay Kreps commented on KAFKA-544:
-
One other minor thing in this patch:
5. Both the key and
[
https://issues.apache.org/jira/browse/KAFKA-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497680#comment-13497680
]
Jun Rao commented on KAFKA-544:
---
Thanks for patch v3. Looks good overall. Some minor comments
[
https://issues.apache.org/jira/browse/KAFKA-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497755#comment-13497755
]
Jun Rao commented on KAFKA-544:
---
+1 on patch v5. For 30, could you add the same constructor c
[
https://issues.apache.org/jira/browse/KAFKA-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499938#comment-13499938
]
Neha Narkhede commented on KAFKA-544:
-
Minor comment - The API docs are broken in Produ
[
https://issues.apache.org/jira/browse/KAFKA-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502310#comment-13502310
]
Joel Koshy commented on KAFKA-544:
--
Thanks a lot for addressing the above. Changes look go
[
https://issues.apache.org/jira/browse/KAFKA-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503464#comment-13503464
]
Eli Reisman commented on KAFKA-544:
---
I like it!
> Retain key in producer
[
https://issues.apache.org/jira/browse/KAFKA-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504003#comment-13504003
]
Joel Koshy commented on KAFKA-544:
--
+1 - although can you fix the typo?
** if(props.contai