Re: error code in ByteBufferMessageSet

2012-04-03 Thread Jay Kreps
I guess the issue, though, is that MessageSet is meant to represent a set of messages even prior to their being published. As a result it is not necessarily the case that there is an offset yet. Likewise it is possible to write a single message set twice to two separate topics. I guess a fully corr

Re: error code in ByteBufferMessageSet

2012-04-02 Thread Prashanth Menon
My two cents here: Agreed on the getters and the errorCode: the former is unncessary and the latter should be solved with the new fetch response. With respect to the initialOffset, from the writer perspective it seems unnecessary. It's only really used from the consumer perspective as a convenie

Re: error code in ByteBufferMessageSet

2012-03-30 Thread Jun Rao
Yes, they should all be fixable with the new consumer response object. Could you open a jira to track this? Thanks, Jun On Fri, Mar 30, 2012 at 2:17 PM, Jay Kreps wrote: > There are a number of methods on ByteBufferMessageSet: > def getInitialOffset = initialOffset > def getBuffer = buffer >