[PATCH 5 of 8 v2] changeset controller: draft comment on changesets, backend code

# HG changeset patch # User Jan Heylen # Date 1430766152 -7200 # Mon May 04 21:02:32 2015 +0200 # Node ID 5e62c263fe2dbd6a46a6cd21e22b26bbf387e997 # Parent fa1872a9f955ac81cdd7a3bc3516ad05f1263400 changeset controller: draft comment on changesets, backend code diff -r fa1872a9f955 -r 5e62c2

[PATCH 4 of 8 v2] comment: add draft flag for comments

# HG changeset patch # User Jan Heylen # Date 1431012327 -7200 # Thu May 07 17:25:27 2015 +0200 # Node ID fa1872a9f955ac81cdd7a3bc3516ad05f1263400 # Parent a761b2b50afdf387951bef282954a86650b6ee70 comment: add draft flag for comments diff -r a761b2b50afd -r fa1872a9f955 kallithea/model/comm

[PATCH 3 of 8 v2] notification: allow comments in comment templates

# HG changeset patch # User Jan Heylen # Date 1431012349 -7200 # Thu May 07 17:25:49 2015 +0200 # Node ID a761b2b50afdf387951bef282954a86650b6ee70 # Parent dc6bb39a25a624034be795d083a118009f903d31 notification: allow comments in comment templates + create testcase for notifications with com

[PATCH 0 of 8 v2] save multiple comments at once

Hi, as you might know, I've been working on a change that a user would allow to open multiple comments on a commit, and 'post' (save) them all at once to the kallithea database. This patchset implements this workflow, by changing the 'comment' button on inline comments to a 'save' button and havi

[PATCH 6 of 8 v2] pullrequests controller: draft comment on pull requests backend code

# HG changeset patch # User Jan Heylen # Date 1431023355 -7200 # Thu May 07 20:29:15 2015 +0200 # Node ID c2694f3dbb9202e979bc342ca5e60ae83e7c0591 # Parent 5e62c263fe2dbd6a46a6cd21e22b26bbf387e997 pullrequests controller: draft comment on pull requests backend code diff -r 5e62c263fe2d -r c

[PATCH 7 of 8 v2] frontend: change comment workflow

# HG changeset patch # User Jan Heylen # Date 1431758388 -7200 # Sat May 16 08:39:48 2015 +0200 # Node ID f119d10ce90f342131b52a3751e697236523f413 # Parent c2694f3dbb9202e979bc342ca5e60ae83e7c0591 frontend: change comment workflow This changes the workflow from one-comment-at-a-time to giv

[PATCH 1 of 8 v2] changeset/pullrequest controller: refactor some old variable naming

# HG changeset patch # User Jan Heylen # Date 1430766457 -7200 # Mon May 04 21:07:37 2015 +0200 # Node ID 4fad09a8ca22ff3ec15ceb46383e0d534682e048 # Parent 7a5db341a942a4bea1c433846ad040e8ae0d8a68 changeset/pullrequest controller: refactor some old variable naming c.co is a bit cryptic, use

[PATCH 8 of 8 v2] drafts: emphasize the users attention on his drafts

# HG changeset patch # User Jan Heylen # Date 1428987893 -7200 # Tue Apr 14 07:04:53 2015 +0200 # Node ID 88a6cdc7a8700dc05d443768e876a7c8d13ef14b # Parent f119d10ce90f342131b52a3751e697236523f413 drafts: emphasize the users attention on his drafts diff -r f119d10ce90f -r 88a6cdc7a870 kalli

[PATCH 2 of 8 v2] database: drafts: add draft column in changesetcomment table

# HG changeset patch # User Jan Heylen # Date 1430814921 -7200 # Tue May 05 10:35:21 2015 +0200 # Node ID dc6bb39a25a624034be795d083a118009f903d31 # Parent 4fad09a8ca22ff3ec15ceb46383e0d534682e048 database: drafts: add draft column in changesetcomment table + migration script to add the col

[DEMO] automatic saving of draft comments

Hi, as a 'bonus' on the draft workflow, I wanted to change the way comments are "edited", I found this javascript event "blur", but I'm having issues with it because in firefox, the relatedTarget object is always NULL on a BLUR event, while on other browsers, this points to the object that gets th

Re: [DEMO] automatic saving of draft comments

correction: and a demo/code on this blur demo here: http://heyleke.pythonanywhere.com/kallithea-heyleke/changeset/28a2bd5250ba1bb26d9a09b51c95e1e07bab6ff3 (login: test pass: testtest) Jan On Sat, May 16, 2015 at 2:11 PM, Jan Heylen wrote: > Hi, > > as a 'bonus' on the draft workflow, I wanted

[PATCH v2] auth: let users log in using their email address

# HG changeset patch # User Andrew Shadura # Date 1431709586 -7200 # Fri May 15 19:06:26 2015 +0200 # Node ID 93de511e84fe940786acf468789a77daed83a461 # Parent 95bffe63997d40bfab5ae6b8d1a54859d6275471 auth: let users log in using their email address diff --git a/kallithea/controllers/login.

Re: [PATCH] auth: let users log in using their email address

Hello, On Fri, 15 May 2015 23:52:27 +0200 Mads Kiilerich wrote: > On 05/15/2015 07:06 PM, Andrew Shadura wrote: > > # HG changeset patch > > # User Andrew Shadura > > # Date 1431709586 -7200 > > # Fri May 15 19:06:26 2015 +0200 > > # Node ID 1a7787acd1276557128ac6f8cd274b39c86ebbae > > # P

[PATCH] privacy: on password reset, don't tell strangers if email is valid or not

# HG changeset patch # User Andrew Shadura # Date 1431787037 -7200 # Sat May 16 16:37:17 2015 +0200 # Node ID 388a6eada55925cb55cd2368e47a6115d833b4c1 # Parent 93de511e84fe940786acf468789a77daed83a461 privacy: on password reset, don't tell strangers if email is valid or not Password reset f

Re: [PATCH] privacy: on password reset, don't tell strangers if email is valid or not

Hello, On Sat, 16 May 2015 16:37:42 +0200 Andrew Shadura wrote: > Password reset form might be used to check if users with specific > email addresses have accounts in the system by requesting their > password to be reset. It's probably not a good idea to give this sort > of information to comple

[PATCH] privacy: don't tell users what is the reason for a failed login

# HG changeset patch # User Andrew Shadura # Date 1431788631 -7200 # Sat May 16 17:03:51 2015 +0200 # Node ID cb911e90e205bdb18fc2e2bd66549ea388d00413 # Parent 388a6eada55925cb55cd2368e47a6115d833b4c1 privacy: don't tell users what is the reason for a failed login Makes it harder for strang

Re: [PATCH] privacy: don't tell users what is the reason for a failed login

Hello, On Sat, 16 May 2015 17:04:06 +0200 Andrew Shadura wrote: > raise formencode.Invalid(msg, value, state, > -error_dict=dict(username=msg, password=msg2) > +error_dict=dict(username=' ',password=msg) >

Re: [PATCH 3 of 8 v2] notification: allow comments in comment templates

On Sat, May 16, 2015 at 2:02 PM, Jan Heylen wrote: > # HG changeset patch > # User Jan Heylen > # Date 1431012349 -7200 > # Thu May 07 17:25:49 2015 +0200 > # Node ID a761b2b50afdf387951bef282954a86650b6ee70 > # Parent dc6bb39a25a624034be795d083a118009f903d31 > notification: allow comments

Re: [PATCH 8 of 8 v2] drafts: emphasize the users attention on his drafts

On Sat, May 16, 2015 at 2:02 PM, Jan Heylen wrote: > # HG changeset patch > # User Jan Heylen > # Date 1428987893 -7200 > # Tue Apr 14 07:04:53 2015 +0200 > # Node ID 88a6cdc7a8700dc05d443768e876a7c8d13ef14b > # Parent f119d10ce90f342131b52a3751e697236523f413 > drafts: emphasize the users a

Re: [PATCH] pullrequest/compare: add logical changeset index to clarify the order

On Fri, May 15, 2015 at 11:26 PM, Mads Kiilerich wrote: > On 05/13/2015 09:25 PM, Thomas De Schampheleire wrote: >> >> # HG changeset patch >> # User Thomas De Schampheleire >> # Date 1431287504 -7200 >> # Sun May 10 21:51:44 2015 +0200 >> # Node ID e19127e4040d1817bbec77118ca7377644f76a64 >

Re: [PATCH 1 of 2 v2] tests: move pytest settings from kallithea/tests/pytest.ini to setup.cfg

On Sat, May 16, 2015 at 12:50 AM, Mads Kiilerich wrote: > On 05/14/2015 09:47 PM, Thomas De Schampheleire wrote: >> >> # HG changeset patch >> # User Thomas De Schampheleire >> # Date 1431630347 -7200 >> # Thu May 14 21:05:47 2015 +0200 >> # Node ID 6a7b32b3fdc09d515dc68c347b60e9d8d07a1a5e >

Re: [PATCH 3 of 8 v2] notification: allow comments in comment templates

On May 16, 2015 10:31 PM, "Thomas De Schampheleire" < patrickdeping...@gmail.com> wrote: > > On Sat, May 16, 2015 at 2:02 PM, Jan Heylen wrote: > > # HG changeset patch > > # User Jan Heylen > > # Date 1431012349 -7200 > > # Thu May 07 17:25:49 2015 +0200 > > # Node ID a761b2b50afdf387951bef

Re: [PATCH 1 of 6 v2] admin: users: factorize check for default user

On 05/14/2015 10:15 PM, Thomas De Schampheleire wrote: On Tue, May 12, 2015 at 2:46 AM, Mads Kiilerich wrote: On 05/10/2015 08:22 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire # Date 1430943590 -7200 # Wed May 06 22:19:50 2015 +0200 # Node ID 877f

Re: pytest adoption: current status (beginning of May)

On 05/15/2015 09:37 PM, Thomas De Schampheleire wrote: On a related note: Mads reported that the amount of tests collected by pytest outnumbered the amount of tests collected by nose. I compared the output of 'nosetests --collect-only' and 'py.test --collect-only', and conclude that this differen

Re: [PATCH] auth: let users log in using their email address

On 05/16/2015 03:53 PM, Andrew Shadura wrote: FWIW: The only other place where users have to care about their (and others) "login" is in @mention. It would be nice to be able to specify email addresses there too. @usern...@example.com should work in the scanner (regexp) and auto completer. Some

Re: [PATCH v2] auth: let users log in using their email address

On 05/16/2015 03:49 PM, Andrew Shadura wrote: # HG changeset patch # User Andrew Shadura # Date 1431709586 -7200 # Fri May 15 19:06:26 2015 +0200 # Node ID 93de511e84fe940786acf468789a77daed83a461 # Parent 95bffe63997d40bfab5ae6b8d1a54859d6275471 auth: let users log in using their email ad

[PATCH PoC] secure password reset implementation

# HG changeset patch # User Andrew Shadura # Date 1431821238 -7200 # Sun May 17 02:07:18 2015 +0200 # Node ID 8d43a8174c960779437c2d8de7a0906a8cd14128 # Parent cb911e90e205bdb18fc2e2bd66549ea388d00413 secure password reset implementation This is a better implementation of password reset fun

Re: [PATCH PoC] secure password reset implementation

Hello, On Sun, 17 May 2015 02:07:40 +0200 Andrew Shadura wrote: > # HG changeset patch > # User Andrew Shadura > # Date 1431821238 -7200 > # Sun May 17 02:07:18 2015 +0200 > # Node ID 8d43a8174c960779437c2d8de7a0906a8cd14128 > # Parent cb911e90e205bdb18fc2e2bd66549ea388d00413 > secure pas

Re: [PATCH v2] auth: let users log in using their email address

Hello, On Sun, 17 May 2015 01:50:56 +0200 Mads Kiilerich wrote: > > diff --git a/kallithea/controllers/login.py > > b/kallithea/controllers/login.py --- > > a/kallithea/controllers/login.py +++ > > b/kallithea/controllers/login.py @@ -121,9 +121,15 @@ class > > LoginController(BaseController): s

Re: [PATCH] pullrequest/compare: add logical changeset index to clarify the order

On 05/16/2015 10:46 PM, Thomas De Schampheleire wrote: On Fri, May 15, 2015 at 11:26 PM, Mads Kiilerich wrote: I'm not sure how much of a win I think it is ... but ok. A mouseover tooltip could perhaps explain what the number means - especially if the tip was different for the first and last c

Re: [PATCH v2] auth: let users log in using their email address

On 05/17/2015 02:11 AM, Andrew Shadura wrote: Hello, On Sun, 17 May 2015 01:50:56 +0200 Mads Kiilerich wrote: diff --git a/kallithea/controllers/login.py b/kallithea/controllers/login.py --- a/kallithea/controllers/login.py +++ b/kallithea/controllers/login.py @@ -121,9 +121,15 @@ class Login

[PATCH 8 of 8 v3] drafts: emphasize the users attention on his drafts

# HG changeset patch # User Jan Heylen # Date 1428987893 -7200 # Tue Apr 14 07:04:53 2015 +0200 # Node ID 0b68f3f61c7df505e6914ae2037b0ce6519277ca # Parent 56a6e827cecee7df5910cec2b9346c98be9f3f48 drafts: emphasize the users attention on his drafts diff -r 56a6e827cece -r 0b68f3f61c7d kalli

Re: [DEMO] automatic saving of draft comments

by the way: the edit button is gone for the moment, but if I would get the cancel button fixed for firefox (probably not :-( ... )I was planning to add editable drafts (so the edit button edits your draft comments) Jan On Sat, May 16, 2015 at 2:13 PM, Jan Heylen wrote: > correction: > > and a d