Issue #144: Add ability to review a full file and not only a changeset (conservancy/kallithea)

2015-06-30 Thread Mathieu Clabaut
New issue 144: Add ability to review a full file and not only a changeset https://bitbucket.org/conservancy/kallithea/issue/144/add-ability-to-review-a-full-file-and-not Mathieu Clabaut: Doing review of changesets works well when the review process was set up at the beginning of the project,

[PATCH 02 of 19] autocomplete: factor out matchUsers function

2015-06-30 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1435162968 -7200 # Wed Jun 24 18:22:48 2015 +0200 # Node ID 29390aec8d12021642c13741a57da8901be9a9a4 # Parent 16fff695ace152d8f165b033980678a68e60822c autocomplete: factor out matchUsers function

[PATCH 13 of 19] autocomplete: fix completion of repository owner

2015-06-30 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1435592559 -7200 # Mon Jun 29 17:42:39 2015 +0200 # Node ID f1d674589538cbf1c6d066b203016009d7c679b2 # Parent 2d3ead418f13410650da664144462a54a0312163 autocomplete: fix completion of repository owner

[PATCH 04 of 19] autocomplete: factor out highlightMatch function

2015-06-30 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1435259401 -7200 # Thu Jun 25 21:10:01 2015 +0200 # Node ID e929bdac2f7c78849cb649279dfe93ae4761f52c # Parent fca74929123428f02ade6d63c3f368368128619d autocomplete: factor out highlightMatch function

[PATCH 01 of 19] autocomplete: remove dead code

2015-06-30 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1435174346 -7200 # Wed Jun 24 21:32:26 2015 +0200 # Node ID 16fff695ace152d8f165b033980678a68e60822c # Parent 03dd2a5776400d58670071530910f7526d13d259 autocomplete: remove dead code The three blocks

[PATCH 00 of 19] autocomplete cleanup / user name displaying

2015-06-30 Thread Thomas De Schampheleire
As discussed before, here is a thorough cleanup of the autocomplete JavaScript code, as preliminary for a rationalization of the way user names are displayed... This does not yet include the removal of all explicit uses of user.lastname in places that really should be using full_name, because it

[PATCH 14 of 19] autocomplete: misc cleanup

2015-06-30 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1435692456 -7200 # Tue Jun 30 21:27:36 2015 +0200 # Node ID 88065e9e70e233fc2232ffeeaafadaee2698b766 # Parent f1d674589538cbf1c6d066b203016009d7c679b2 autocomplete: misc cleanup Some miscellaneous

[PATCH 12 of 19] autocomplete: introduce function to set up basic autocomplete functionality

2015-06-30 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1435679620 -7200 # Tue Jun 30 17:53:40 2015 +0200 # Node ID 2d3ead418f13410650da664144462a54a0312163 # Parent 00a21b2c96879db000cb598df11d9671766869c2 autocomplete: introduce function to set up basic

[PATCH 19 of 19] autocomplete: consistently show 'username (Full Name)'

2015-06-30 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1435696257 -7200 # Tue Jun 30 22:30:57 2015 +0200 # Node ID b0620802d61a9a7b9bf4442ad0204ee8f8f53725 # Parent 1b989931c539d2ef2160eb9d2b5734d9c711d5ca autocomplete: consistently show 'username (Full

[PATCH 07 of 19] autocomplete: factor out formatResult function

2015-06-30 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1435261603 -7200 # Thu Jun 25 21:46:43 2015 +0200 # Node ID 623155b700e275d039d1a9065f272dc6fa4fb569 # Parent 2bc67e169d2f80e67d9e32df023e4133d8049948 autocomplete: factor out formatResult function

[PATCH 10 of 19] autocomplete: remove redundant return in MembersAutoComplete

2015-06-30 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1435349622 -7200 # Fri Jun 26 22:13:42 2015 +0200 # Node ID 3d214cd2fdd8b6c24cd147127283a3ffe7bdc0de # Parent d6d25547fc3ffc050212e5b4ec2c04478c6ebc03 autocomplete: remove redundant return in