Re: [PATCH 4 of 4] cli: front-end-build: generate pygments.css dynamically

2018-11-24 Thread Mads Kiilerich
On 11/22/2018 10:36 PM, Thomas De Schampheleire wrote: diff --git a/kallithea/bin/kallithea_cli_front_end.py b/kallithea/bin/kallithea_cli_front_end.py --- a/kallithea/bin/kallithea_cli_front_end.py +++ b/kallithea/bin/kallithea_cli_front_end.py @@ -48,3 +48,9 @@ def

Re: Kallithea feature: notifications: anyone using it?

2018-11-24 Thread Mads Kiilerich
On 11/24/2018 02:52 PM, Thomas De Schampheleire wrote: Hello, So since apart from Long Vu (thanks!) there was no response, I guess that indeed no-one is really using the Notifications feature in the top-right of the web UI? Mads, do you know of any useful uses? What would you say about

Re: [PATCH 2 of 4] cli: fix celery-run usage text

2018-11-24 Thread Mads Kiilerich
For context, this is how it looks on stable branch, before the change to gearbox "broke" it:   $ paster celeryd development.ini -h   Usage: paster celeryd [options] CONFIG_FILE [celeryd options...] Also, looking more into it, it seems like the full_cmd_name proposed previously is the same as

Re: [PATCH 1 of 4] cli: fix celery-run

2018-11-24 Thread Mads Kiilerich
On 11/22/2018 10:36 PM, Thomas De Schampheleire wrote: diff --git a/kallithea/bin/kallithea_cli_celery.py b/kallithea/bin/kallithea_cli_celery.py --- a/kallithea/bin/kallithea_cli_celery.py +++ b/kallithea/bin/kallithea_cli_celery.py @@ -36,4 +36,4 @@ def celery_run(celery_args): from

Re: [PATCH 12 of 14] controllers: align pullrequests.comment with changeset.comment

2018-11-24 Thread Mads Kiilerich
On 11/24/2018 03:07 PM, Thomas De Schampheleire wrote: @@ -672,26 +676,30 @@ class PullrequestsController(BaseRepoCon comment = create_comment( text, status, +revision=revision, pull_request_id=pull_request_id,

Re: [PATCH 12 of 14] controllers: align pullrequests.comment with changeset.comment

2018-11-24 Thread Thomas De Schampheleire
El vie., 23 nov. 2018 a las 12:49, Mads Kiilerich () escribió: > > On 11/22/2018 09:25 PM, Thomas De Schampheleire wrote: > > El mié., 21 nov. 2018 a las 12:48, Mads Kiilerich > > () escribió: > >> On 11/20/2018 09:32 PM, Thomas De Schampheleire wrote: > >>> # HG changeset patch > >>> # User

Re: Kallithea feature: notifications: anyone using it?

2018-11-24 Thread Thomas De Schampheleire
Hello, So since apart from Long Vu (thanks!) there was no response, I guess that indeed no-one is really using the Notifications feature in the top-right of the web UI? Mads, do you know of any useful uses? What would you say about removing it? Main driver would be removal of code and thus