On 2/8/20 7:10 AM, Mads Kiilerich wrote:
> It would be nice to have more details in the commit message explaining
> what the intent is, so we don't have to reverse engineer it. We want to
> review that we are aligned on the intent, and that the change is a
> maintainable and good / best way to i
On 2/8/20 6:05 AM, Mads Kiilerich wrote:
> Thanks. I do agree this is better. But is it fixing an actual problem?
> The old manual encoding seems to work fine too?
Yep, it worked but it was mostly fortunate 'luck'. It ended up using
matrix mode instead of true query params.
The resulting query
On 2/8/20 2:06 AM, Ross Thomas wrote:
# HG changeset patch
# User Ross Thomas
# Date 1581113799 28800
# Fri Feb 07 14:16:39 2020 -0800
# Branch stable
# Node ID 504adebdb50183678de362b52bc89a9c082f4ea7
# Parent f273a7b53fe035c12a55b6a3e34f849af245d797
ui: Add support for extra 'quick' icon
On 2/8/20 2:06 AM, Ross Thomas wrote:
# HG changeset patch
# User Ross Thomas
# Date 1581112527 28800
# Fri Feb 07 13:55:27 2020 -0800
# Branch stable
# Node ID f273a7b53fe035c12a55b6a3e34f849af245d797
# Parent 2571674c4a2fd6247a6dee7d9b4e27df13df1429
follow: Fix args for $.post() call in