Re: [PATCH 2 of 2 stable v2] tests: prevent Git system and global configuration from loading

2023-04-19 Thread Mads Kiilerich
On 18/04/2023 20:35, Manuel Jacob wrote: # HG changeset patch # User Manuel Jacob # Date 1680139355 -7200 # Thu Mar 30 03:22:35 2023 +0200 # Branch stable # Node ID e5251abd0a3c677d7bb0828f3a744789bd6fe4cb # Parent 30082bb9719eb00f3be0081b7221d7c3061d4345 # EXP-Topic tests-git tests: preve

Re: [PATCH 2 of 2 stable v2] tests: prevent Git system and global configuration from loading

2023-04-19 Thread Manuel Jacob
On 19/04/2023 14.27, Mads Kiilerich wrote: On 18/04/2023 20:35, Manuel Jacob wrote: # HG changeset patch # User Manuel Jacob # Date 1680139355 -7200 #  Thu Mar 30 03:22:35 2023 +0200 # Branch stable # Node ID e5251abd0a3c677d7bb0828f3a744789bd6fe4cb # Parent  30082bb9719eb00f3be0081b7221d7c

Re: [PATCH 2 of 2 stable v2] tests: prevent Git system and global configuration from loading

2023-04-19 Thread Mads Kiilerich
On 19/04/2023 15:14, Manuel Jacob wrote: On 19/04/2023 14.27, Mads Kiilerich wrote: On 18/04/2023 20:35, Manuel Jacob wrote: ... I think this changeset should come first. As you say, it makes the test work the same way everywhere. user.useconfigonly is probably just one of many settings that c

Re: [PATCH 2 of 2 stable v2] tests: prevent Git system and global configuration from loading

2023-04-19 Thread Manuel Jacob
On 19/04/2023 16.27, Mads Kiilerich wrote: On 19/04/2023 15:14, Manuel Jacob wrote: On 19/04/2023 14.27, Mads Kiilerich wrote: On 18/04/2023 20:35, Manuel Jacob wrote: ... I think this changeset should come first. As you say, it makes the test work the same way everywhere. user.useconfigonly i

Re: [PATCH 2 of 2 stable v2] tests: prevent Git system and global configuration from loading

2023-04-19 Thread Manuel Jacob
On 19/04/2023 17.21, Manuel Jacob wrote: On 19/04/2023 16.27, Mads Kiilerich wrote: On 19/04/2023 15:14, Manuel Jacob wrote: On 19/04/2023 14.27, Mads Kiilerich wrote: On 18/04/2023 20:35, Manuel Jacob wrote: ... I think this changeset should come first. As you say, it makes the test work the

Re: [PATCH 2 of 2 stable v2] tests: prevent Git system and global configuration from loading

2023-04-19 Thread Mads Kiilerich
On 19/04/2023 17:27, Manuel Jacob wrote: On 19/04/2023 17.21, Manuel Jacob wrote: On Arch Linux: % git --version git version 2.40.0 % GIT_CONFIG_GLOBAL=/dev/null GIT_CONFIG_SYSTEM=/dev/null EMAIL='foo@bar' git commit -m "committed new 0" --author "User ǝɯɐᴎ " Committer identity unknown O

Re: [PATCH 2 of 2 stable v2] tests: prevent Git system and global configuration from loading

2023-04-19 Thread Manuel Jacob
On 19/04/2023 19.12, Mads Kiilerich wrote: On 19/04/2023 17:27, Manuel Jacob wrote: On 19/04/2023 17.21, Manuel Jacob wrote: On Arch Linux: % git --version git version 2.40.0 % GIT_CONFIG_GLOBAL=/dev/null GIT_CONFIG_SYSTEM=/dev/null EMAIL='foo@bar' git commit -m "committed new 0" --author "Us

[PATCH 2 of 2 stable v3] tests: prevent Git system and global configuration from loading

2023-04-19 Thread Manuel Jacob
# HG changeset patch # User Manuel Jacob # Date 1680139355 -7200 # Thu Mar 30 03:22:35 2023 +0200 # Branch stable # Node ID e9a574cea28a8db42ff6a84a41a91b6cbe336cbc # Parent 846ca7f28bd40e07c76ed259ce96a31a85d0c4ea # EXP-Topic tests-git tests: prevent Git system and global configuration from

[PATCH 1 of 2 stable v3] tests: set Git author and committer name and email settings explicitly

2023-04-19 Thread Manuel Jacob
# HG changeset patch # User Manuel Jacob # Date 1680121377 -7200 # Wed Mar 29 22:22:57 2023 +0200 # Branch stable # Node ID 846ca7f28bd40e07c76ed259ce96a31a85d0c4ea # Parent 0a9ddb8cd8c117671ecaf2b4126c3eef09e80ce8 # EXP-Topic tests-git tests: set Git author and committer name and email sett

Re: [PATCH 1 of 2 stable v3] tests: set Git author and committer name and email settings explicitly

2023-04-19 Thread Mads Kiilerich
Thanks - this looks much more approachable. But while processing v2 and our discussion and trying to give good input to what I would like to see in v3, I figured it perhaps would be better with a simpler solution. What do you think about doing it as in https://kallithea-scm.org/repos/kallith

Re: [PATCH 1 of 2 stable v3] tests: set Git author and committer name and email settings explicitly

2023-04-19 Thread Manuel Jacob
On 20/04/2023 01.07, Mads Kiilerich wrote: Thanks - this looks much more approachable. But while processing v2 and our discussion and trying to give good input to what I would like to see in v3, I figured it perhaps would be better with a simpler solution. What do you think about doing it as