Re: [PATCH 0 of 1] Enhancement: Repo browser quick action icons

On 2/11/20 11:20 AM, Ross Thomas wrote: > The onClick handler needs to return the result of the called function. I've had a couple of folks ask 'Why?' so I guess this isn't as commonly understood as I thought. For those that may not be aware, when the event handler is coded via html l

Re: [PATCH 0 of 1] Enhancement: Repo browser quick action icons

On 2/11/20 10:27 AM, Ross Thomas wrote: > Looking into it here. Yep. I've been bitten by this before. :-p The onClick handler needs to return the result of the called function. A fix patch is attached for illustration as it affects both this enhancement and stable/default. Ross. diff

Re: [PATCH 0 of 1] Enhancement: Repo browser quick action icons

On 2/11/20 5:33 AM, Mads Kiilerich wrote: > Do you also see the repo list scroll to top when toggling "follow"? Yep. I'm guessing it has something to do with toggleFollowingRepo() since it also does it on the repo page using the Options menu. Looking into it here. Ross.

Re: [PATCH 2 of 2] ui: Add support for extra 'quick' icons in repo browser

Wow. I really didn't mean to trigger such a wide-ranging UI design discussion. On 2/9/20 4:56 PM, Mads Kiilerich wrote: > My concern is only about duplication of the other icons. I'm not sure it's duplication so much as an additional navigation path to the same functionality. So ... more UX

[PATCH 1 of 1] ui: Add support for 'quick' action icons in repo browser

# HG changeset patch # User Ross Thomas # Date 1581113799 28800 # Fri Feb 07 14:16:39 2020 -0800 # Branch stable # Node ID 0c6914676f88f7fae5818e27ae65c15ef45fba88 # Parent f273a7b53fe035c12a55b6a3e34f849af245d797 ui: Add support for 'quick' action icons in repo browser config: Add new

[PATCH 0 of 1] Enhancement: Repo browser quick action icons

This replaces the previously submitted patch changeset: 504adebdb501 It changes the names that were identified as too generic. It also fixes and refines the configurable nature of the enhancement. It does NOT

Re: [PATCH 2 of 2] ui: Add support for extra 'quick' icons in repo browser

On 2/8/20 7:10 AM, Mads Kiilerich wrote: > It would be nice to have more details in the commit message explaining > what the intent is, so we don't have to reverse engineer it. We want to > review that we are aligned on the intent, and that the change is a > maintainable and good / best way to

Re: [PATCH 1 of 2] follow: Fix args for $.post() call in toggleFollowingRepo()

On 2/8/20 6:05 AM, Mads Kiilerich wrote: > Thanks. I do agree this is better. But is it fixing an actual problem? > The old manual encoding seems to work fine too? Yep, it worked but it was mostly fortunate 'luck'. It ended up using matrix mode instead of true query params. The resulting query

[PATCH 2 of 2] ui: Add support for extra 'quick' icons in repo browser

# HG changeset patch # User Ross Thomas # Date 1581113799 28800 # Fri Feb 07 14:16:39 2020 -0800 # Branch stable # Node ID 504adebdb50183678de362b52bc89a9c082f4ea7 # Parent f273a7b53fe035c12a55b6a3e34f849af245d797 ui: Add support for extra 'quick' icons in repo browser config: Add new value

[PATCH 1 of 2] follow: Fix args for $.post() call in toggleFollowingRepo()

# HG changeset patch # User Ross Thomas # Date 1581112527 28800 # Fri Feb 07 13:55:27 2020 -0800 # Branch stable # Node ID f273a7b53fe035c12a55b6a3e34f849af245d797 # Parent 2571674c4a2fd6247a6dee7d9b4e27df13df1429 follow: Fix args for $.post() call in toggleFollowingRepo() diff -r

[PATCH 0 of 2] Fix + enhancement

- The first patch is a bug-fix. - The second patch adds 'quick' icons to repos in the repository browser -- (un)follow toggle, fork op and settings (if allowed). (Screenshot: ) We've found it useful so we're sending it out in case