[Oxygen] [Bug 380452] latest commit in master (Use Q_DECL_OVERRIDE) causes failed builds

2017-06-02 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=380452 Hugo Pereira Da Costa changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED

[Oxygen] [Bug 380452] latest commit in master (Use Q_DECL_OVERRIDE) causes failed builds

2017-06-02 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=380452 Hugo Pereira Da Costa changed: What|Removed |Added Assignee|mon...@kde.org |hugo.pereira.da.costa@gmail

[Oxygen] [Bug 380452] latest commit in master (Use Q_DECL_OVERRIDE) causes failed builds

2017-06-02 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=380452 Hugo Pereira Da Costa changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED

[Oxygen] [Bug 380452] latest commit in master (Use Q_DECL_OVERRIDE) causes failed builds

2017-06-02 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=380452 --- Comment #3 from Hugo Pereira Da Costa --- Also, I remember a discussion on kcd about how using Q_DECL_OVERRIDE was a pita, and that one should simply use "override". Just checked, that's what kwin and kdecoration does. Since at least the decoratio

[Oxygen] [Bug 380452] latest commit in master (Use Q_DECL_OVERRIDE) causes failed builds

2017-06-02 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=380452 --- Comment #2 from Hugo Pereira Da Costa --- Note that a proper code review would have prevent this (idem in breeze). -- You are receiving this mail because: You are watching all bug changes.

[Oxygen] [Bug 380452] latest commit in master (Use Q_DECL_OVERRIDE) causes failed builds

2017-06-02 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=380452 Hugo Pereira Da Costa changed: What|Removed |Added CC||hugo.pereira.da.costa@gmail