[clazy] [Bug 377617] clazy-qstring-left makes false assumption

2017-03-19 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=377617 Sergio Martins changed: What|Removed |Added Resolution|--- |FIXED Latest Commit|

[clazy] [Bug 377617] clazy-qstring-left makes false assumption

2017-03-18 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=377617 --- Comment #3 from markus.enzenber...@gmail.com --- The danger that I see right now is that someone runs clazy on code they didn't write, simply follows the warning to replace left(1) by at(0) and thereby introduces a new, maybe subtle and rarely trigge

[clazy] [Bug 377617] clazy-qstring-left makes false assumption

2017-03-18 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=377617 --- Comment #2 from Sergio Martins --- While that's true, it's still faster to call !isEmpty()+at(0) since they don't allocate memory. I don't see any solution besides improving the readme -- You are receiving this mail because: You are watching all

[clazy] [Bug 377617] clazy-qstring-left makes false assumption

2017-03-18 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=377617 --- Comment #1 from Sergio Martins --- Git commit 4234fabc16cbdf3d14ab05fc20f251fcb04719b2 by Sergio Martins. Committed on 18/03/2017 at 11:43. Pushed by smartins into branch '1.1'. qstring-left: Improve readme at(0) asserts if string is empty, while

[clazy] [Bug 377617] clazy-qstring-left makes false assumption

2017-03-18 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=377617 Sergio Martins changed: What|Removed |Added Assignee|unassigned-b...@kde.org |smart...@kde.org -- You are receiving this ma

[clazy] [Bug 377617] clazy-qstring-left makes false assumption

2017-03-18 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=377617 Sergio Martins changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0

[clazy] [Bug 377617] clazy-qstring-left makes false assumption

2017-03-15 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=377617 markus.enzenber...@gmail.com changed: What|Removed |Added CC||markus.enzenber...@gmail.co