https://bugs.kde.org/show_bug.cgi?id=377197
Simon changed:
What|Removed |Added
Resolution|--- |FIXED
Version Fixed In|
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #59 from caulier.gil...@gmail.com ---
Simon,
I tested too on my computer. No side effect and all run as expected as i can
see...
Good work. I think all is fine to commit now.
Gilles
--
You are receiving this mail because:
You are
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #58 from Simon ---
Created attachment 105489
--> https://bugs.kde.org/attachment.cgi?id=105489=edit
Adjust kipi-plugins for grouping
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=377197
Simon changed:
What|Removed |Added
Attachment #105453|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #56 from Simon ---
Created attachment 105454
--> https://bugs.kde.org/attachment.cgi?id=105454=edit
Customize grouping behavior patch version 12
These changes somehow went missing patch 11, 12 should compile again
https://bugs.kde.org/show_bug.cgi?id=377197
caulier.gil...@gmail.com changed:
What|Removed |Added
Attachment #105446|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #54 from Maik Qualmann ---
Gilles,
The patch can not compile, the imagecategorizedview.h is not patched.
maik@linux-tpgn:~ gcc --version
gcc (SUSE Linux) 6.3.1 20170202 [gcc-6-branch revision 245119]
Maik
--
You
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #53 from caulier.gil...@gmail.com ---
This error can be generated by a different GC version than one, and of course
by different compilation options passed by KDE::ECM modules. Here we don't
manage anything.
The best way to hack is to check
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #52 from Maik Qualmann ---
I have a compiler error here, but will check again, since Gilles has already
tested it already.
Maik
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.cpp:
In
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #51 from caulier.gil...@gmail.com ---
I tested with patch v11 and HTMLExport and i do not see any difference while
processing items. No time latency or something like that.
My grouped album to test :
https://bugs.kde.org/show_bug.cgi?id=377197
caulier.gil...@gmail.com changed:
What|Removed |Added
Attachment #105330|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #49 from caulier.gil...@gmail.com ---
The patch V10 cannot not be applied it against git/master. New version is ready
on my computer. I will post it in few minutes...
Gilles
--
You are receiving this mail because:
You are watching all bug
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #48 from Simon ---
Yes, the deduplicate patch is integrated in the grouping patch. I just thought
that splitting the change into meaningful pieces makes it more readable (but
that's not really the case with patches,
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #47 from caulier.gil...@gmail.com ---
Simon, patch 9 must be obsolete no ?
What's about Deduplicate code patch ? It's not integrated in patch 10 ?
Gilles
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #46 from caulier.gil...@gmail.com ---
I do not see why it's called more than one time with KIPI plugins.
I see your screenshot of setup panel. I like the new settings. It's clear.
Just a remark : "kipi plugins" => "plugins" : since there
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #45 from Simon ---
Gilles,
This is all done already. DigikamView::selectedUrls() accepts an (optional)
argument (either bool or ApplicationSettings::OperationType) to include grouped
items or not.
The change I
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #44 from caulier.gil...@gmail.com ---
Simon,
Look this report :
https://bugs.kde.org/show_bug.cgi?id=286609
Panorama tool do not support grouped items behavior. Look how it's called from
DigikamApp::line 2621. It use also
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #43 from caulier.gil...@gmail.com ---
Ah i forget to said that Digikamview::allUrls() must be patch to return also
the grouped items list depending of digiKam settings.
Gilles
--
You are receiving this mail because:
You are watching all
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #42 from caulier.gil...@gmail.com ---
>The only change needed should be in line 190 of kipiimagecollection.cpp:
>return DigikamApp::instance()->view()->selectedUrls();
>to
>return
>
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #41 from Simon ---
That was too good to be true. The only change needed should be in line 190 of
kipiimagecollection.cpp:
return DigikamApp::instance()->view()->selectedUrls();
to
return
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #40 from caulier.gil...@gmail.com ---
Simon,
The items selcted from icon view is passed to a plugin through the KIPI
interface. All is located in
core/utilities/kdesupport/kipi/kipiimagecollection.cpp. Look in function
images(), and
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #39 from Maik Qualmann ---
Ok, I also see no code for the kipi-Plugins in the patch, except for the
configuration. Simon, I would suggest setting the default for Kipi plugins to
NO and disable for selection this line.
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #38 from Simon ---
I just had a look and couldn't even figure out how the selection makes it to
the kipi plugins. Apparently I just added the Kipi member to the enum as I
considered it relevant and then never followed
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #37 from caulier.gil...@gmail.com ---
Maik,
No objection from me. I just follow the file only and let's you to test Simon
patches.
Note : kipi interface do not support yet grouped items. If i remember, there is
a generic file in bugzilla
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #36 from Maik Qualmann ---
Ignore the thing with the empty text line, I have not seen right. But the other
thing does not work.
Maik
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #35 from Maik Qualmann ---
Created attachment 105393
--> https://bugs.kde.org/attachment.cgi?id=105393=edit
grouping.png
As I said, I think it would not be necessary if Gilles did not mind, I would
also agree. But
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #34 from Simon ---
Created attachment 105389
--> https://bugs.kde.org/attachment.cgi?id=105389=edit
Customize grouping behavior patch version 10
Version 10 fixes compiler warnings.
There was no more problems
https://bugs.kde.org/show_bug.cgi?id=377197
Simon changed:
What|Removed |Added
Attachment #105016|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #32 from Simon ---
Originally the request originated around tagging. After the change users
started complaining mostly about slideshow and lighttable. And for my personal
workflow it absolutely makes sense to do
https://bugs.kde.org/show_bug.cgi?id=377197
Mario Frank changed:
What|Removed |Added
CC|
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #30 from Maik Qualmann ---
I have not found any problems with the V8 patch. But I think we do not need to
distinguish between BQM, light table, renaming, etc. An option for all cases
(yes, no, ask) should be enough.
https://bugs.kde.org/show_bug.cgi?id=377197
Simon changed:
What|Removed |Added
Attachment #104827|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=377197
Simon changed:
What|Removed |Added
Attachment #104714|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=377197
Simon changed:
What|Removed |Added
Attachment #104716|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=377197
Simon changed:
What|Removed |Added
Attachment #104641|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=377197
Simon changed:
What|Removed |Added
Attachment #104675|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #24 from Maik Qualmann ---
Simon,
"Move To Album..." does not work.
Maik
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=377197
Simon changed:
What|Removed |Added
Attachment #104635|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #22 from Maik Qualmann ---
Simon,
patch 104648 does not compile...
/home/maik/Devel/digikam-software-compilation/core/app/views/tableview/tableview.cpp:
In member function ‘QList
https://bugs.kde.org/show_bug.cgi?id=377197
Vincent Tassy changed:
What|Removed |Added
CC||time...@free.fr
--- Comment
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #20 from Simon ---
Created attachment 104648
--> https://bugs.kde.org/attachment.cgi?id=104648=edit
Deduplicate code between icon and table view (V3)
Ok, thanks for fixing. I wasn't aware of a QT LTS version we
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #19 from caulier.gil...@gmail.com ---
Qt 5.6 LTS need certainly an explicit parent, or null. You must pass a parent
to QAction constructor.
Gilles
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #18 from Simon ---
I intentionally removed "this" from these kind of calls:
QAction* const actionIgnoreGrouping = new QAction(i18n("Ignore grouping"),
this);
The reason is that they will be children of
https://bugs.kde.org/show_bug.cgi?id=377197
caulier.gil...@gmail.com changed:
What|Removed |Added
Attachment #104636|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #16 from caulier.gil...@gmail.com ---
This warning need also to be corrected :
[ 90%] Building CXX object
core/app/CMakeFiles/digikamgui_src.dir/digikamgui_src_automoc.cpp.o
/home/gilles/Devel/5.x/core/app/views/digikamview.cpp: In member
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #15 from caulier.gil...@gmail.com ---
"Customize" patch version 4 do not compile. I has fixed this problem in version
3 :
/home/gilles/Devel/5.x/core/app/views/tableview/tableview.cpp: In member
function ‘QList
https://bugs.kde.org/show_bug.cgi?id=377197
Simon changed:
What|Removed |Added
Attachment #104633|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=377197
Simon changed:
What|Removed |Added
Attachment #104632|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #12 from caulier.gil...@gmail.com ---
Simon,
With Customize patch applied, i can see this on the console :
digikam.general: Cancel Main Thread
QObject::connect: No such slot Digikam::DigikamView::deleteSelected() in
https://bugs.kde.org/show_bug.cgi?id=377197
caulier.gil...@gmail.com changed:
What|Removed |Added
Attachment #104490|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #10 from Maik Qualmann ---
I have patch 104632 tested.
Maik
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #9 from Maik Qualmann ---
Simon,
Short test here, cut, copy, paste, delete to the trash no longer works.
Maik
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #8 from caulier.gil...@gmail.com ---
[gilles@localhost core]$ patch -p1 < customizeGrouping-2.patch
patching file app/items/digikamimageview.cpp
patching file app/items/digikamimageview.h
patching file app/items/imagecategorizedview.cpp
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #7 from caulier.gil...@gmail.com ---
Note : it's voluntary to not include "Deduplicate" patch in "Customize" patch ?
Do you want to apply "Deduplicate" patch quickly in git/master ?
Gilles
--
You are receiving this mail because:
You are
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #6 from caulier.gil...@gmail.com ---
Yes good improvement in source code.
Can you reproduce the icon/widget overlays on icon view, when you enable all
options from setup and when you change the icon size from status bar ?
Also turn on Hdpi
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #5 from Simon ---
Created attachment 104632
--> https://bugs.kde.org/attachment.cgi?id=104632=edit
Deduplicate code between icon and table view
This is the part of the patch that is not actually directly related to
https://bugs.kde.org/show_bug.cgi?id=377197
Simon changed:
What|Removed |Added
Attachment #104362|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=377197
--- Comment #3 from Simon ---
Yes, context menu is obviously broken. I tested all kinds of things but
for unknown reasons never once did a right click. This code is also
heavily duplicated between table and icon view, I am thus
https://bugs.kde.org/show_bug.cgi?id=377197
caulier.gil...@gmail.com changed:
What|Removed |Added
CC||caulier.gil...@gmail.com
59 matches
Mail list logo