https://bugs.kde.org/show_bug.cgi?id=406586
Kartik changed:
What|Removed |Added
CC||kartikx2...@gmail.com
--- Comment #3 from Kartik ---
https://bugs.kde.org/show_bug.cgi?id=406586
--- Comment #4 from caulier.gil...@gmail.com ---
Hi Kartik,
There is certainly a signal propagation missing between the GUI and the
database interface to represh the count of item in tree view.
Some pointers in source code :
https://invent.kde.org/kde
https://bugs.kde.org/show_bug.cgi?id=406586
--- Comment #5 from Kartik ---
Thanks for the reply Gilles. I've gone through the files that you mentioned.
I understand that the TagFolderView in PeopleSidebar, keeps tracks of tags as
TAlbums, which are created based on the name that we assign to the
https://bugs.kde.org/show_bug.cgi?id=406586
--- Comment #6 from Kartik ---
I'm currently trying to fix the duplicate bug 416180.
Confirming/Rejecting a face is dealt by DigikamItemView::confirmFaces() (and
rejectFaces()) respectively. Maybe there could be an implementation at the end
of these m
https://bugs.kde.org/show_bug.cgi?id=406586
Maik Qualmann changed:
What|Removed |Added
CC||metzping...@gmail.com
--- Comment #7 from Maik
https://bugs.kde.org/show_bug.cgi?id=406586
--- Comment #8 from Maik Qualmann ---
The ImageTagProperties table is important here. If the entries change here, it
affects the number of people in the people tree view.
Maik
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=406586
--- Comment #9 from Kartik ---
Thanks a lot for the suggestions, Maik. I never checked the libs/database
folder, this really improved my understanding.
Whenever we confirm/reject face suggestions, the database is written to by
CoreDB::addImageTagProper
https://bugs.kde.org/show_bug.cgi?id=406586
--- Comment #10 from Kartik ---
The method I proposed does update the new count, however it always trails
behind the actual situation by 1 image.
For eg. if I had 7 new unconfirmed faces, and I confirmed one, the count will
not decrement immediately.
https://bugs.kde.org/show_bug.cgi?id=406586
--- Comment #11 from Kartik ---
Update: I have resolved the issue.
In CoreDB::AddImageTagProperty
I added d->db->recordChangeset(TagChangeset(tagId, TagChangeset::Added));
In CoreDB::removeImageTagProperties
I added d->db->recordChangeset(TagChangese
https://bugs.kde.org/show_bug.cgi?id=406586
--- Comment #12 from Maik Qualmann ---
Yes, that is a solution to this problem. Create a patch and upload it here. So
that we can apply the patch and close the bug. Good work.
Maik
--
You are receiving this mail because:
You are watching all bug chan
https://bugs.kde.org/show_bug.cgi?id=406586
--- Comment #13 from Kartik ---
I have made a merge request.
https://invent.kde.org/kde/digikam/-/merge_requests/12
Thanks for all the help Marc , Maik and Gilles :)
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=406586
--- Comment #14 from Maik Qualmann ---
The patch is not yet perfect. You add a CMakeLists.txt.user with 8600 lines.
Maik
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=406586
Maik Qualmann changed:
What|Removed |Added
Resolution|--- |FIXED
Version Fixed In|
https://bugs.kde.org/show_bug.cgi?id=406586
--- Comment #16 from Maik Qualmann ---
Git commit e4b99936c71f0894fdd448d1cba3007bc4d44417 by Maik Qualmann.
Committed on 24/03/2020 at 18:48.
Pushed by mqualmann into branch 'master'.
add new TagChangeset to update only
Related: bug 419171
FIXED-IN: 7
https://bugs.kde.org/show_bug.cgi?id=406586
Maik Qualmann changed:
What|Removed |Added
CC||nic...@tuxfamily.org
--- Comment #2 from Maik Q
https://bugs.kde.org/show_bug.cgi?id=406586
Nicofo changed:
What|Removed |Added
Version|6.1.0 |7.0.0
--
You are receiving this mail because:
You are
https://bugs.kde.org/show_bug.cgi?id=406586
caulier.gil...@gmail.com changed:
What|Removed |Added
CC||caulier.gil...@gmail.com
--- Comment
https://bugs.kde.org/show_bug.cgi?id=406586
IWBR changed:
What|Removed |Added
CC||iwannaber...@gmail.com
--
You are receiving this mail b
18 matches
Mail list logo
