[elisa] [Bug 421662] Elisa does not release PowerManagement inhibitions on exit if it's playing when exited

2020-12-18 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=421662 Bug Janitor Service changed: What|Removed |Added Resolution|WAITINGFORINFO |WORKSFORME Status|NEEDSINFO

[elisa] [Bug 421662] Elisa does not release PowerManagement inhibitions on exit if it's playing when exited

2020-12-03 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=421662 --- Comment #20 from Bug Janitor Service --- Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular

[elisa] [Bug 421662] Elisa does not release PowerManagement inhibitions on exit if it's playing when exited

2020-11-18 Thread Gabriel Marcano
https://bugs.kde.org/show_bug.cgi?id=421662 --- Comment #19 from Gabriel Marcano --- I can check later today (or sometime this week? Being back in school is consuming my life), but I suspect part of the reason you won't be able to reproduce it (if your commit didn't fix it) is if you updated

[elisa] [Bug 421662] Elisa does not release PowerManagement inhibitions on exit if it's playing when exited

2020-11-18 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=421662 --- Comment #18 from Nate Graham --- Git commit 468eaa7e9d0614884971326cfbc1caacdde904b7 by Nate Graham, on behalf of Matthieu Gallien. Committed on 18/11/2020 at 22:46. Pushed by ngraham into branch 'release/20.12'. prevent crash by stopping play

[elisa] [Bug 421662] Elisa does not release PowerManagement inhibitions on exit if it's playing when exited

2020-11-18 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=421662 Matthieu Gallien changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|CONFIRMED

[elisa] [Bug 421662] Elisa does not release PowerManagement inhibitions on exit if it's playing when exited

2020-11-18 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=421662 --- Comment #16 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/192 -- You are receiving this mail because: You are watching all bug changes.

[elisa] [Bug 421662] Elisa does not release PowerManagement inhibitions on exit if it's playing when exited

2020-06-18 Thread Gabriel Marcano
https://bugs.kde.org/show_bug.cgi?id=421662 --- Comment #15 from Gabriel Marcano --- I've been doing some reading to understand what's going on. At least with the libvlc audiowrapper, it does look like at some point something is causing the AudioWrapper::stop() slot to be called, which is good.

[elisa] [Bug 421662] Elisa does not release PowerManagement inhibitions on exit if it's playing when exited

2020-06-18 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=421662 Matthieu Gallien changed: What|Removed |Added Status|NEEDSINFO |CONFIRMED Ever confirmed|0

[elisa] [Bug 421662] Elisa does not release PowerManagement inhibitions on exit if it's playing when exited

2020-06-18 Thread Gabriel Marcano
https://bugs.kde.org/show_bug.cgi?id=421662 --- Comment #13 from Gabriel Marcano --- I'd love to take a stab, but I can't do it for the next month and a half, as my employer limits what code I can contribute (intellectual property assignment clause in contract). I'm actually leaving for grad

[elisa] [Bug 421662] Elisa does not release PowerManagement inhibitions on exit if it's playing when exited

2020-06-18 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=421662 --- Comment #12 from Matthieu Gallien --- (In reply to Gabriel Marcano from comment #11) > In terms of what could be done by elise, I'm not too sure as I'm not > familiar with the entire codebase, but maybe we could install a custom > handler for

[elisa] [Bug 421662] Elisa does not release PowerManagement inhibitions on exit if it's playing when exited

2020-06-18 Thread Gabriel Marcano
https://bugs.kde.org/show_bug.cgi?id=421662 --- Comment #11 from Gabriel Marcano --- In terms of what could be done by elise, I'm not too sure as I'm not familiar with the entire codebase, but maybe we could install a custom handler for "file_quit" that somehow tells the AudioWrapper to stop

[elisa] [Bug 421662] Elisa does not release PowerManagement inhibitions on exit if it's playing when exited

2020-06-17 Thread Gabriel Marcano
https://bugs.kde.org/show_bug.cgi?id=421662 --- Comment #10 from Gabriel Marcano --- I've opened a new bug report for Powerdevil: bug 423131 Even with that bug in place, I still think elisa should try to uninhibit during a regular application exit. I think it's fair to not bother with corner

[elisa] [Bug 421662] Elisa does not release PowerManagement inhibitions on exit if it's playing when exited

2020-06-17 Thread Gabriel Marcano
https://bugs.kde.org/show_bug.cgi?id=421662 --- Comment #9 from Gabriel Marcano --- So, playing an mp3, AudioWrapper::playerStateSignalChanges doesn't fire when exiting the application (https://github.com/KDE/elisa/blob/aecd9917a45d6c8e3c698490ab5404baacefdcf1/src/audiowrapper_libvlc.cpp#L335).

[elisa] [Bug 421662] Elisa does not release PowerManagement inhibitions on exit if it's playing when exited

2020-06-13 Thread Gabriel Marcano
https://bugs.kde.org/show_bug.cgi?id=421662 --- Comment #8 from Gabriel Marcano --- Here's the PowerDevil commit that introduced the delay: https://github.com/KDE/powerdevil/commit/eca79138c15575f6f523a8680919b407f84da2e2 It's a conscious decision by the powerdevil developers. As far as I can

[elisa] [Bug 421662] Elisa does not release PowerManagement inhibitions on exit if it's playing when exited

2020-06-13 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=421662 --- Comment #7 from Nate Graham --- Worth a bug on Powerdevil, for sure. Is there anything actionable here for Elisa? -- You are receiving this mail because: You are watching all bug changes.

[elisa] [Bug 421662] Elisa does not release PowerManagement inhibitions on exit if it's playing when exited

2020-06-13 Thread Gabriel Marcano
https://bugs.kde.org/show_bug.cgi?id=421662 --- Comment #6 from Gabriel Marcano --- Interesting. It looks like I wasn't hallucinating about the 5 seconds:https://github.com/KDE/powerdevil/blob/master/daemon/powerdevilpolicyagent.cpp#L509 PowerDevil is the thing that is implementing the

[elisa] [Bug 421662] Elisa does not release PowerManagement inhibitions on exit if it's playing when exited

2020-06-10 Thread Gabriel Marcano
https://bugs.kde.org/show_bug.cgi?id=421662 --- Comment #5 from Gabriel Marcano --- Interesting. Looks like a race condition. Here's a quick screen capture I did with OBS (so it's also inhibiting): https://i.imgur.com/wtmo7pC.mp4 Let me know if you can't access that video for some reason. In

[elisa] [Bug 421662] Elisa does not release PowerManagement inhibitions on exit if it's playing when exited

2020-06-10 Thread Gabriel Marcano
https://bugs.kde.org/show_bug.cgi?id=421662 --- Comment #4 from Gabriel Marcano --- Yes, I can still reproduce the problem. I re-built elisa with commit 1f400cf32e434479a0b35e19e34a9081e2bd78cc. $ dbus-send --session --dest=org.kde.Solid.PowerManagement.PolicyAgent --type=method_call

[elisa] [Bug 421662] Elisa does not release PowerManagement inhibitions on exit if it's playing when exited

2020-06-10 Thread Gabriel Marcano
https://bugs.kde.org/show_bug.cgi?id=421662 --- Comment #3 from Gabriel Marcano --- I'll take a look tonight to see if I can reproduce it. I'm curious to see how it's being handled now, if you can't reproduce the problem. -- You are receiving this mail because: You are watching all bug

[elisa] [Bug 421662] Elisa does not release PowerManagement inhibitions on exit if it's playing when exited

2020-06-10 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=421662 Nate Graham changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|REPORTED

[elisa] [Bug 421662] Elisa does not release PowerManagement inhibitions on exit if it's playing when exited

2020-05-17 Thread Gabriel Marcano
https://bugs.kde.org/show_bug.cgi?id=421662 --- Comment #1 from Gabriel Marcano --- I've been able to hack something on my end, by making QDBusInterface objects and using them to send a synchronous message to release the active Inhibit cookie. I'm still a little uneasy, as I'm afraid of a

[elisa] [Bug 421662] Elisa does not release PowerManagement inhibitions on exit if it's playing when exited

2020-05-17 Thread Gabriel Marcano
https://bugs.kde.org/show_bug.cgi?id=421662 Gabriel Marcano changed: What|Removed |Added CC||gabemarc...@yahoo.com -- You are receiving