https://bugs.kde.org/show_bug.cgi?id=407999

            Bug ID: 407999
           Summary: Fragile comparison to i18n("None")
           Product: frameworks-kdeclarative
           Version: 5.58.0
          Platform: Fedora RPMs
                OS: Linux
            Status: REPORTED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: notm...@gmail.com
          Reporter: aspotas...@gmail.com
                CC: kdelibs-b...@kde.org
  Target Milestone: ---

SUMMARY
Fragile comparison to i18n("None") in
kdeclarative/src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml:108:
===
source: delegate.text === i18n("None") ? "edit-none" : "view-preview"
===

If the caller code translates "None" into the target language differently, this
comparison will return false and behave not as intended. This component should
probably use another boolean property to choose between these two icons, or
just an "icon" property to specify a custom icon.

Please also describe this behaviour in the documentation. From the current
documentation at
https://api.kde.org/frameworks/kdeclarative/html/classorg_1_1kde_1_1kcm_1_1GridDelegate.html
it's unclear how the component behaves and what icons it may use for what
purposes.

STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to