https://bugs.kde.org/show_bug.cgi?id=417355
Ahmad Samir <a.samir...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|REPORTED |RESOLVED
Version Fixed In| |5.68
Latest Commit| |https://commits.kde.org/kio
| |/9cb7cf957a1cc2e60fae7f82ca
| |ff325221e8bcf4
--- Comment #1 from Ahmad Samir <a.samir...@gmail.com> ---
Git commit 9cb7cf957a1cc2e60fae7f82caff325221e8bcf4 by Ahmad Samir.
Committed on 07/03/2020 at 07:39.
Pushed by ahmadsamir into branch 'master'.
[KFileFilterCombo] Don't add invalid QMimeType to mimes filter
Summary:
When setting the mime filter, check that the QMimeType we get from
QMimeDatabase::mimeTypeForName() is valid before adding it to the mime
filter list. This fixes a bug where if the QMimeType is invalid its name
(and comment) property is empty, leading to empty entries in the filter
widget drop-down menu.
Per dfaure's recommendation, display a warning about the invalid mimeType.
Also install the necessary Qt logging catergory bits for KFileWidgets.
FIXED-IN: 5.68
Test Plan:
- Open gwenview -> file -> open and check the filter drown-down menu
there are a couple (two?) empty entries
- Apply diff and try again, no empty entries
Reviewers: #frameworks, dfaure, meven, sitter, broulik
Reviewed By: dfaure
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D27865
M +16 -0 src/filewidgets/CMakeLists.txt
M +6 -1 src/filewidgets/kfilefiltercombo.cpp
https://commits.kde.org/kio/9cb7cf957a1cc2e60fae7f82caff325221e8bcf4
--
You are receiving this mail because:
You are watching all bug changes.
