https://bugs.kde.org/show_bug.cgi?id=465073
Bug ID: 465073 Summary: GlobalDrawer gets hidden by Esc. even when in non-modal Sidebar mode. Classification: Frameworks and Libraries Product: frameworks-kirigami Version: 5.102.0 Platform: Other OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: general Assignee: kdelibs-b...@kde.org Reporter: inbox@willchen.business CC: notm...@gmail.com Target Milestone: Not decided SUMMARY The GlobalDrawer component can be set to always show as a persistent sidebar of icons even when collapsed. This is officially recommended for some Desktop applications in the HIG: https://develop.kde.org/hig/components/navigation/globaldrawer/#collapsible However, with a recent change, even when the GlobalDrawer is configured as such, pressing [Esc.] will still make it disappear completely. There's a couple problems with this: - There's no GUI element to completely hide the drawer when it's serving as a sidebar. So this creates a secret state that can be reached only with the keyboard. - The icon-sidebar view is *already* the "collapsed" state when it's set to be used. A completely hidden state is superfluous. - Depending on the application, there may not be a way to get the drawer back. STEPS TO REPRODUCE 1. Open Kirigami Gallery. 2. In the Global Drawer, set the mode to "Collapsible Sidebar Drawer". 3. The drawer should now be a persistent sidebar, similar to the example described in the HIG. 4. Press [Esc]. OBSERVED RESULT Oh No! The drawer is gone! I'm pretty sure this is new/a regression. I've been developing an application that relies on the sidebar mode pretty heavily, and I would have noticed if pressing Esc. made my main sidebar disappear every time. EXPECTED RESULT The drawer should not disappear when used as a sidebar. SOFTWARE/OS VERSIONS KDE Plasma Version: 5.26.5 KDE Frameworks Version: 5.102.0 Qt Version: 5.15.8 ADDITIONAL INFORMATION I suspect this may have been introduced in MR #798, as that does touch the shortcuts and back button, and nothing else has for a couple years. https://invent.kde.org/frameworks/kirigami/-/merge_requests/798 Separate issue: I'm pretty sure `enabled: !isMenu` is also new, but the code makes it much clearer that that's supposed to happen, so I suppose that was broken before. -- You are receiving this mail because: You are watching all bug changes.