[frameworks-ktexteditor] [Bug 371042] Contrast issues with Breeze Dark Schema

2016-10-24 Thread Dominik Haumann via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=371042 --- Comment #10 from Dominik Haumann --- Git commit 5a3dabd93619f5fab60517997f07d889b1f9630c by Dominik Haumann. Committed on 24/10/2016 at 20:15. Pushed by dhaumann into branch 'master'. Breeze Dark: Darken current-line background color for better rea

[frameworks-ktexteditor] [Bug 371042] Contrast issues with Breeze Dark Schema

2016-10-24 Thread Janek Bevendorff via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=371042 --- Comment #9 from Janek Bevendorff --- Yeah, that looks fine. -- You are receiving this mail because: You are watching all bug changes.

[frameworks-ktexteditor] [Bug 371042] Contrast issues with Breeze Dark Schema

2016-10-24 Thread Dominik Haumann via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=371042 --- Comment #8 from Dominik Haumann --- Ok, what would you say to the middle of both colors: #2A2E32 = rgb(42, 46, 50) for the current-line-color? Looks like a good compromise to me, do you agree? -- You are receiving this mail because: You are watch

[frameworks-ktexteditor] [Bug 371042] Contrast issues with Breeze Dark Schema

2016-10-24 Thread Janek Bevendorff via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=371042 --- Comment #7 from Janek Bevendorff --- Strange, I had a different color, although I haven't changed anything. With #31363b it's a little better, but not optimal. I would make the current line color darker. -- You are receiving this mail because: You

[frameworks-ktexteditor] [Bug 371042] Contrast issues with Breeze Dark Schema

2016-10-24 Thread Dominik Haumann via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=371042 --- Comment #6 from Dominik Haumann --- The current-line-color is #31363b, following the Breeze colors defined here: https://community.kde.org/KDE_Visual_Design_Group/HIG/Color So the background color itself follows the "alternat background color" of t

[frameworks-ktexteditor] [Bug 371042] Contrast issues with Breeze Dark Schema

2016-10-24 Thread Janek Bevendorff via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=371042 --- Comment #5 from Janek Bevendorff --- That's a little better. I think for normal text it's okay. But the issue with the current line still persists. The current line color is #3f3b51 and that makes comments very hard to read, even with the new color.

[frameworks-ktexteditor] [Bug 371042] Contrast issues with Breeze Dark Schema

2016-10-24 Thread Dominik Haumann via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=371042 --- Comment #4 from Dominik Haumann --- Git commit 65c55459084083560e785f41feaf8712e7f960a7 by Dominik Haumann. Committed on 24/10/2016 at 19:29. Pushed by dhaumann into branch 'master'. Breeze (Dark): Make comment color a bit lighter for better readab

[frameworks-ktexteditor] [Bug 371042] Contrast issues with Breeze Dark Schema

2016-10-24 Thread Dominik Haumann via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=371042 --- Comment #3 from Dominik Haumann --- The email address highlighting issue was already fixed here: https://bugs.kde.org/show_bug.cgi?id=363186 Btw, the comments intentionally have a bit less contrast, so that one can easily distinguish between code a

[frameworks-ktexteditor] [Bug 371042] Contrast issues with Breeze Dark Schema

2016-10-24 Thread Dominik Haumann via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=371042 Dominik Haumann changed: What|Removed |Added Resolution|--- |FIXED Version Fixed In|

[frameworks-ktexteditor] [Bug 371042] Contrast issues with Breeze Dark Schema

2016-10-17 Thread Janek Bevendorff via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=371042 --- Comment #1 from Janek Bevendorff --- I would suggest making the comment color a little lighter and highlight all docblock comments in green instead of gray. Certain tags in doc comments are already green, why not make everything that color to distin