https://bugs.kde.org/show_bug.cgi?id=397719
--- Comment #1 from Dominik Haumann ---
Created attachment 114534
--> https://bugs.kde.org/attachment.cgi?id=114534&action=edit
Left: KTextEditor, Right:KSyntaxHighlighting
See the different between left KTextEditor and right KSyntaxHighlighting.
--
https://bugs.kde.org/show_bug.cgi?id=397719
Dominik Haumann changed:
What|Removed |Added
CC||cullm...@kde.org,
|
https://bugs.kde.org/show_bug.cgi?id=397719
--- Comment #2 from Volker Krause ---
This looks like it's caused by a missing space between the alert keyword and
the comment marker. I don't have the old version around to compare, but e.g.
"/**TODO" with C++ highlighting also doesn't highlight TODO a
https://bugs.kde.org/show_bug.cgi?id=397719
--- Comment #3 from Christoph Cullmann ---
/**TODO */
doesn't highlight in C++ pre-syntax-highlighting here, too.
non-doxygen stuff like
/*TODO*/
//TODO
does
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=397719
--- Comment #4 from Volker Krause ---
The difference might be that the new implementation for the keyword rule also
checks if there's a word delimiter before the keyword, not just after it?
That's at least if I read the old implementation correctly. If
https://bugs.kde.org/show_bug.cgi?id=397719
--- Comment #5 from Christoph Cullmann ---
Hmm, why does it work without the Doxygen hl, e.g. for normal comments?
I would assume * is a word delimiter and as /*TODO*/ works, that check is ok.
--
You are receiving this mail because:
You are watching
https://bugs.kde.org/show_bug.cgi?id=397719
--- Comment #6 from Volker Krause ---
Indeed, * is a delimiter, but # isn't. So this explains the Python difference
but nothing related to C++. Presumably we would see the issue with other
languages using # as a comment character though, like Bash or Pe
https://bugs.kde.org/show_bug.cgi?id=397719
--- Comment #7 from Dominik Haumann ---
In that case, I am in favor of adding # to the standard delimiters. Or would
that be a problem?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=397719
--- Comment #8 from Volker Krause ---
Seems reasonable, but I can't estimate the impact of this. Maybe run the unit
tests with that and see how much breaks?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=397719
--- Comment #9 from Christoph Cullmann ---
The question is: as that doesn't solve the * case, perhaps one should first
take a look why that doesn't work. Or is that just a Doxygen hl glitch?
--
You are receiving this mail because:
You are watching all
https://bugs.kde.org/show_bug.cgi?id=397719
Christoph Cullmann changed:
What|Removed |Added
Status|UNCONFIRMED |ASSIGNED
Ever confirmed|0
https://bugs.kde.org/show_bug.cgi?id=397719
--- Comment #10 from Christoph Cullmann ---
https://phabricator.kde.org/D15196
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=397719
Christoph Cullmann changed:
What|Removed |Added
Latest Commit||https://commits.kde.org/syn
https://bugs.kde.org/show_bug.cgi?id=397719
--- Comment #1 from Dominik Haumann ---
Created attachment 114534
--> https://bugs.kde.org/attachment.cgi?id=114534&action=edit
Left: KTextEditor, Right:KSyntaxHighlighting
See the different between left KTextEditor and right KSyntaxHighlighting.
--
https://bugs.kde.org/show_bug.cgi?id=397719
Dominik Haumann changed:
What|Removed |Added
CC||cullm...@kde.org,
|
https://bugs.kde.org/show_bug.cgi?id=397719
--- Comment #2 from Volker Krause ---
This looks like it's caused by a missing space between the alert keyword and
the comment marker. I don't have the old version around to compare, but e.g.
"/**TODO" with C++ highlighting also doesn't highlight TODO a
https://bugs.kde.org/show_bug.cgi?id=397719
--- Comment #3 from Christoph Cullmann ---
/**TODO */
doesn't highlight in C++ pre-syntax-highlighting here, too.
non-doxygen stuff like
/*TODO*/
//TODO
does
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=397719
--- Comment #4 from Volker Krause ---
The difference might be that the new implementation for the keyword rule also
checks if there's a word delimiter before the keyword, not just after it?
That's at least if I read the old implementation correctly. If
https://bugs.kde.org/show_bug.cgi?id=397719
--- Comment #5 from Christoph Cullmann ---
Hmm, why does it work without the Doxygen hl, e.g. for normal comments?
I would assume * is a word delimiter and as /*TODO*/ works, that check is ok.
--
You are receiving this mail because:
You are watching
https://bugs.kde.org/show_bug.cgi?id=397719
--- Comment #6 from Volker Krause ---
Indeed, * is a delimiter, but # isn't. So this explains the Python difference
but nothing related to C++. Presumably we would see the issue with other
languages using # as a comment character though, like Bash or Pe
https://bugs.kde.org/show_bug.cgi?id=397719
--- Comment #7 from Dominik Haumann ---
In that case, I am in favor of adding # to the standard delimiters. Or would
that be a problem?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=397719
--- Comment #8 from Volker Krause ---
Seems reasonable, but I can't estimate the impact of this. Maybe run the unit
tests with that and see how much breaks?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=397719
--- Comment #9 from Christoph Cullmann ---
The question is: as that doesn't solve the * case, perhaps one should first
take a look why that doesn't work. Or is that just a Doxygen hl glitch?
--
You are receiving this mail because:
You are watching all
https://bugs.kde.org/show_bug.cgi?id=397719
Christoph Cullmann changed:
What|Removed |Added
Status|UNCONFIRMED |ASSIGNED
Ever confirmed|0
https://bugs.kde.org/show_bug.cgi?id=397719
--- Comment #10 from Christoph Cullmann ---
https://phabricator.kde.org/D15196
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=397719
Christoph Cullmann changed:
What|Removed |Added
Latest Commit||https://commits.kde.org/syn
26 matches
Mail list logo
