[kate] [Bug 181528] Menu items in Tools -> External Tools are untranslatable

2019-12-02 Thread Dominik Haumann
https://bugs.kde.org/show_bug.cgi?id=181528 --- Comment #17 from Dominik Haumann --- Merge request: https://invent.kde.org/kde/kate/merge_requests/50 -- You are receiving this mail because: You are watching all bug changes.

[kate] [Bug 181528] Menu items in Tools -> External Tools are untranslatable

2019-12-02 Thread Alexander Potashev
https://bugs.kde.org/show_bug.cgi?id=181528 --- Comment #16 from Alexander Potashev --- OTOH those JSONs assume that you are using KPlugin while here we won't ever use a plugin per external command... -- You are receiving this mail because: You are watching all bug changes.

[kate] [Bug 181528] Menu items in Tools -> External Tools are untranslatable

2019-12-02 Thread Dominik Haumann
https://bugs.kde.org/show_bug.cgi?id=181528 Dominik Haumann changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

[kate] [Bug 181528] Menu items in Tools -> External Tools are untranslatable

2019-12-02 Thread Dominik Haumann
https://bugs.kde.org/show_bug.cgi?id=181528 Dominik Haumann changed: What|Removed |Added Latest Commit|https://invent.kde.org/kde/ |https://commits.kde.org/kat

[kate] [Bug 181528] Menu items in Tools -> External Tools are untranslatable

2019-12-02 Thread Alexander Potashev
https://bugs.kde.org/show_bug.cgi?id=181528 --- Comment #13 from Alexander Potashev --- Quite a hacky approach, huh? I would use the standard translatable .json files if I was implementing this from scratch, like this one https://cgit.kde.org/purpose.git/tree/src/plugins/twitter/metadata.json --

[kate] [Bug 181528] Menu items in Tools -> External Tools are untranslatable

2019-12-02 Thread Dominik Haumann
https://bugs.kde.org/show_bug.cgi?id=181528 --- Comment #12 from Dominik Haumann --- Ah I think that makes a lot of sense! Thanks, will post a patch. -- You are receiving this mail because: You are watching all bug changes.

[kate] [Bug 181528] Menu items in Tools -> External Tools are untranslatable

2019-12-02 Thread Alexander Potashev
https://bugs.kde.org/show_bug.cgi?id=181528 --- Comment #11 from Alexander Potashev --- I think I know how to fix it: these must be i18nc() calls, not just i18n() because strings are extracted with contexts "External tool name" or "External tool category". diff --git a/addons/externaltools/kate

[kate] [Bug 181528] Menu items in Tools -> External Tools are untranslatable

2019-12-02 Thread Dominik Haumann
https://bugs.kde.org/show_bug.cgi?id=181528 --- Comment #10 from Dominik Haumann --- Git commit df460443bf6e651812acb17d31ec1a9d26c71c6a by Dominik Haumann. Committed on 02/12/2019 at 20:31. Pushed by scmsync into branch 'fix-translation'. Fix: Do not translate KActionCollection identifier M +

[kate] [Bug 181528] Menu items in Tools -> External Tools are untranslatable

2019-12-02 Thread Dominik Haumann
https://bugs.kde.org/show_bug.cgi?id=181528 --- Comment #9 from Dominik Haumann --- Git commit df460443bf6e651812acb17d31ec1a9d26c71c6a by Dominik Haumann. Committed on 02/12/2019 at 20:31. Pushed by dhaumann into branch 'fix-translation'. Fix: Do not translate KActionCollection identifier M +

[kate] [Bug 181528] Menu items in Tools -> External Tools are untranslatable

2019-12-02 Thread Alexander Potashev
https://bugs.kde.org/show_bug.cgi?id=181528 Alexander Potashev changed: What|Removed |Added Flags||Translation_missing+ -- You are receiving

[kate] [Bug 181528] Menu items in Tools -> External Tools are untranslatable

2019-12-02 Thread Alexander Potashev
https://bugs.kde.org/show_bug.cgi?id=181528 Alexander Potashev changed: What|Removed |Added Resolution|UNMAINTAINED|--- Status|RESOLVED

[kate] [Bug 181528] Menu items in Tools -> External Tools are untranslatable

2019-09-21 Thread Dominik Haumann
https://bugs.kde.org/show_bug.cgi?id=181528 --- Comment #7 from Dominik Haumann --- PS: It's back. We have to check translation issues, though. https://kate-editor.org/post/2019/2019-09-21-external-tools-plugin/ -- You are receiving this mail because: You are watching all bug changes.