https://bugs.kde.org/show_bug.cgi?id=232246

David Faure <fa...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|WORKSFORME                  |FIXED
      Latest Commit|                            |http://commits.kde.org/libk
                   |                            |sieve/ee4afdd78597cb9379a39
                   |                            |951b9eca94a8e927f98

--- Comment #2 from David Faure <fa...@kde.org> ---
Git commit ee4afdd78597cb9379a39951b9eca94a8e927f98 by David Faure.
Committed on 14/07/2016 at 14:51.
Pushed by dfaure into branch 'master'.

KSieve Session: fix race while handling SSL errors.

Summary:
No need to post a request to the thread for handling an ignored ssl error,
which the thread will simply handle by emitting the sslDone signal,
which goes back to the main thread. By doing that we were making it possible
for the thread to emit other things meanwhile - like the received data from the
server,
out of sequence (the main thread can only handle it after receiving sslDone)

This fixes the never-ending spinning in "Manage Sieve Scripts" in kmail
for me (which happened about 20% of the time).

Test Plan: Manage Sieve Scripts in kmail, > 5 times.

Reviewers: dvratil, mlaurent

Reviewed By: mlaurent

Subscribers: kde-pim, #kde_pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D2167

M  +5    -1    src/kmanagesieve/session.cpp
M  +0    -21   src/kmanagesieve/sessionthread.cpp
M  +0    -2    src/kmanagesieve/sessionthread_p.h

http://commits.kde.org/libksieve/ee4afdd78597cb9379a39951b9eca94a8e927f98

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to