[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken, CMakeListsParser::readCMakeFile]

2017-07-28 Thread Kevin Funk
https://bugs.kde.org/show_bug.cgi?id=363269 Kevin Funk changed: What|Removed |Added Version Fixed In||5.1.2 -- You are receiving this mail because: You

[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken, CMakeListsParser::readCMakeFile]

2017-07-28 Thread Sven Brauch
https://bugs.kde.org/show_bug.cgi?id=363269 Sven Brauch changed: What|Removed |Added Latest Commit|54c2740ae97f4e3ee7675ff06ec |https://commits.kde.org/kde |5a

[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken, CMakeListsParser::readCMakeFile]

2017-07-26 Thread Axel Kellermann
https://bugs.kde.org/show_bug.cgi?id=363269 --- Comment #32 from Axel Kellermann --- (In reply to Sven Brauch from comment #31) > Ah yes, if you trick the mimetype detection, you will still crash. You are > also right about strncpy. > > phabricator should be simple enough to use, just log in (wi

[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken, CMakeListsParser::readCMakeFile]

2017-07-25 Thread Sven Brauch
https://bugs.kde.org/show_bug.cgi?id=363269 --- Comment #31 from Sven Brauch --- Ah yes, if you trick the mimetype detection, you will still crash. You are also right about strncpy. phabricator should be simple enough to use, just log in (with identity.kde.org), click differential, then click ne

[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken, CMakeListsParser::readCMakeFile]

2017-07-25 Thread Axel Kellermann
https://bugs.kde.org/show_bug.cgi?id=363269 --- Comment #30 from Axel Kellermann --- (In reply to Sven Brauch from comment #28) > Patch still looks sensible to me -- maybe use strncpy instead, and put it on > phabricator.kde.org so somebody familiar with the code can have a look? strncpy()/strnd

[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken, CMakeListsParser::readCMakeFile]

2017-07-25 Thread Axel Kellermann
https://bugs.kde.org/show_bug.cgi?id=363269 --- Comment #29 from Axel Kellermann --- (In reply to Sven Brauch from comment #27) > Does that still happen with KDevelop 5.1+? I thought I fixed it. See comment #22. Random .txt files aren't scanned anymore, but .cmake files can still trigger the fau

[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken, CMakeListsParser::readCMakeFile]

2017-07-25 Thread Sven Brauch
https://bugs.kde.org/show_bug.cgi?id=363269 --- Comment #28 from Sven Brauch --- Patch still looks sensible to me -- maybe use strncpy instead, and put it on phabricator.kde.org so somebody familiar with the code can have a look? -- You are receiving this mail because: You are watching all bug

[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken, CMakeListsParser::readCMakeFile]

2017-07-25 Thread Sven Brauch
https://bugs.kde.org/show_bug.cgi?id=363269 --- Comment #27 from Sven Brauch --- Does that still happen with KDevelop 5.1+? I thought I fixed it. -- You are receiving this mail because: You are watching all bug changes.

[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken, CMakeListsParser::readCMakeFile]

2017-07-25 Thread Axel Kellermann
https://bugs.kde.org/show_bug.cgi?id=363269 --- Comment #26 from Axel Kellermann --- I had another look at the lexer and I think I pinned down the problem with UTF-16 files in cmListFileLexer.c. Scanning the files works fine, but copying the scanned content into the token structure in cmListFileL

[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken, CMakeListsParser::readCMakeFile]

2017-07-25 Thread Axel Kellermann
https://bugs.kde.org/show_bug.cgi?id=363269 --- Comment #25 from Axel Kellermann --- Created attachment 106866 --> https://bugs.kde.org/attachment.cgi?id=106866&action=edit Proposal for patch -- You are receiving this mail because: You are watching all bug changes.

[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken, CMakeListsParser::readCMakeFile]

2017-07-25 Thread Axel Kellermann
https://bugs.kde.org/show_bug.cgi?id=363269 --- Comment #24 from Axel Kellermann --- Created attachment 106865 --> https://bugs.kde.org/attachment.cgi?id=106865&action=edit Minimal UTF-16 file to trigger behavior -- You are receiving this mail because: You are watching all bug changes.

[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken, CMakeListsParser::readCMakeFile]

2016-11-17 Thread Kevin Funk
https://bugs.kde.org/show_bug.cgi?id=363269 Kevin Funk changed: What|Removed |Added CC||asiasuppenes...@gmx.de --- Comment #23 from Kevin

[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken, CMakeListsParser::readCMakeFile]

2016-11-17 Thread Kevin Funk
https://bugs.kde.org/show_bug.cgi?id=363269 Kevin Funk changed: What|Removed |Added Summary|Crash when projects |Crash when projects |contains *.