https://bugs.kde.org/show_bug.cgi?id=183625
Kevin Funk <kf...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
Latest Commit| |http://commits.kde.org/kdev
| |platform/a9f2f45554a618d69d
| |ee65f1b16f4d6ef1a4eea0
--- Comment #3 from Kevin Funk <kf...@kde.org> ---
Git commit a9f2f45554a618d69dee65f1b16f4d6ef1a4eea0 by Kevin Funk, on behalf of
Artur Puzio.
Committed on 01/02/2016 at 23:15.
Pushed by kfunk into branch '5.0'.
Vcs: Fix sorting of files in the commit dialog
Summary:
This fixes [[ https://bugs.kde.org/show_bug.cgi?id=183625 | Bug 183625 ]]
In the commit dialog files whern't sorted. They are showed using
VcsFileCHangesModel. I overloaded `operator <` of `VcsStatusInfoItem` to sort
them. The sorting rules are:
1. versioned files before uneversioned
2. alphabetically (by path)
Details:
Added possibility to access the state of file in `VcsFileChangesModel` (not
used in the end)
Introduced `enum ColumnsRoles` in `VcsFileChangesModel`: `{ PathColumn = 0,
StatusColumn = 1 }` (not used in the end)
Overloaded `operator <` of `VcsStatusInfoItem` to compare according to the
rules
Used `QSortFilterProxyModel` in patchreviewtoolview to sort the list of changed
files
Test Plan: Manually testing revealed no problems.
Reviewers: kfunk
Subscribers: kdevelop-devel
Differential Revision: https://phabricator.kde.org/D862
M +5 -1 plugins/patchreview/patchreviewtoolview.cpp
M +3 -0 plugins/patchreview/patchreviewtoolview.h
M +20 -1 vcs/models/vcsfilechangesmodel.cpp
M +15 -1 vcs/models/vcsfilechangesmodel.h
http://commits.kde.org/kdevplatform/a9f2f45554a618d69dee65f1b16f4d6ef1a4eea0
--
You are receiving this mail because:
You are watching all bug changes.
