https://bugs.kde.org/show_bug.cgi?id=486951
--- Comment #14 from Yaroslav Sidlovsky ---
Looks good. Thanks!
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=486951
--- Comment #13 from Hamed Masafi ---
Ok; you're right. please check out new commit
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=486951
--- Comment #12 from Yaroslav Sidlovsky ---
Also in my example it's this is taken into account and name is taken from ref
name `refs/tags/`:
```
mName = QString(refName).remove(QRegularExpression("^refs/tags/"));
```
--
You are receiving this mail
https://bugs.kde.org/show_bug.cgi?id=486951
--- Comment #11 from Yaroslav Sidlovsky ---
But it has name and displayed for example with `git log` or `tig`.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=486951
--- Comment #10 from Hamed Masafi ---
Yes, because it doesn't has name, isn't logical?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=486951
--- Comment #9 from Yaroslav Sidlovsky ---
Almost good but tag names is not displayed.
You can test it with this git repo:
```
1. mkdir /tmp/git && cd /tmp/git
2. git init
3. touch README.md && git add README.md && git commit -m 1
4. git tag some_tag
https://bugs.kde.org/show_bug.cgi?id=486951
Hamed Masafi changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
Resolution|---
https://bugs.kde.org/show_bug.cgi?id=486951
--- Comment #7 from Yaroslav Sidlovsky ---
If `git_tag_lookup` fails to find tag - you can use `git_commit_lookup` to get
commit info.
And later create `Tag` class instance from the commit, something like that:
```
Tag::Tag(const char *refName,
https://bugs.kde.org/show_bug.cgi?id=486951
Hamed Masafi changed:
What|Removed |Added
Status|REPORTED|ASSIGNED
Ever confirmed|0
https://bugs.kde.org/show_bug.cgi?id=486951
Yaroslav Sidlovsky changed:
What|Removed |Added
Summary|Crash when opening GIT |Crash when opening GIT
https://bugs.kde.org/show_bug.cgi?id=486951
--- Comment #5 from Yaroslav Sidlovsky ---
Some light on situation that `git_tag_lookup` is not working for all tags:
git_tag_lookup only works for annotated tags:
https://github.com/libgit2/libgit2/issues/5586
> git_tag_lookup to emphasise that this
https://bugs.kde.org/show_bug.cgi?id=486951
--- Comment #4 from Yaroslav Sidlovsky ---
P.S. After applying the patch console shows this errors:
```
libgit2 error: the requested type does not match the type in the ODB
libgit2 error: the requested type does not match the type in the ODB
libgit2
https://bugs.kde.org/show_bug.cgi?id=486951
Yaroslav Sidlovsky changed:
What|Removed |Added
URL||https://bugzilla.redhat.com
https://bugs.kde.org/show_bug.cgi?id=486951
--- Comment #3 from Yaroslav Sidlovsky ---
Created attachment 169431
--> https://bugs.kde.org/attachment.cgi?id=169431=edit
kommit-fix-crash.patch
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=486951
--- Comment #2 from Yaroslav Sidlovsky ---
After some debugging it turns out that crash happens because return value from
function `git_tag_lookup` is ignored it is non zero.
I'm talking about this line of code:
https://bugs.kde.org/show_bug.cgi?id=486951
--- Comment #1 from Yaroslav Sidlovsky ---
Created attachment 169430
--> https://bugs.kde.org/attachment.cgi?id=169430=edit
GDB backtrace
--
You are receiving this mail because:
You are watching all bug changes.
16 matches
Mail list logo
