https://bugs.kde.org/show_bug.cgi?id=420820
Ahmad Samir changed:
What|Removed |Added
Status|REOPENED|RESOLVED
Resolution|---
https://bugs.kde.org/show_bug.cgi?id=420820
--- Comment #18 from Ahmad Samir ---
Git commit 8a282319bc9eb6dd73557319cbd59d279493cdab by Ahmad Samir.
Committed on 04/05/2020 at 21:59.
Pushed by ahmadsamir into branch 'master'.
[KBookmarkMenu] Assign m_actionCollection early to prevent crash
https://bugs.kde.org/show_bug.cgi?id=420820
--- Comment #17 from Ahmad Samir ---
Proposed fix https://phabricator.kde.org/D29427
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=420820
--- Comment #16 from Ahmad Samir ---
Discussing the issue with kossebau on IRC, I was completely wrong about the
deprecation stuff, so please disregard. He investigated the issue further and
found the critter causing it:
https://bugs.kde.org/show_bug.cgi?id=420820
--- Comment #15 from Christoph Feck ---
If deprecated API was disabled, but still used, it should indeed have caused a
compilation error.
If it's not disabled, deprecated API needs to work as long as it isn't removed
in the next ABI incompatible
https://bugs.kde.org/show_bug.cgi?id=420820
--- Comment #14 from Ahmad Samir ---
Konsole 20.04 built against 5.68 will have selected the path in the code that
depends on KBookmarks creating a KActionCollection. KBookmarks-5.70 does create
an action collection, so konsole should work without
https://bugs.kde.org/show_bug.cgi?id=420820
--- Comment #13 from Rik Mills ---
- Konsole 20.04.0 in Ubuntu 20.10 archive built against 5.68 in the Ubuntu
20.04 Groovy archive, does not crash.
- The same Konsole 20.04.0 in Ubuntu 20.10 archive DOES crash when frameworks
is upgraded to 5.70 form
https://bugs.kde.org/show_bug.cgi?id=420820
Rik Mills changed:
What|Removed |Added
Priority|NOR |HI
--
You are receiving this mail because:
You
https://bugs.kde.org/show_bug.cgi?id=420820
--- Comment #12 from Rik Mills ---
Yes, Konsole 19.12.3 does not crash with Frameworks 5.70. Konsole 20.04.0 DOES
crash.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=420820
--- Comment #11 from Michael Marley ---
Rik just put KF5 5.70 in the -staging PPA, but Konsole is still crashing on
start for me.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=420820
--- Comment #10 from Ahmad Samir ---
Thinking about this some more, I think the proper fix is to patch
kbookmarks-5.69 with
https://cgit.kde.org/kbookmarks.git/commit/?id=4b3fc2aedd86505a47b9b185e086ef253e73ede8
; IIUC, Rik Mills can handle the PPA.
https://bugs.kde.org/show_bug.cgi?id=420820
Ahmad Samir changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|NOT A BUG
https://bugs.kde.org/show_bug.cgi?id=420820
--- Comment #8 from Rik Mills ---
FYI 5.69 was built for focal in the staging PPA, but not shipped as it was too
late to get in. We thought it might be good for early backports, but Nate
suggested skipping 5.69 to wait for 5.70 for groovy and focal
https://bugs.kde.org/show_bug.cgi?id=420820
--- Comment #7 from Christoph Feck ---
Well, frameworks are supposed to be compatible. The only "allowed" crash is if
you build Konsole against 5.69, but then run it against 5.68.
If you build Konsole against 5.68, it must work with 5.68 and 5.69.
--
https://bugs.kde.org/show_bug.cgi?id=420820
Michael Marley changed:
What|Removed |Added
Resolution|--- |NOT A BUG
Status|REPORTED
https://bugs.kde.org/show_bug.cgi?id=420820
--- Comment #5 from Ahmad Samir ---
I preface this by saying I've never run ubuntu before, so.
It seems to me you're installing konsole 20.04 from groovy ppa, but
kbookmarks-5.69 comes from "focal" ppa? is that supposed to work?
--
You are receiving
https://bugs.kde.org/show_bug.cgi?id=420820
Nate Graham changed:
What|Removed |Added
CC||n...@kde.org
--
You are receiving this mail
https://bugs.kde.org/show_bug.cgi?id=420820
--- Comment #4 from Rik Mills ---
(In reply to Ahmad Samir from comment #3)
I tried to reproduce the issue in a vm, but
> couldn't install the updates from the ppa (I am not an ubuntu user, so I
> don't know the quirks to get stuff to install there).
https://bugs.kde.org/show_bug.cgi?id=420820
--- Comment #3 from Ahmad Samir ---
Looking at the backtrace, my guess would be it's crashing when trying to access
the bookmarkAction pointer in:
if (bookmarkAction->shortcut() == QKeySequence(Konsole::ACCEL + Qt::Key_B))
{
https://bugs.kde.org/show_bug.cgi?id=420820
Rik Mills changed:
What|Removed |Added
CC||rikmi...@kde.org
--
You are receiving this mail
https://bugs.kde.org/show_bug.cgi?id=420820
Kurt Hindenburg changed:
What|Removed |Added
CC||a.samir...@gmail.com
--
You are receiving
https://bugs.kde.org/show_bug.cgi?id=420820
--- Comment #2 from Kurt Hindenburg ---
Ahmad, could you look at this?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=420820
--- Comment #1 from Michael Marley ---
It looks like the crash is probably related to
https://github.com/KDE/konsole/commit/6db7f8d2593ccb0238b2b547ed6eaf7da6a26c4c.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=420820
Michael Marley changed:
What|Removed |Added
CC||mich...@michaelmarley.com
--
You are
24 matches
Mail list logo
