https://bugs.kde.org/show_bug.cgi?id=438435

tomtomtomreportin...@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomtomtomreportingin@gmail.
                   |                            |com
             Status|REPORTED                    |CONFIRMED
     Ever confirmed|0                           |1

--- Comment #1 from tomtomtomreportin...@gmail.com ---
>From what I can tell, the current implementation of expanding spacers is hacky
and basically doesn't allow more than two expanding spacers across two toolbars
to be displayed properly.

Right now expanding spacers are implemented as pseudo-actions:
https://invent.kde.org/graphics/krita/-/commit/e15a086bfc581a1f64ee803e87eb3ee067c60bd4

Upon further investigations, I noticed that modern versions of Dolphin and Kate
have proper expanding spacers despite using the same toolbar framework as
Krita.

I am going to guess that they use some newer version of KXMLGUI or in some
other way applied the following commit to their project:
https://phabricator.kde.org/R263:4357ef235ecb8b8b71ca0867d6cfc02acf292fae

Differential revision: https://phabricator.kde.org/D22609

Along with the fact that it could be used limitlessly, it would also no longer
be treated like an action in other parts of Krita.

Question to the maintainer: Would it be possible to replace the current
implementation with the implementation used in the above commit? I do not know
if there were additional improvements to the above implementation or how
cleanly it would replace the current spacer used in the default BrushesAndStuff
toolbar.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to