[krita] [Bug 472464] Vertical baseline is different when using inline-size

2023-08-07 Thread wolthera
https://bugs.kde.org/show_bug.cgi?id=472464 wolthera changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap

[krita] [Bug 472464] Vertical baseline is different when using inline-size

2023-08-07 Thread wolthera
https://bugs.kde.org/show_bug.cgi?id=472464 wolthera changed: What|Removed |Added Status|REOPENED|RESOLVED Latest

[krita] [Bug 472464] Vertical baseline is different when using inline-size

2023-08-07 Thread Alvin Wong
https://bugs.kde.org/show_bug.cgi?id=472464 --- Comment #15 from Alvin Wong --- Created attachment 160795 --> https://bugs.kde.org/attachment.cgi?id=160795=edit Screenshot with patch attachment 160791 applied (In reply to wolthera from comment #14) > Created attachment 160791 [details] >

[krita] [Bug 472464] Vertical baseline is different when using inline-size

2023-08-07 Thread wolthera
https://bugs.kde.org/show_bug.cgi?id=472464 --- Comment #14 from wolthera --- Created attachment 160791 --> https://bugs.kde.org/attachment.cgi?id=160791=edit blind patch that may fix the issue Alvin, can you apply this diff and see if it helps? It's a bit of a blind implementation, but if

[krita] [Bug 472464] Vertical baseline is different when using inline-size

2023-08-07 Thread wolthera
https://bugs.kde.org/show_bug.cgi?id=472464 wolthera changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

[krita] [Bug 472464] Vertical baseline is different when using inline-size

2023-08-07 Thread Alvin Wong
https://bugs.kde.org/show_bug.cgi?id=472464 --- Comment #12 from Alvin Wong --- Created attachment 160789 --> https://bugs.kde.org/attachment.cgi?id=160789=edit Test with step 6 disabled Disabling step 6 with base commit 5dce46d2f6 gives me this. -- You are receiving this mail because: You

[krita] [Bug 472464] Vertical baseline is different when using inline-size

2023-08-07 Thread wolthera
https://bugs.kde.org/show_bug.cgi?id=472464 --- Comment #11 from wolthera --- (In reply to Alvin Wong from comment #10) > The linked commits didn't fix the issue, did they? Here the text is still > being rendered exactly the same as the screenshot. Uh, they fixed the offset I saw. If you could

[krita] [Bug 472464] Vertical baseline is different when using inline-size

2023-08-07 Thread Alvin Wong
https://bugs.kde.org/show_bug.cgi?id=472464 --- Comment #10 from Alvin Wong --- The linked commits didn't fix the issue, did they? Here the text is still being rendered exactly the same as the screenshot. -- You are receiving this mail because: You are watching all bug changes.

[krita] [Bug 472464] Vertical baseline is different when using inline-size

2023-08-06 Thread wolthera
https://bugs.kde.org/show_bug.cgi?id=472464 --- Comment #9 from wolthera --- Git commit f0c0e7c45479a87f8996f0313acc427d74ef2ce9 by Wolthera van Hövell, on behalf of Wolthera van Hövell tot Westerflier. Committed on 06/08/2023 at 20:49. Pushed by woltherav into branch 'krita/5.2'. Fix text-top

[krita] [Bug 472464] Vertical baseline is different when using inline-size

2023-08-06 Thread wolthera
https://bugs.kde.org/show_bug.cgi?id=472464 wolthera changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap

[krita] [Bug 472464] Vertical baseline is different when using inline-size

2023-08-06 Thread wolthera
https://bugs.kde.org/show_bug.cgi?id=472464 --- Comment #7 from wolthera --- ok, the lines where we're losing our 'incorrect' vertical-align is at the resolution of the absolute X and Y post (step 6), particularly when trying to compensate for the relative dx and dy (step 4)... which would make

[krita] [Bug 472464] Vertical baseline is different when using inline-size

2023-08-06 Thread wolthera
https://bugs.kde.org/show_bug.cgi?id=472464 --- Comment #6 from wolthera --- ok, when using vertical-align/alignment-baseline as the css-spec expects me to (on a subchunk with different font(either by size or family)) everything works as expected. When using vertical-align:alphabetic on the

[krita] [Bug 472464] Vertical baseline is different when using inline-size

2023-08-06 Thread wolthera
https://bugs.kde.org/show_bug.cgi?id=472464 --- Comment #5 from wolthera --- Git commit 1a500747693dc535bbe1d946671e3c25d628f94f by Wolthera van Hövell tot Westerflier. Committed on 06/08/2023 at 18:45. Pushed by woltherav into branch 'master'. Fix text-top and text-bottom alignment baselines.

[krita] [Bug 472464] Vertical baseline is different when using inline-size

2023-08-06 Thread wolthera
https://bugs.kde.org/show_bug.cgi?id=472464 wolthera changed: What|Removed |Added Resolution|--- |FIXED Latest Commit|

[krita] [Bug 472464] Vertical baseline is different when using inline-size

2023-08-06 Thread wolthera
https://bugs.kde.org/show_bug.cgi?id=472464 --- Comment #3 from wolthera --- Inkscape seems to be having a similar problem, which might be caused by inkscape aligning inline-size incorrectly when using transforms to begin with, so that's a dead end... bounding boxes seem to be exactly the same.

[krita] [Bug 472464] Vertical baseline is different when using inline-size

2023-08-06 Thread wolthera
https://bugs.kde.org/show_bug.cgi?id=472464 wolthera changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED

[krita] [Bug 472464] Vertical baseline is different when using inline-size

2023-07-21 Thread Alvin Wong
https://bugs.kde.org/show_bug.cgi?id=472464 Alvin Wong changed: What|Removed |Added CC||griffinval...@gmail.com -- You are receiving

[krita] [Bug 472464] Vertical baseline is different when using inline-size

2023-07-21 Thread Alvin Wong
https://bugs.kde.org/show_bug.cgi?id=472464 --- Comment #1 from Alvin Wong --- Created attachment 160424 --> https://bugs.kde.org/attachment.cgi?id=160424=edit Screenshot -- You are receiving this mail because: You are watching all bug changes.