[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2018-02-27 Thread Tn
https://bugs.kde.org/show_bug.cgi?id=384267 Tn changed: What|Removed |Added CC||whyeven3...@outlook.com --- Comment #13 from Tn --- I jus

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2018-02-27 Thread Tn
https://bugs.kde.org/show_bug.cgi?id=384267 Tn changed: What|Removed |Added OS|Linux |All Version|1.0.0 |1.3.2

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-01 Thread Frank Myhr
https://bugs.kde.org/show_bug.cgi?id=384267 Frank Myhr changed: What|Removed |Added CC||fm...@fhmtech.com -- You are receiving this mail

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-01 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=384267 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org Severity|normal

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-01 Thread Frank Myhr
https://bugs.kde.org/show_bug.cgi?id=384267 --- Comment #2 from Frank Myhr --- @Albert Astals Cid: You're right, I didn't think of that as I don't personally use dark themes. Hmm... how about using system Selection Background color for the found text highlight, and its inverse color to draw a bo

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-01 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=384267 --- Comment #3 from Albert Astals Cid --- Let's get the border around and then we can discuss if adding options to tweak it makes sense -- You are receiving this mail because: You are watching all bug changes.

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-01 Thread Oliver Sander
https://bugs.kde.org/show_bug.cgi?id=384267 Oliver Sander changed: What|Removed |Added CC||oliver.san...@tu-dresden.de --- Comment #4 from

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-01 Thread Frank Myhr
https://bugs.kde.org/show_bug.cgi?id=384267 --- Comment #5 from Frank Myhr --- @Oliver Sander: Cool patch! I agree, color selection is now seeming more complicated than it first appeared. I began wondering about a dotted- or dashed-line border with, say, alternating dark and light pixels. But tha

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-01 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=384267 --- Comment #6 from Albert Astals Cid --- (In reply to Oliver Sander from comment #4) > True, I was going to send a patch for that. Adding the border is now simply > > diff --git a/ui/pagepainter.cpp b/ui/pagepainter.cpp > index 047220f95..94429af93 1

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-02 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=384267 Nate Graham changed: What|Removed |Added CC||pointedst...@zoho.com -- You are receiving this

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-02 Thread Oliver Sander
https://bugs.kde.org/show_bug.cgi?id=384267 --- Comment #7 from Oliver Sander --- No need for KColorUtils, QColor has 'darken' natively. Feel free to play with the parameter. Patch is at https://git.reviewboard.kde.org/r/130238/ -- You are receiving this mail because: You are watching all

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-02 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=384267 --- Comment #8 from Nate Graham --- Reviewboard is going away soon. Can you upload your to our Phabricator instance? https://phabricator.kde.org -- You are receiving this mail because: You are watching all bug changes.

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-02 Thread Oliver Sander
https://bugs.kde.org/show_bug.cgi?id=384267 --- Comment #9 from Oliver Sander --- https://phabricator.kde.org/D7662 -- You are receiving this mail because: You are watching all bug changes.

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-02 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=384267 Nate Graham changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-02 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=384267 --- Comment #11 from Albert Astals Cid --- I don't think that's going to work, i'm 92.46% sure that BUG: needs to be at the beginning of the line at alone, not in a sentence like you wrote it. -- You are receiving this mail because: You are watching a

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-02 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=384267 --- Comment #12 from Nate Graham --- Ah, thanks Albert. Changed. -- You are receiving this mail because: You are watching all bug changes.

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2020-09-07 Thread SarenT
https://bugs.kde.org/show_bug.cgi?id=384267 SarenT changed: What|Removed |Added CC||sarentasci...@hotmail.com --- Comment #16 from SarenT

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2020-11-29 Thread David Hurka
https://bugs.kde.org/show_bug.cgi?id=384267 David Hurka changed: What|Removed |Added See Also||https://bugs.kde.org/show_b |

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2019-02-05 Thread David Hurka
https://bugs.kde.org/show_bug.cgi?id=384267 --- Comment #14 from David Hurka --- (In reply to Albert Astals Cid from comment #1) > No, that solution doesn't work, because people that use dark themes (where > selection is usually a white-ish color) would not see the selection when > reading PDFs (

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2019-02-05 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=384267 --- Comment #15 from Albert Astals Cid --- (In reply to David Hurka from comment #14) > No my problem with Okular is different to yours. Text selection (using Text > Selection mode) makes text invisible, because PDFs use black text. I need to > change t

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2020-01-28 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=384267 Nate Graham changed: What|Removed |Added See Also||https://bugs.kde.org/show_b |

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2022-06-16 Thread Luca Manganelli
https://bugs.kde.org/show_bug.cgi?id=384267 Luca Manganelli changed: What|Removed |Added CC||luc...@gmail.com --- Comment #19 from Luca Ma

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2022-05-22 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=384267 acryl...@gmail.com changed: What|Removed |Added CC||acryl...@gmail.com -- You are receiving th

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2021-10-02 Thread Paul Preney
https://bugs.kde.org/show_bug.cgi?id=384267 Paul Preney changed: What|Removed |Added CC||p...@preney.ca --- Comment #17 from Paul Preney

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2021-10-02 Thread Paul Preney
https://bugs.kde.org/show_bug.cgi?id=384267 --- Comment #18 from Paul Preney --- I missed mentioning I am using Okular v21.08.1 --but all past versions also have these issues. -- You are receiving this mail because: You are watching all bug changes.

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2018-02-27 Thread Tn
https://bugs.kde.org/show_bug.cgi?id=384267 Tn changed: What|Removed |Added CC||whyeven3...@outlook.com --- Comment #13 from Tn --- I jus

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2018-02-27 Thread Tn
https://bugs.kde.org/show_bug.cgi?id=384267 Tn changed: What|Removed |Added OS|Linux |All Version|1.0.0 |1.3.2

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-01 Thread Frank Myhr
https://bugs.kde.org/show_bug.cgi?id=384267 Frank Myhr changed: What|Removed |Added CC||fm...@fhmtech.com -- You are receiving this mail

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-01 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=384267 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org Severity|normal

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-01 Thread Frank Myhr
https://bugs.kde.org/show_bug.cgi?id=384267 --- Comment #2 from Frank Myhr --- @Albert Astals Cid: You're right, I didn't think of that as I don't personally use dark themes. Hmm... how about using system Selection Background color for the found text highlight, and its inverse color to draw a bo

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-01 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=384267 --- Comment #3 from Albert Astals Cid --- Let's get the border around and then we can discuss if adding options to tweak it makes sense -- You are receiving this mail because: You are watching all bug changes.

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-01 Thread Oliver Sander
https://bugs.kde.org/show_bug.cgi?id=384267 Oliver Sander changed: What|Removed |Added CC||oliver.san...@tu-dresden.de --- Comment #4 from

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-01 Thread Frank Myhr
https://bugs.kde.org/show_bug.cgi?id=384267 --- Comment #5 from Frank Myhr --- @Oliver Sander: Cool patch! I agree, color selection is now seeming more complicated than it first appeared. I began wondering about a dotted- or dashed-line border with, say, alternating dark and light pixels. But tha

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-01 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=384267 --- Comment #6 from Albert Astals Cid --- (In reply to Oliver Sander from comment #4) > True, I was going to send a patch for that. Adding the border is now simply > > diff --git a/ui/pagepainter.cpp b/ui/pagepainter.cpp > index 047220f95..94429af93 1

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-02 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=384267 Nate Graham changed: What|Removed |Added CC||pointedst...@zoho.com -- You are receiving this

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-02 Thread Oliver Sander
https://bugs.kde.org/show_bug.cgi?id=384267 --- Comment #7 from Oliver Sander --- No need for KColorUtils, QColor has 'darken' natively. Feel free to play with the parameter. Patch is at https://git.reviewboard.kde.org/r/130238/ -- You are receiving this mail because: You are watching all

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-02 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=384267 --- Comment #8 from Nate Graham --- Reviewboard is going away soon. Can you upload your to our Phabricator instance? https://phabricator.kde.org -- You are receiving this mail because: You are watching all bug changes.

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-02 Thread Oliver Sander
https://bugs.kde.org/show_bug.cgi?id=384267 --- Comment #9 from Oliver Sander --- https://phabricator.kde.org/D7662 -- You are receiving this mail because: You are watching all bug changes.

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-02 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=384267 Nate Graham changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-02 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=384267 --- Comment #11 from Albert Astals Cid --- I don't think that's going to work, i'm 92.46% sure that BUG: needs to be at the beginning of the line at alone, not in a sentence like you wrote it. -- You are receiving this mail because: You are watching a

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-02 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=384267 --- Comment #12 from Nate Graham --- Ah, thanks Albert. Changed. -- You are receiving this mail because: You are watching all bug changes.