[plasmashell] [Bug 397338] No favorites displayed with empty config

2018-08-22 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=397338 Fabian Vogt changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED

[plasmashell] [Bug 397338] No favorites displayed with empty config

2018-08-14 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=397338 Fabian Vogt changed: What|Removed |Added URL||https://phabricator.kde.org |

[plasmashell] [Bug 397338] No favorites displayed with empty config

2018-08-13 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=397338 --- Comment #3 from Fabian Vogt --- The cause is that methods with a QVariant as a parameter type called from js always get a QJSValue as QVariant. Even passing trivial types such as integers results in a QVariant with a QJSValue in it. Fix is to use

[plasmashell] [Bug 397338] No favorites displayed with empty config

2018-08-11 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=397338 Fabian Vogt changed: What|Removed |Added Assignee|k...@davidedmundson.co.uk|notm...@gmail.com --- Comment #2 from Fabian

[plasmashell] [Bug 397338] No favorites displayed with empty config

2018-08-11 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=397338 --- Comment #1 from Fabian Vogt --- This is caused by the KAStatsFavoritesModel emitting favoritesChanged before the migration started. Kickoff then writes that data back into the configuration file. Is that necessary? Thread 1 "plasmashell" hit