[systemsettings] [Bug 403557] UTF-8 characters are not saved correctly using the implicit path configuration module

2019-02-20 Thread Jos van den Oever
https://bugs.kde.org/show_bug.cgi?id=403557 Jos van den Oever changed: What|Removed |Added Status|CONFIRMED |RESOLVED Latest Commit|

[systemsettings] [Bug 403557] UTF-8 characters are not saved correctly using the implicit path configuration module

2019-02-19 Thread Jos van den Oever
https://bugs.kde.org/show_bug.cgi?id=403557 --- Comment #15 from Jos van den Oever --- Most distributions do. The first answer on this question affirms that assuming UTF-8 is generally safe. https://unix.stackexchange.com/questions/2089/what-charset-encoding-is-used-for-filenames-and-paths-on-l

[systemsettings] [Bug 403557] UTF-8 characters are not saved correctly using the implicit path configuration module

2019-02-18 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=403557 David Faure changed: What|Removed |Added CC||fa...@kde.org --- Comment #14 from David Faure -

[systemsettings] [Bug 403557] UTF-8 characters are not saved correctly using the implicit path configuration module

2019-02-17 Thread Jos van den Oever
https://bugs.kde.org/show_bug.cgi?id=403557 --- Comment #13 from Jos van den Oever --- Even though KConfig should not be used by globalpaths.cpp, KConfig can be improved. https://phabricator.kde.org/D19107 does that. But note that while the bug described here will probably go away for the repor

[systemsettings] [Bug 403557] UTF-8 characters are not saved correctly using the implicit path configuration module

2019-02-17 Thread Jos van den Oever
https://bugs.kde.org/show_bug.cgi?id=403557 --- Comment #12 from Jos van den Oever --- xdg-user-dirs documentation says: "This file is in a shell format, so its easy to access from a shell script." https://www.freedesktop.org/wiki/Software/xdg-user-dirs/ The tool xdg-user-dirs does not assume

[systemsettings] [Bug 403557] UTF-8 characters are not saved correctly using the implicit path configuration module

2019-02-17 Thread Jos van den Oever
https://bugs.kde.org/show_bug.cgi?id=403557 --- Comment #11 from Jos van den Oever --- globalpaths.cpp should not use KConfig to write user-dirs.dirs KConfig escapes bytes >= 127. Improving that so that it does not escape UTF8 would be nice, but it would only solve this issue for users with UTF8

[systemsettings] [Bug 403557] UTF-8 characters are not saved correctly using the implicit path configuration module

2019-02-17 Thread Viorel-Cătălin Răpițeanu
https://bugs.kde.org/show_bug.cgi?id=403557 --- Comment #10 from Viorel-Cătălin Răpițeanu --- (In reply to Jos van den Oever from comment #8) > "Téléchargements" is escaped on saving. That is fine. But it should be > unescaped when loading. This happens in the test, but not in > plasma-desktop/kc

[systemsettings] [Bug 403557] UTF-8 characters are not saved correctly using the implicit path configuration module

2019-02-17 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=403557 --- Comment #9 from Albert Astals Cid --- (In reply to Jos van den Oever from comment #8) > I've just written a test to recreate the issue. > > void KConfigTest::testQStringUtf8() > { > QTemporaryFile file; > QVERIFY(file.open()); > KConfig

[systemsettings] [Bug 403557] UTF-8 characters are not saved correctly using the implicit path configuration module

2019-02-17 Thread Jos van den Oever
https://bugs.kde.org/show_bug.cgi?id=403557 --- Comment #8 from Jos van den Oever --- I've just written a test to recreate the issue. void KConfigTest::testQStringUtf8() { QTemporaryFile file; QVERIFY(file.open()); KConfig config(file.fileName(), KConfig::SimpleConfig); KConfigGr

[systemsettings] [Bug 403557] UTF-8 characters are not saved correctly using the implicit path configuration module

2019-02-17 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=403557 --- Comment #7 from Albert Astals Cid --- i think the problem here is that you're escaping a string that people don't expect to be escaped, so when Qt reads it back it breaks. Why did you decided to escape anything bigger than 127 though? that's perfec

[systemsettings] [Bug 403557] UTF-8 characters are not saved correctly using the implicit path configuration module

2019-02-17 Thread Jos van den Oever
https://bugs.kde.org/show_bug.cgi?id=403557 --- Comment #6 from Jos van den Oever --- Got a reply now. https://lxr.kde.org/source/kde/workspace/plasma-desktop/kcms/desktoppaths/globalpaths.cpp -- You are receiving this mail because: You are watching all bug changes.

[systemsettings] [Bug 403557] UTF-8 characters are not saved correctly using the implicit path configuration module

2019-02-17 Thread Jos van den Oever
https://bugs.kde.org/show_bug.cgi?id=403557 --- Comment #5 from Jos van den Oever --- The information for folder preferences is written to $HOME/.config/user-dirs.dirs I've tried to recreate the bug by renaming my Downloads folder to Téléchargements. This gave me ``` XDG_DOWNLOAD_DIR="$HOME/Télé

[systemsettings] [Bug 403557] UTF-8 characters are not saved correctly using the implicit path configuration module

2019-02-16 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=403557 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org, |

[systemsettings] [Bug 403557] UTF-8 characters are not saved correctly using the implicit path configuration module

2019-02-16 Thread Viorel-Cătălin Răpițeanu
https://bugs.kde.org/show_bug.cgi?id=403557 Viorel-Cătălin Răpițeanu changed: What|Removed |Added Version|5.14.90 |5.15.0 -- You are receiving this ma

[systemsettings] [Bug 403557] UTF-8 characters are not saved correctly using the implicit path configuration module

2019-02-15 Thread Viorel-Cătălin Răpițeanu
https://bugs.kde.org/show_bug.cgi?id=403557 --- Comment #3 from Viorel-Cătălin Răpițeanu --- D17651 is the cause of this regression. -- You are receiving this mail because: You are watching all bug changes.

[systemsettings] [Bug 403557] UTF-8 characters are not saved correctly using the implicit path configuration module

2019-01-24 Thread Christophe Giboudeaux
https://bugs.kde.org/show_bug.cgi?id=403557 Christophe Giboudeaux changed: What|Removed |Added Status|REPORTED|CONFIRMED CC|

[systemsettings] [Bug 403557] UTF-8 characters are not saved correctly using the implicit path configuration module

2019-01-24 Thread Viorel-Cătălin Răpițeanu
https://bugs.kde.org/show_bug.cgi?id=403557 --- Comment #1 from Viorel-Cătălin Răpițeanu --- Video of the described issue: https://drive.google.com/open?id=1OnMYnry8tabB-JqoOuCPb53R_XCNEYAU -- You are receiving this mail because: You are watching all bug changes.