[systemsettings] [Bug 417493] Light GTK theme doesn't override gtk-application-prefer-dark-theme

2020-02-13 Thread Frederick Zhang
https://bugs.kde.org/show_bug.cgi?id=417493 --- Comment #10 from Frederick Zhang --- ...will gtk-application-prefer-dark-theme be set to *false*... Typo, sorry -- You are receiving this mail because: You are watching all bug changes.

[systemsettings] [Bug 417493] Light GTK theme doesn't override gtk-application-prefer-dark-theme

2020-02-13 Thread Frederick Zhang
https://bugs.kde.org/show_bug.cgi?id=417493 --- Comment #9 from Frederick Zhang --- > since it's a color-scheme-aware theme Ah, my bad. I thought the current Breeze was simply a light variant of the theme. Guess it has caused some misunderstandings, sorry! And yes, I reckon we are on the same pa

[systemsettings] [Bug 417493] Light GTK theme doesn't override gtk-application-prefer-dark-theme

2020-02-13 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=417493 --- Comment #8 from Nate Graham --- That makes sense to me. So basically: 1. When using the Breeze GTK theme, set gtk-application-prefer-dark-theme based on the colors of the color scheme, since it's a color-scheme-aware theme. 2. When using the Breeze

[systemsettings] [Bug 417493] Light GTK theme doesn't override gtk-application-prefer-dark-theme

2020-02-13 Thread Frederick Zhang
https://bugs.kde.org/show_bug.cgi?id=417493 --- Comment #7 from Frederick Zhang --- I'm actually *not* using Breeze but Materia-light-compact instead. As it's a third-party theme I tested the case with Breeze hence it in this filed issue. While I agree that users who choose Breeze *usually* are

[systemsettings] [Bug 417493] Light GTK theme doesn't override gtk-application-prefer-dark-theme

2020-02-13 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=417493 Nate Graham changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED

[systemsettings] [Bug 417493] Light GTK theme doesn't override gtk-application-prefer-dark-theme

2020-02-13 Thread Mikhail Zolotukhin
https://bugs.kde.org/show_bug.cgi?id=417493 --- Comment #5 from Mikhail Zolotukhin --- (In reply to Frederick Zhang from comment #4) > some GTK applications become straight appalling, > e.g. Firefox and (especially) Thunderbird. It's a problem of those applications, that they fail to correctly u

[systemsettings] [Bug 417493] Light GTK theme doesn't override gtk-application-prefer-dark-theme

2020-02-13 Thread Frederick Zhang
https://bugs.kde.org/show_bug.cgi?id=417493 --- Comment #4 from Frederick Zhang --- Well, I'm actually using a dark global theme and a light GTK application style since some GTK applications have got their own theme engines, which look great btw, but with a dark background they become straight ap

[systemsettings] [Bug 417493] Light GTK theme doesn't override gtk-application-prefer-dark-theme

2020-02-13 Thread Mikhail Zolotukhin
https://bugs.kde.org/show_bug.cgi?id=417493 --- Comment #3 from Mikhail Zolotukhin --- (In reply to Frederick Zhang from comment #2) > But the GTK style should have taken precedence, right? No, it should not. The GTK theme should either: 1. Grab it's colors from color definitions, that were gen

[systemsettings] [Bug 417493] Light GTK theme doesn't override gtk-application-prefer-dark-theme

2020-02-13 Thread Frederick Zhang
https://bugs.kde.org/show_bug.cgi?id=417493 --- Comment #2 from Frederick Zhang --- But the GTK style should have taken precedence, right? -- You are receiving this mail because: You are watching all bug changes.

[systemsettings] [Bug 417493] Light GTK theme doesn't override gtk-application-prefer-dark-theme

2020-02-12 Thread Mikhail Zolotukhin
https://bugs.kde.org/show_bug.cgi?id=417493 --- Comment #1 from Mikhail Zolotukhin --- The value is decided by selected color scheme in Colors KCM. If the color scheme is light - it is zero, if not - it is one. -- You are receiving this mail because: You are watching all bug changes.

[systemsettings] [Bug 417493] Light GTK theme doesn't override gtk-application-prefer-dark-theme

2020-02-12 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=417493 Nate Graham changed: What|Removed |Added Assignee|k...@davidedmundson.co.uk|plasma-b...@kde.org Product|plasmashe