[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 caulier.gil...@gmail.com changed: What|Removed |Added Component|Database-Scan |Database-Setup -- You are receiving

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 caulier.gil...@gmail.com changed: What|Removed |Added Resolution|--- |FIXED Version Fixed In|

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #59 from caulier.gil...@gmail.com --- Excelent. Thanks a lot Jan. I will have plenty of time while this week end to review this patch for next 5.5.0 release. Gilles -- You are receiving this mail because: You are watching all bug

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 Jan Wolter changed: What|Removed |Added Attachment #103660|0 |1 is obsolete|

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #57 from caulier.gil...@gmail.com --- digikam --help Usage: digikam [options] Manage your photographs like a professional, with the power of open source Options: -v, --version Displays version information. -h, --help

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #56 from Jan Wolter --- Yes, I agree that this is the most consistent way. But what do you mean that "DB file to use with digiKam session can be passed on CLI."? -- You are receiving this mail because: You are watching

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #55 from caulier.gil...@gmail.com --- I vote for 2/, for these reasons : 1/ to be homogeneous with other settings. 2/ each collection database file can be customized. The settings is not common and is portable. Remember that DB file to use

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #54 from Jan Wolter --- Hi Gilles, ok, I will support default settings. I looked a bit deeper in the code defining the default settings for mime types. They are all directly stored in the SQLite DB in the settings table,

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #53 from caulier.gil...@gmail.com --- Well the info dialog is perfect. Just add a default ignore settings user will expected to have in core digiKam, as it's done with mime type settings. We need to be homogeneous here. Gilles -- You are

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #52 from Jan Wolter --- Hello Gilles, I suppose, we have a misunderstanding here. My patch does not introduce new directories that get ignored by default. Even the @eaDir directory gets ignored only, when a user adds it

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #51 from caulier.gil...@gmail.com --- Jan, I stil to not understand how this patch can work in background level to ignore some kind of subdirectories at scan. You said : "For example, when you store your Synology NAS (Network Attached

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #50 from caulier.gil...@gmail.com --- MTP camera is relevant of Import tool, not database scanning process. By scanning, we talk about the process which scan collections to register items to database. removal camera are driven by Import

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #49 from C Doe --- I have to admit I have not followed the entire discussion here, but I wanted to throw in my 2 cents... The fix for this bug/feature request should allow users to exclude MTP mounted smartphone

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #48 from Jan Wolter --- Created attachment 103660 --> https://bugs.kde.org/attachment.cgi?id=103660=edit Newest version of patch Hello Gilles, I added an info pop-up as in the mime config including the explanation that

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 caulier.gil...@gmail.com changed: What|Removed |Added Platform|unspecified |Compiled Sources -- You are

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #47 from caulier.gil...@gmail.com --- yes exactly. The new option in setup database must permit to define new combinaison of ignored directory schemes. By default we must already set in database interface some problematic schemes that we

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #46 from Jan Wolter --- Hello Gilles, thanks for your help and your feedback. With your hint it generally works, thats great! Now to your point regarding a default ignore list: The examples you mentioned all begin with

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #45 from caulier.gil...@gmail.com --- Jan, I'm not fully satisfied by this patch. 1/ we must set a default ignore list of files/directories already know as problematic while scanning collections For example : - under MacOS, .DS_Store

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 caulier.gil...@gmail.com changed: What|Removed |Added Attachment #101955|0 |1 is obsolete|

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #43 from caulier.gil...@gmail.com --- Jan to your question from #40. In SetupDatabase, when you change ignored directories settings, If think you just need to to call AlbumManager::instance()->changeDatabase(params) to update global DB

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #42 from caulier.gil...@gmail.com --- I'm on holidays this week end for 2 weeks. I will have plenty of time to respond. For the moment, until Saturday evening, i'm very busy in my office... Gilles -- You are receiving this mail because:

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #41 from Jan Wolter --- Hello Gilles, do you have any hint for me to update CoreDbAccess after updating dbEngineParameters? It would be great if you could help me to fix this last problem to get it work before dk 5.4

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #40 from Jan Wolter --- Created attachment 102753 --> https://bugs.kde.org/attachment.cgi?id=102753=edit Patch Hi Gilles, I have attached a version without the crash caused by the wrong call of

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #39 from Jan Wolter --- Created attachment 102709 --> https://bugs.kde.org/attachment.cgi?id=102709=edit New version of Patch Hi Gilles, see attached the patch. To update the paramters in CoreDbAccess according to the

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #38 from caulier.gil...@gmail.com --- Please share the new patch to review the code. It will be more easy. Gilles -- You are receiving this mail because: You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #37 from Jan Wolter --- Hi Gilles, when changes in the new ignoredDirectories settings text field are made I trigger now a album rescan to ignore the directories. At this moment the dbEngineParameters contain the newly

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #36 from caulier.gil...@gmail.com --- 5.4.0 is planed before Christmas. Don't forget that i need at least one week before release date to check implmentation, and to lets time to translators to update i18n with new strings introduced with

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #35 from Jan Wolter --- Hi Gilles, since my last update there is no further progress, but I hope to find time to complete the last 20% till next release. For what date in December is version 5.4 planned? -- You are

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #34 from caulier.gil...@gmail.com --- Jan, Any progress to complete the patch before 5.4.0 release planed in December ? Gilles Caulier -- You are receiving this mail because: You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #33 from caulier.gil...@gmail.com --- Arnaud, Yes, it's planed to include it for next 5.4.0 if Jan complete it in time, which will be the case as 80% of the patch is already done... Gilles Caulier -- You are receiving this mail because:

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 Arnaud changed: What|Removed |Added CC||arn...@croes.be --- Comment #32 from

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #31 from Jan Wolter --- Created attachment 102158 --> https://bugs.kde.org/attachment.cgi?id=102158=edit Update Patch IgnoreDirectories Hello Gilles, yes there are progress. The attached patch supports the requested

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #30 from caulier.gil...@gmail.com --- Jan, Any progress here to be able to include your patch in next 5.4.0 release ? Thanks in advance Gilles Caulier -- You are receiving this mail because: You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 François Tissandier changed: What|Removed |Added CC|

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #29 from caulier.gil...@gmail.com --- ok, Also, i see in Setup dialog databse page that some TODO are not yet implemented, especially for the GUI. Gilles Caulier -- You are receiving this mail because: You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #28 from Jan Wolter --- Hello Gilles, thanks for your help. I will show your code the next days and complete the fix for this issue. @Note 1: Ok, I will replace tabs by blanks. @Note 2: You are right, "@eaDir" is still

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 caulier.gil...@gmail.com changed: What|Removed |Added Attachment #101805|0 |1 is obsolete|

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 caulier.gil...@gmail.com changed: What|Removed |Added Attachment #89319|0 |1 is obsolete|

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 caulier.gil...@gmail.com changed: What|Removed |Added Attachment #95010|0 |1 is obsolete|

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 caulier.gil...@gmail.com changed: What|Removed |Added Attachment #101781|0 |1 is obsolete|

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #26 from Jan Wolter --- Created attachment 101805 --> https://bugs.kde.org/attachment.cgi?id=101805=edit Patch on current repository status The same problem on current status. The problem seem to be somewhere under the

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #25 from Jan Wolter --- Created attachment 101781 --> https://bugs.kde.org/attachment.cgi?id=101781=edit IgnoreDirectories-Patch dk 5 Hello Gilles, I found some time to port my fix to new dk version 5. The attached

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #24 from Jan Wolter --- Hi Gilles, at the moment I didn't tested it. But I hope I will find some time to test it with dg 5 during the next 2-3 weeks. -- You are receiving this mail because: You are watching all bug

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 --- Comment #23 from caulier.gil...@gmail.com --- Jan, Do you have a revised version of your patch working with current implmeentation from git/master based on Qt5 ? Gilles Caulier -- You are receiving this mail because: You are watching all bug

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

https://bugs.kde.org/show_bug.cgi?id=123097 C Doe changed: What|Removed |Added CC||cfd...@gmail.com -- You are