https://bugs.kde.org/show_bug.cgi?id=473278
--- Comment #23 from Nate Graham ---
Git commit a7f4bb6123d62c35633f18cb724581f06c25412c by Nate Graham.
Committed on 26/11/2023 at 17:43.
Pushed by ngraham into branch 'master'.
Use symbolic icon for system tray
We have it; let's use it! If
https://bugs.kde.org/show_bug.cgi?id=473278
--- Comment #22 from Bug Janitor Service ---
A possibly relevant merge request was started @
https://invent.kde.org/utilities/yakuake/-/merge_requests/117
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=473278
--- Comment #21 from Nate Graham ---
You're welcome!
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=473278
--- Comment #20 from Eric Armbruster ---
Thanks a lot for fixing this
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=473278
Nate Graham changed:
What|Removed |Added
Status|CONFIRMED |RESOLVED
Latest Commit|
https://bugs.kde.org/show_bug.cgi?id=473278
--- Comment #18 from Nate Graham ---
Ok, I think that's as good as I can do right now. The Kate Sessions and Weather
widgets still show colorful icons because symbolic versions of them don't exist
yet. See Bug 473461 and Bug 403833. That's a general
https://bugs.kde.org/show_bug.cgi?id=473278
--- Comment #17 from Nate Graham ---
Git commit f0030033758f6a54f0f4cfb0e2a6927c493de0fa by Nate Graham.
Committed on 16/08/2023 at 20:09.
Pushed by ngraham into branch 'master'.
applets/weather: use symbolic icons when in panel
Currently this code
https://bugs.kde.org/show_bug.cgi?id=473278
--- Comment #16 from Nate Graham ---
Git commit c6f0afc645bb9226662b756656dca5586736a7d2 by Nate Graham.
Committed on 16/08/2023 at 19:54.
Pushed by ngraham into branch 'master'.
applets/katesessions: set Plasmoid.icon to a symbolic icon when in panel
https://bugs.kde.org/show_bug.cgi?id=473278
--- Comment #15 from Nate Graham ---
Git commit f00f39467bed3a07f095aced292b2c16f0ad7e7d by Nate Graham.
Committed on 16/08/2023 at 19:51.
Pushed by ngraham into branch 'master'.
applets/konsoleprofiles: use symbolic icon when in a panel
M +7-4
https://bugs.kde.org/show_bug.cgi?id=473278
--- Comment #14 from Nate Graham ---
Git commit db3aa99a63318e47f0d875c4b6935c4988ebcb5f by Nate Graham.
Committed on 16/08/2023 at 19:44.
Pushed by ngraham into branch 'master'.
applet: always show symbolic icon when in a panel
The icon used for the
https://bugs.kde.org/show_bug.cgi?id=473278
--- Comment #13 from Nate Graham ---
Git commit fe44091520ad123fbb599cfa59e7ab2278affa11 by Nate Graham.
Committed on 16/08/2023 at 19:25.
Pushed by ngraham into branch 'master'.
applets/notifications: set Plasmoid.icon
The actual icon is drawn by
https://bugs.kde.org/show_bug.cgi?id=473278
--- Comment #12 from Nate Graham ---
Git commit 33d319ca3bbbc7598130dc4520e3c71f98fb0dd0 by Nate Graham.
Committed on 16/08/2023 at 19:20.
Pushed by ngraham into branch 'master'.
applets/batterymonitor: use fallback icon that exists
"batteries"
https://bugs.kde.org/show_bug.cgi?id=473278
--- Comment #11 from Nate Graham ---
Git commit 78ce06fcaeef0e3ff0c272291b6f18509db0f3bc by Nate Graham.
Committed on 16/08/2023 at 19:20.
Pushed by ngraham into branch 'master'.
applets/batterymonitor: use symbolic fallback icon when in panel
M +28
https://bugs.kde.org/show_bug.cgi?id=473278
--- Comment #10 from Nate Graham ---
Looks like these applets aren't setting their Plasmoid.Icon properties at all,
and are relying on custom icon items which happen to get drawn in the tray.
This should be easy enough to fix, and it's good that we
https://bugs.kde.org/show_bug.cgi?id=473278
--- Comment #9 from Nate Graham ---
Ah yeah, that works! I was so fixated on the icon being nullptr that I didn't
consider that the applet itself might be nullptr.
I can take it from here, yeah. Thanks a lot for your help.
--
You are receiving this
https://bugs.kde.org/show_bug.cgi?id=473278
--- Comment #8 from Eric Armbruster ---
Haven't gotten much time at hand, the problem is we need to check whether
applet is nullptr
diff --git a/applets/systemtray/systemtraymodel.cpp
b/applets/systemtray/systemtraymodel.cpp
index da2dcf8d2..9d1d9b5c3
https://bugs.kde.org/show_bug.cgi?id=473278
--- Comment #7 from Nate Graham ---
Sure, apply this diff to plasma-workspace:
diff --git a/applets/systemtray/systemtraymodel.cpp
b/applets/systemtray/systemtraymodel.cpp
index da2dcf8d2..d81775c92 100644
--- a/applets/systemtray/systemtraymodel.cpp
https://bugs.kde.org/show_bug.cgi?id=473278
--- Comment #6 from Eric Armbruster ---
Or cc @eric on Gitlab
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=473278
--- Comment #5 from Eric Armbruster ---
Could you upload your current state of work to a branch and post a link here? I
could try to take a look as well.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=473278
--- Comment #4 from Nate Graham ---
I agree, and that's the option I started implementing. Unfortunately I have not
been able to figure out how to fix the crash that it causes, so this work is on
hold for now.
--
You are receiving this mail because:
https://bugs.kde.org/show_bug.cgi?id=473278
--- Comment #3 from Eric Armbruster ---
I think the downside of option two is actually more of an upside, at least for
me, since you might already be looking for exactly that icon (with that active
status) anyway. So I would favor option two.
--
You
https://bugs.kde.org/show_bug.cgi?id=473278
Nate Graham changed:
What|Removed |Added
See Also||https://bugs.kde.org/show_b
|
https://bugs.kde.org/show_bug.cgi?id=473278
--- Comment #2 from Nate Graham ---
Investigated a bit. We have two options:
1. Append "-symbolic" to the current name of the icon we're asking for in the
config window, which is the icon in the applet's JSON metadata
2. Stop using the JSON Metadata
https://bugs.kde.org/show_bug.cgi?id=473278
Nate Graham changed:
What|Removed |Added
Summary|Monochrome Icons for System |Icons in "System Tray
|Tray
24 matches
Mail list logo
