fix on x86_64

2006-06-23 Thread Laurent Montel
Hi, as discussed on irc, we don't define KDELIBSTUFF which is used into kstandarddirs.cpp So I created a patch to fix it and define it. Is it ok to commit it ? Regards Index: FindKDE4Internal.cmake === --- FindKDE4Internal.cmake (re

Re: fix on x86_64

2006-06-23 Thread Laurent Montel
On Friday 23 June 2006 10:45, Laurent Montel wrote: > Hi, > as discussed on irc, we don't define KDELIBSTUFF which is used into > kstandarddirs.cpp > So I created a patch to fix it and define it. > > Is it ok to commit it ? > > Regards Remove typo into patch Index: FindKDE4Internal.cmake =

Finding qmake

2006-06-23 Thread Simon Perreault
Hi, Currently, FindQt4.cmake searches for "qmake" before "qmake-qt4". I think that's wrong and that it should be reversed. Why: When qmake (from Qt3) and qmake-qt4 are in the $PATH, the check fails unless the order is reversed. Why not: I can't see any reason why not. I'm asking because my co

Re: Finding qmake

2006-06-23 Thread William A. Hoffman
At 08:44 AM 6/23/2006, Simon Perreault wrote: >Alexander also provided the following suggestion: "consider adjusting PATH or >specifying QT4_QMAKE_EXECUTABLE directly." Adjusting PATH is not an option >because both qmake and qmake-qt4 live in /usr/bin on my system (Debian). I >tried specifying Q

Re: Finding qmake

2006-06-23 Thread Alexander Neundorf
Hi, On Friday 23 June 2006 14:44, you wrote: > Hi, > > Currently, FindQt4.cmake searches for "qmake" before "qmake-qt4". I think > that's wrong and that it should be reversed. > > Why: When qmake (from Qt3) and qmake-qt4 are in the $PATH, the check fails > unless the order is reversed. > > Why not

Re: Finding qmake

2006-06-23 Thread Michael Biebl
2006/6/23, Simon Perreault <[EMAIL PROTECTED]>: > Hi, > > Currently, FindQt4.cmake searches for "qmake" before "qmake-qt4". I think > that's wrong and that it should be reversed. > > Why: When qmake (from Qt3) and qmake-qt4 are in the $PATH, the check fails > unless the order is reversed. > > Why n

Re: Finding qmake

2006-06-23 Thread Simon Perreault
On Friday June 23 2006 11:05, Alexander Neundorf wrote: > > I contacted him, but he wouldn't provide me with any > > justification. > > Privately or to kde-commits ? Please reply privately if it is important. I contacted you privately. Message-Id: <[EMAIL PROTECTED]> > No, not the people who have

Re: Finding qmake

2006-06-23 Thread Benjamin Reed
On 6/23/06, Simon Perreault <[EMAIL PROTECTED]> wrote: > Currently, FindQt4.cmake searches for "qmake" before "qmake-qt4". I think > that's wrong and that it should be reversed. > > Why: When qmake (from Qt3) and qmake-qt4 are in the $PATH, the check fails > unless the order is reversed. It seems

Re: Finding qmake

2006-06-23 Thread Simon Perreault
On Friday June 23 2006 11:20, Benjamin Reed wrote: > How about checking the version of each one, and pick the highest one? > Then it will always be "correct". Or at least skipping any Qt 3 qmake would be nice... ___ Kde-buildsystem mailing list Kde-build

Merged: MacroLogFeature and MacroLogRequirement

2006-06-23 Thread Allen Winter
Howdy, As promised, attached is my attempt to merge Alex's MacroLogFeature() and the MacroLogRequirement() I posted here a few weeks back. Basically, you pass a variable that says whether a feature is a requirement. There are also new variables for Minimum_Version and Comments. Also attached i