Hello,
Ok, my comments about your reduced_linking_2.patch can be found below:
> khtml
> LINK_INTERFACE_LIBRARIES "kparts;kjs;kio;kdeui;kdecore"
Please drop kjs. It is definitely excess here because none of our
target_link_libraries fixes has ever included it.
> krosscore
> LINK_INTERFACE_LIBRAR
On Sunday 29 June 2008, Modestas Vainius wrote:
> Hello,
>
> Ok, my comments about your reduced_linking_2.patch can be found below:
Thanks for reviewing :-)
> > khtml
> > LINK_INTERFACE_LIBRARIES "kparts;kjs;kio;kdeui;kdecore"
>
> Please drop kjs. It is definitely excess here because none of our
Alexander Neundorf wrote:
>> The only QtXml user is kross/core/action.h
>> fromDomElement/toDomElement. I don't think this is enough to link all
>> krosscore users against QtXml.
>
>Hmm, is it a real problem if QtXml is listed here ? It shouldn't add
> more package dependencies (QtXml should be ins
On Monday 30 June 2008, you wrote:
> Alexander Neundorf wrote:
> >> The only QtXml user is kross/core/action.h
> >> fromDomElement/toDomElement. I don't think this is enough to link all
> >> krosscore users against QtXml.
> >
> >Hmm, is it a real problem if QtXml is listed here ? It shouldn't add
>
